From 37e64414789ae722c19e6dc10e9e2354615447c5 Mon Sep 17 00:00:00 2001 From: Luca Stefani Date: Wed, 15 Jul 2020 10:04:13 +0200 Subject: [PATCH] repo_pull: Remove required -g param in repo_review * Also add missing import * Update README to reflect new parameters Change-Id: I929b165430d9ad3585c86fe771b7838804b9d2ea --- tools/repo_pull/README.md | 1 - tools/repo_pull/repo_review.py | 10 +++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/repo_pull/README.md b/tools/repo_pull/README.md index c4723ea41..c8c04bc89 100644 --- a/tools/repo_pull/README.md +++ b/tools/repo_pull/README.md @@ -70,7 +70,6 @@ These are common queries: ### Options * `-g` or `--gerrit` specifies the URL of the Gerrit Code Review website. - *(required)* * `-b` or `--branch` specifies the local branch name that will be passed to `repo start`. diff --git a/tools/repo_pull/repo_review.py b/tools/repo_pull/repo_review.py index 535f5249f..34ac44a0d 100755 --- a/tools/repo_pull/repo_review.py +++ b/tools/repo_pull/repo_review.py @@ -31,9 +31,10 @@ except ImportError: from urllib2 import HTTPError # PY2 from gerrit import ( - add_reviewers, delete_reviewer, abandon, create_url_opener_from_args, - delete_topic, query_change_lists, set_hashtags, set_review, set_topic, - submit) + abandon, add_reviewers, create_url_opener_from_args, delete_reviewer, + delete_topic, find_gerrit_name, query_change_lists, set_hashtags, + set_review, set_topic, submit +) def _get_labels_from_args(args): @@ -87,8 +88,7 @@ def _parse_args(): parser = argparse.ArgumentParser() parser.add_argument('query', help='Change list query string') - parser.add_argument('-g', '--gerrit', required=True, - help='Gerrit review URL') + parser.add_argument('-g', '--gerrit', help='Gerrit review URL') parser.add_argument('--gitcookies', default=os.path.expanduser('~/.gitcookies'),