From 082f6a661fcece6ac2c2276ccd00da1e95b0b92f Mon Sep 17 00:00:00 2001
From: Vishnu Nair <vishnun@google.com>
Date: Tue, 16 Feb 2021 16:19:09 -0800
Subject: [PATCH] Add visible region to list of visibility reasons

Test: open trace from bug
Fixes: 157252333
Change-Id: Ifebac00a112798bbd03cf74458a1ffc7682890f6
---
 tools/winscope/src/sf_visibility.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/winscope/src/sf_visibility.js b/tools/winscope/src/sf_visibility.js
index 17071974c..7ef8837f9 100644
--- a/tools/winscope/src/sf_visibility.js
+++ b/tools/winscope/src/sf_visibility.js
@@ -144,7 +144,7 @@ function is_visible(layer, hiddenByPolicy, includesCompositionState) {
   return true;
 }
 
-function get_visibility_reason(layer) {
+function get_visibility_reason(layer, includesCompositionState) {
   if (layer.type === 'ContainerLayer') {
     return 'ContainerLayer';
   }
@@ -193,6 +193,10 @@ function get_visibility_reason(layer) {
     return 'Layer is occluded by:' + layer.occludedBy.join();
   }
 
+  if (includesCompositionState && is_empty(layer.visibleRegion)) {
+    return 'Visible region calculated by Composition Engine is empty';
+  }
+
   if (layer.visible) {
     return 'Unknown';
   };
@@ -256,7 +260,7 @@ function fill_occlusion_state(layerMap, rootLayers, includesCompositionState) {
 
     layer.visible = is_visible(layer, layer.hidden, includesCompositionState);
     if (!layer.visible) {
-      layer.invisibleDueTo = get_visibility_reason(layer);
+      layer.invisibleDueTo = get_visibility_reason(layer, includesCompositionState);
     }
   });
 }