LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ndk: Fix potential event handling issue in android_native_app_glue

Browse Source 
Developers report that concurrent events generated from different
sources/devices can lead to application freezes then ANRs.

See https://code.google.com/p/android/issues/detail?id=41755

where it is suggested that handling all incoming events in
the "process_input" callback solves the issue. Hence this patch
implements the suggestion, however it's unclear whether this
solves the symptom, or the root cause of the problem.

Change-Id: Ic6b0ad05d192763a6d8842c8befcb87db9714a3c
This commit is contained in:
David 'Digit' Turner
2013-03-20 11:13:38 +01:00
parent 7b9e308b95
commit 0d92cf5450
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ndk/sources/android/native_app_glue/android_native_app_glue.c
View File

@@ -186,15 +186,18 @@ static void android_app_destroy(struct android_app* android_app) {
static void process_input(struct android_app* app, struct android_poll_source* source) {
AInputEvent* event = NULL;
if (AInputQueue_getEvent(app->inputQueue, &event) >= 0) {
int processed = 0;
while (AInputQueue_getEvent(app->inputQueue, &event) >= 0) {
LOGV("New input event: type=%d\n", AInputEvent_getType(event));
if (AInputQueue_preDispatchEvent(app->inputQueue, event)) {
return;
continue;
}
int32_t handled = 0;
if (app->onInputEvent != NULL) handled = app->onInputEvent(app, event);
AInputQueue_finishEvent(app->inputQueue, event, handled);
} else {
processed = 1;
}
if (processed == 0) {
LOGE("Failure reading next input event: %s\n", strerror(errno));
}
}