LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add file whitelisting capabilities to checkstyle.py

Browse Source 
Certain projects might want to enable checkstyle gradually so
we need a way to whitelist which files should be checked.

Test: added test_FilterFiles
Change-Id: I501677ce824f882ccb5f2ad129af8f596d01c6e8
This commit is contained in:
Aurimas Liutikas
2016-10-11 13:47:48 -07:00
parent 5b7b38f62e
commit 21b3a7463b
2 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/checkstyle/tests.py
View File

@@ -152,5 +152,16 @@ class TestCheckstyle(unittest.TestCase):
output = out.getvalue()
self.assertEqual(output, '')
def test_FilterFiles(self):
files = {TEST_FILE1: FILE_MODIFIED, TEST_FILE2: FILE_ADDED}
output = checkstyle._FilterFiles(files, None)
self.assertEqual(files, output)
output = checkstyle._FilterFiles(files, ['Blarg2'])
self.assertEqual({TEST_FILE2: FILE_ADDED}, output)
output = checkstyle._FilterFiles(files, ['Blarg'])
self.assertEqual(files, output)
output = checkstyle._FilterFiles(files, ['FunkyTown'])
self.assertEqual({}, output)
if __name__ == '__main__':
unittest.main()