Merge changes from topic "c2a-apex"

* changes:
  Let cargo2android.py generate apex_available and min_sdk_version.
  Allow cargo2android.py to use a config file instead of command-line options.
This commit is contained in:
Treehugger Robot
2021-04-28 14:50:54 +00:00
committed by Gerrit Code Review

View File

@@ -51,6 +51,7 @@ from update_crate_tests import TestMapping
import argparse import argparse
import glob import glob
import json
import os import os
import os.path import os.path
import platform import platform
@@ -648,6 +649,13 @@ class Crate(object):
self.dump_edition_flags_libs() self.dump_edition_flags_libs()
if self.runner.args.host_first_multilib and self.host_supported and crate_type != 'test': if self.runner.args.host_first_multilib and self.host_supported and crate_type != 'test':
self.write(' compile_multilib: "first",') self.write(' compile_multilib: "first",')
if self.runner.args.apex_available and crate_type == 'lib':
self.write(' apex_available: [')
for apex in self.runner.args.apex_available:
self.write(' "%s",' % apex)
self.write(' ],')
if self.runner.args.min_sdk_version and crate_type == 'lib':
self.write(' min_sdk_version: "%s",' % self.runner.args.min_sdk_version)
self.write('}') self.write('}')
def dump_android_flags(self): def dump_android_flags(self):
@@ -1474,7 +1482,7 @@ class Runner(object):
self.find_warning_owners() self.find_warning_owners()
def parse_args(): def get_parser():
"""Parse main arguments.""" """Parse main arguments."""
parser = argparse.ArgumentParser('cargo2android') parser = argparse.ArgumentParser('cargo2android')
parser.add_argument( parser.add_argument(
@@ -1580,6 +1588,14 @@ def parse_args():
default=False, default=False,
help=('run cargo build with existing Cargo.lock ' + help=('run cargo build with existing Cargo.lock ' +
'(used when some latest dependent crates failed)')) '(used when some latest dependent crates failed)'))
parser.add_argument(
'--min-sdk-version',
type=str,
help='Minimum SDK version')
parser.add_argument(
'--apex-available',
nargs='*',
help='Mark the main library as apex_available with the given apexes.')
parser.add_argument( parser.add_argument(
'--no-test-mapping', '--no-test-mapping',
action='store_true', action='store_true',
@@ -1595,14 +1611,54 @@ def parse_args():
action='store_true', action='store_true',
default=False, default=False,
help='run cargo with -vv instead of default -v') help='run cargo with -vv instead of default -v')
return parser.parse_args() parser.add_argument(
'--dump-config-and-exit',
type=str,
help=('Dump command-line arguments (minus this flag) to a config file and exit. ' +
'This is intended to help migrate from command line options to config files.'))
parser.add_argument(
'--config',
type=str,
help=('Load command-line options from the given config file. ' +
'Options in this file will override those passed on the command line.'))
return parser
def parse_args(parser):
"""Parses command-line options."""
args = parser.parse_args()
# Use the values specified in a config file if one was found.
if args.config:
with open(args.config, 'r') as f:
config = json.load(f)
args_dict = vars(args)
for arg in config:
args_dict[arg.replace('-', '_')] = config[arg]
return args
def dump_config(parser, args):
"""Writes the non-default command-line options to the specified file."""
args_dict = vars(args)
# Filter out the arguments that have their default value.
non_default_args = {}
for arg in args_dict:
if args_dict[arg] != parser.get_default(arg) and arg != 'dump_config_and_exit':
non_default_args[arg.replace('_', '-')] = args_dict[arg]
# Write to the specified file.
with open(args.dump_config_and_exit, 'w') as f:
json.dump(non_default_args, f, indent=2, sort_keys=True)
def main(): def main():
args = parse_args() parser = get_parser()
args = parse_args(parser)
if not args.run: # default is dry-run if not args.run: # default is dry-run
print(DRY_RUN_NOTE) print(DRY_RUN_NOTE)
Runner(args).run_cargo().gen_bp().apply_patch().dump_test_mapping_files() if args.dump_config_and_exit:
dump_config(parser, args)
else:
Runner(args).run_cargo().gen_bp().apply_patch().dump_test_mapping_files()
if __name__ == '__main__': if __name__ == '__main__':