From 31d0121f684fbd5eba4c9ad612b850732b659f40 Mon Sep 17 00:00:00 2001 From: Raphael Date: Fri, 9 Oct 2009 14:20:04 -0700 Subject: [PATCH] Fix adt-tests: remove UpdaterLogicTest Also reverts UpdaterLogic as package-private and adds some javadoc to it. SDK BUG 2179267 Change-Id: I19644cc4c99ac70598f3cbcfface2f19d9999931 --- tools/eclipse/scripts/create_test_symlinks.sh | 1 - .../internal/repository/UpdaterLogic.java | 16 +++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/tools/eclipse/scripts/create_test_symlinks.sh b/tools/eclipse/scripts/create_test_symlinks.sh index 83141c740..2b2405b0f 100755 --- a/tools/eclipse/scripts/create_test_symlinks.sh +++ b/tools/eclipse/scripts/create_test_symlinks.sh @@ -68,7 +68,6 @@ fi DEST=$BASE/unittests/com/android cpdir $DEST development/tools/ddms/libs/ddmlib/tests/src/com/android/ddmlib cpdir $DEST development/tools/sdkmanager/libs/sdklib/tests/com/android/sdklib -cpdir $DEST development/tools/sdkmanager/libs/sdkuilib/tests/com/android/sdkuilib DEST=$BASE/unittests/com/android/layoutlib mkdir -p $DEST diff --git a/tools/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/UpdaterLogic.java b/tools/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/UpdaterLogic.java index ff4b9c5a1..9bdd2a726 100755 --- a/tools/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/UpdaterLogic.java +++ b/tools/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/UpdaterLogic.java @@ -29,10 +29,24 @@ import com.android.sdklib.internal.repository.Package.UpdateInfo; import java.util.ArrayList; import java.util.Collection; -public /* public for continuous tests */ class UpdaterLogic { +/** + * The logic to compute which packages to install, based on the choices + * made by the user. This adds dependent packages as needed. + *

+ * When the user doesn't provide a selection, looks at local package to find + * those that can be updated and compute dependencies too. + */ +class UpdaterLogic { private RepoSources mSources; + /** + * Compute which packages to install by taking the user selection + * and adding dependent packages as needed. + * + * When the user doesn't provide a selection, looks at local package to find + * those that can be updated and compute dependencies too. + */ public ArrayList computeUpdates( Collection selectedArchives, RepoSources sources,