From ec469d15eadf5363a5e781a3687663c19efb3a10 Mon Sep 17 00:00:00 2001 From: Yi-Yo Chiang Date: Mon, 23 May 2022 17:16:56 +0800 Subject: [PATCH] create_reference_dumps.py: Clear SKIP_ABI_CHECKS It's possible that a developer would set SKIP_ABI_CHECKS during development, and only execute create_reference_dumps.py before submitting the change. If the developer forgot to clear SKIP_ABI_CHECKS before running create_reference_dumps.py, the developer would be hit by a confusing error (something about lsdump_paths.txt has invalid format), because some preconditions of create_reference_dumps.py aren't met. The error message isn't helpful as it doesn't tell the developer how to resolve the error. Let's just unset SKIP_ABI_CHECKS in create_reference_dumps.py, so create_reference_dumps.py can be as fool-proof as possible. The developer doesn't need to know the preconditions of create_reference_dumps.py as it should handle it by itself. Bug: 233562033 Test: export SKIP_ABI_CHECKS=true && ./create_reference_dumps.py Change-Id: I397f1fcad7f0a1f9a7cb2781f32d85cdf2439e60 --- vndk/tools/header-checker/utils/create_reference_dumps.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vndk/tools/header-checker/utils/create_reference_dumps.py b/vndk/tools/header-checker/utils/create_reference_dumps.py index 5c0768ced..4b7876b80 100755 --- a/vndk/tools/header-checker/utils/create_reference_dumps.py +++ b/vndk/tools/header-checker/utils/create_reference_dumps.py @@ -198,6 +198,9 @@ def _parse_args(): def main(): args = _parse_args() + # Clear SKIP_ABI_CHECKS as it forbids ABI dumps from being built. + os.environ.pop('SKIP_ABI_CHECKS', None) + start = time.time() num_processed = create_source_abi_reference_dumps_for_all_products(args) end = time.time()