From 38dbb6c1953c64b2adbf81c5574654b8fce2e294 Mon Sep 17 00:00:00 2001 From: Pablo Gamito Date: Fri, 16 Dec 2022 13:03:28 +0000 Subject: [PATCH] Make sure UI send empty trace configs to proxy Otherwise when we don't select any of the trace configuration we won't update the tracing config and will just use the latest config Test: deselect all trace config flags and make sure that config is set when tracing Bug: 262563422 Change-Id: If55d6a0592552c1ebeb5d928073fe9d12440a3f1 --- .../src/app/components/collect_traces.component.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/winscope-ng/src/app/components/collect_traces.component.ts b/tools/winscope-ng/src/app/components/collect_traces.component.ts index 952b9ec5c..0af3c1178 100644 --- a/tools/winscope-ng/src/app/components/collect_traces.component.ts +++ b/tools/winscope-ng/src/app/components/collect_traces.component.ts @@ -425,7 +425,7 @@ export class CollectTracesComponent implements OnInit, OnDestroy { }); } - private requestedEnableConfig(): Array | undefined { + private requestedEnableConfig(): Array { const req: Array = []; const tracingConfig = this.tracingConfig.getTracingConfig(); Object.keys(tracingConfig) @@ -442,9 +442,6 @@ export class CollectTracesComponent implements OnInit, OnDestroy { }); } }); - if (req.length === 0) { - return undefined; - } return req; }