LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge "gdbclient.py: Fix gdb-remote command for non-local $ANDROID_SERIAL."

Browse Source
This commit is contained in:
Peter Collingbourne
2023-03-16 00:27:43 +00:00
committed by Gerrit Code Review
parent b25a156d0f b6b58a4d82
commit 462ff76c54
1 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
scripts/gdbclient.py
View File

@@ -242,12 +242,7 @@ def handle_switches(args, sysroot):
return (binary_file, pid, run_cmd) return (binary_file, pid, run_cmd)
def format_hostport(host, port): def generate_vscode_lldb_script(root, sysroot, binary_name, port, solib_search_path):
if host is not None:
return "{}:{}".format(host, port)
return str(port)
def generate_vscode_lldb_script(root, sysroot, binary_name, host, port, solib_search_path):
# TODO It would be nice if we didn't need to copy this or run the # TODO It would be nice if we didn't need to copy this or run the
# lldbclient.py program manually. Doing this would probably require # lldbclient.py program manually. Doing this would probably require
# writing a vscode extension or modifying an existing one. # writing a vscode extension or modifying an existing one.
@@ -263,11 +258,11 @@ def generate_vscode_lldb_script(root, sysroot, binary_name, host, port, solib_se
"initCommands": ['settings append target.exec-search-paths {}'.format(' '.join(solib_search_path))], "initCommands": ['settings append target.exec-search-paths {}'.format(' '.join(solib_search_path))],
"targetCreateCommands": ["target create {}".format(binary_name), "targetCreateCommands": ["target create {}".format(binary_name),
"target modules search-paths add / {}/".format(sysroot)], "target modules search-paths add / {}/".format(sysroot)],
"processCreateCommands": ["gdb-remote {}".format(format_hostport(host, port))] "processCreateCommands": ["gdb-remote {}".format(str(port))]
} }
return json.dumps(res, indent=4) return json.dumps(res, indent=4)
def generate_lldb_script(root, sysroot, binary_name, host, port, solib_search_path): def generate_lldb_script(root, sysroot, binary_name, port, solib_search_path):
commands = [] commands = []
commands.append( commands.append(
'settings append target.exec-search-paths {}'.format(' '.join(solib_search_path))) 'settings append target.exec-search-paths {}'.format(' '.join(solib_search_path)))
@@ -277,11 +272,11 @@ def generate_lldb_script(root, sysroot, binary_name, host, port, solib_search_pa
commands.append("settings append target.source-map '/b/f/w' '{}'".format(root)) commands.append("settings append target.source-map '/b/f/w' '{}'".format(root))
commands.append("settings append target.source-map '' '{}'".format(root)) commands.append("settings append target.source-map '' '{}'".format(root))
commands.append('target modules search-paths add / {}/'.format(sysroot)) commands.append('target modules search-paths add / {}/'.format(sysroot))
commands.append('gdb-remote {}'.format(format_hostport(host, port))) commands.append('gdb-remote {}'.format(str(port)))
return '\n'.join(commands) return '\n'.join(commands)
def generate_setup_script(debugger_path, sysroot, linker_search_dir, binary_file, is64bit, host, port, debugger, connect_timeout=5): def generate_setup_script(debugger_path, sysroot, linker_search_dir, binary_file, is64bit, port, debugger, connect_timeout=5):
# Generate a setup script. # Generate a setup script.
root = os.environ["ANDROID_BUILD_TOP"] root = os.environ["ANDROID_BUILD_TOP"]
symbols_dir = os.path.join(sysroot, "system", "lib64" if is64bit else "lib") symbols_dir = os.path.join(sysroot, "system", "lib64" if is64bit else "lib")
@@ -297,10 +292,10 @@ def generate_setup_script(debugger_path, sysroot, linker_search_dir, binary_file
if debugger == "vscode-lldb": if debugger == "vscode-lldb":
return generate_vscode_lldb_script( return generate_vscode_lldb_script(
root, sysroot, binary_file.name, host, port, solib_search_path) root, sysroot, binary_file.name, port, solib_search_path)
elif debugger == 'lldb': elif debugger == 'lldb':
return generate_lldb_script( return generate_lldb_script(
root, sysroot, binary_file.name, host, port, solib_search_path) root, sysroot, binary_file.name, port, solib_search_path)
else: else:
raise Exception("Unknown debugger type " + debugger) raise Exception("Unknown debugger type " + debugger)
@@ -319,11 +314,6 @@ def do_main():
if device is None: if device is None:
sys.exit("ERROR: Failed to find device.") sys.exit("ERROR: Failed to find device.")
if ":" in device.serial:
host = device.serial.split(":")[0]
else:
host = None
root = os.environ["ANDROID_BUILD_TOP"] root = os.environ["ANDROID_BUILD_TOP"]
sysroot = os.path.join(os.environ["ANDROID_PRODUCT_OUT"], "symbols") sysroot = os.path.join(os.environ["ANDROID_PRODUCT_OUT"], "symbols")
@@ -389,7 +379,6 @@ def do_main():
linker_search_dir=linker_search_dir, linker_search_dir=linker_search_dir,
binary_file=binary_file, binary_file=binary_file,
is64bit=is64bit, is64bit=is64bit,
host=host,
port=args.port, port=args.port,
debugger=debugger) debugger=debugger)