From fbfa4f398a41ef7c0c91b14a5e972bc7388c44ec Mon Sep 17 00:00:00 2001 From: Jayant Chowdhary Date: Wed, 24 Jan 2018 10:35:55 -0800 Subject: [PATCH] Additional fix for coversion from type-id to type-string. Bug: 71486971 Test: header-abi-diff -arch arm64 -lib libcpp \ -old tests/reference_dumps/arm64/libgolden_cpp.so.lsdump \ -new tests/reference_dumps/arm64/libgolden_cpp_change_member_access.so.lsdump \ -o libcpp_diff; libcpp_diff shows type strings for diffed fields. Change-Id: If27a9d6d2fe9b6793a0f2da7f87247ee334ffd84 --- .../header-checker/header-abi-util/src/abi_diff_helpers.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vndk/tools/header-checker/header-abi-util/src/abi_diff_helpers.cpp b/vndk/tools/header-checker/header-abi-util/src/abi_diff_helpers.cpp index f0eec42f5..bf1133e6c 100644 --- a/vndk/tools/header-checker/header-abi-util/src/abi_diff_helpers.cpp +++ b/vndk/tools/header-checker/header-abi-util/src/abi_diff_helpers.cpp @@ -438,7 +438,7 @@ AbiDiffHelper::FixupDiffedFieldTypeIds( for (auto &field_diff : field_diffs) { diffed_fields_dup.emplace_back(*(field_diff.old_field_), *(field_diff.new_field_)); - auto it = diffed_fields_dup[diffed_fields_dup.size() - 1]; + auto &it = diffed_fields_dup[diffed_fields_dup.size() - 1]; abi_util::RecordFieldIR &old_field = it.first; abi_util::RecordFieldIR &new_field = it.second; old_field.SetReferencedType(