From 7e0fbcbc135838792fa72b23d46e03b8c90e80e2 Mon Sep 17 00:00:00 2001 From: Shashwat Date: Wed, 22 Sep 2021 10:18:15 +0000 Subject: [PATCH] Add analytics for timeline navigation Test: Please see Google analytics and see event updates as you change timeline navigation on winscope. Bug: 200518515 Change-Id: I42152025d8cc2ef0b596d65fce177732eb6f9a98 --- tools/winscope/src/DataView.vue | 1 - tools/winscope/src/Overlay.vue | 2 +- tools/winscope/src/main.js | 7 +++++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/winscope/src/DataView.vue b/tools/winscope/src/DataView.vue index 52508245c..a353e039d 100644 --- a/tools/winscope/src/DataView.vue +++ b/tools/winscope/src/DataView.vue @@ -160,7 +160,6 @@ export default { // Pass click event to parent, so that click event handler can be attached // to component. this.$emit('click', e); - this.newEventOccurred(e.toString()); }, /** Filter data view files by current show settings */ updateShowFileTypes() { diff --git a/tools/winscope/src/Overlay.vue b/tools/winscope/src/Overlay.vue index a75f4ec3b..829cff4df 100644 --- a/tools/winscope/src/Overlay.vue +++ b/tools/winscope/src/Overlay.vue @@ -686,7 +686,7 @@ export default { navigationStyleFilter = (f) => f.type === fileType; } - + this.changedNavigationStyle(this.navigationStyle); this.$store.commit('setNavigationFilesFilter', navigationStyleFilter); }, updateVideoOverlayWidth(width) { diff --git a/tools/winscope/src/main.js b/tools/winscope/src/main.js index 703cced9c..10dd44354 100644 --- a/tools/winscope/src/main.js +++ b/tools/winscope/src/main.js @@ -411,6 +411,13 @@ Vue.mixin({ 'value': field, }); }, + changedNavigationStyle(field) { + this.$gtag.event("Timeline navigation changed", { + 'event_category': "Timeline Navigation", + 'event_label': "Winscope Interactions", + 'value': field, + }); + }, } });