LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip JavaDoc checks for Java tests classes

Browse Source 
Bug: 26862656
Change-Id: I708ee552154796ece6655db8f9f3157a2e9f3ba5
This commit is contained in:
Aurimas Liutikas
2016-01-29 13:07:22 -08:00
parent 4e89da7764
commit 99451e5b13
2 changed files with 42 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tools/checkstyle/tests.py
View File

@@ -77,14 +77,35 @@ class TestCheckstyle(unittest.TestCase):
checkstyle.git.last_commit = mock_last_commit
def test_ShouldSkip(self):
self.assertFalse(checkstyle._ShouldSkip(None, 1, TEST_RULE))
self.assertTrue(checkstyle._ShouldSkip([], 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip([1], 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip([1, 2, 3], 1, TEST_RULE))
self.assertTrue(checkstyle._ShouldSkip([1, 2, 3], 4, TEST_RULE))
# Skip checks for explicit git commit.
self.assertFalse(checkstyle._ShouldSkip(True, None, 1, TEST_RULE))
self.assertTrue(checkstyle._ShouldSkip(True, [], 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip(True, [1], 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip(True, [1, 2, 3], 1, TEST_RULE))
self.assertTrue(checkstyle._ShouldSkip(True, [1, 2, 3], 4, TEST_RULE))
for rule in checkstyle.FORCED_RULES:
self.assertFalse(checkstyle._ShouldSkip([1, 2, 3], 1, rule))
self.assertFalse(checkstyle._ShouldSkip([1, 2, 3], 4, rule))
self.assertFalse(checkstyle._ShouldSkip(True, [1, 2, 3], 1, rule))
self.assertFalse(checkstyle._ShouldSkip(True, [1, 2, 3], 4, rule))
# Skip checks for explicitly checked files.
self.assertFalse(checkstyle._ShouldSkip(False, None, 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip(False, [], 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip(False, [1], 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip(False, [1, 2, 3], 1, TEST_RULE))
self.assertFalse(checkstyle._ShouldSkip(False, [1, 2, 3], 4, TEST_RULE))
for rule in checkstyle.FORCED_RULES:
self.assertFalse(checkstyle._ShouldSkip(False, [1, 2, 3], 1, rule))
self.assertFalse(checkstyle._ShouldSkip(False, [1, 2, 3], 4, rule))
# Skip checks for test classes.
self.assertFalse(checkstyle._ShouldSkip(True, None, 1, TEST_RULE, True))
self.assertTrue(checkstyle._ShouldSkip(True, [], 1, TEST_RULE, True))
self.assertFalse(checkstyle._ShouldSkip(True, [1], 1, TEST_RULE, True))
self.assertFalse(checkstyle._ShouldSkip(True, [1, 2, 3], 1, TEST_RULE, True))
self.assertTrue(checkstyle._ShouldSkip(True, [1, 2, 3], 4, TEST_RULE, True))
for rule in checkstyle.SKIPPED_RULES_FOR_TEST_FILES:
self.assertTrue(checkstyle._ShouldSkip(True, [1, 2, 3], 1, rule, True))
self.assertTrue(checkstyle._ShouldSkip(True, [1, 2, 3], 4, rule, True))
def test_GetModifiedFiles(self):
checkstyle.git.modified_files = mock_modified_files_good