LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add missing changes from ARCH removal.

Browse Source 
I somehow didn't upload these fixes from the review. So doing that
now.

Test: Unit tests pass.
Change-Id: Ia17e480eb972db4f7be6947c0e6567632c65431f
This commit is contained in:
Christopher Ferris
2023-03-13 14:50:48 -07:00
parent 462b91aae1
commit a47d6d090f
3 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/stack
View File

@@ -44,10 +44,7 @@ def main():
args = parser.parse_args() args = parser.parse_args()
if args.arch: if args.arch:
if args.arch == "arm" or args.arch == "x86": symbol.ARCH_IS_32BIT = not "64" in args.arch
symbol.ARCH_IS_32BIT = True
else:
symbol.ARCH_IS_32BIT = False
if args.symbols_dir: if args.symbols_dir:
symbol.SYMBOLS_DIR = args.symbols_dir symbol.SYMBOLS_DIR = args.symbols_dir
if args.symbols_zip: if args.symbols_zip:

4
scripts/stack_core.py
View File

@@ -584,10 +584,6 @@ class RegisterPatternTests(unittest.TestCase):
lines = example_crash.split('\n') lines = example_crash.split('\n')
symbol.SetBitness(lines) symbol.SetBitness(lines)
tc.UpdateBitnessRegexes() tc.UpdateBitnessRegexes()
if symbol.ARCH_IS_32BIT:
print("32 Bit Arch")
else:
print("64 Bit Arch")
for line in lines: for line in lines:
tc.ProcessLine(line) tc.ProcessLine(line)
is_register = (re.search(stupid_pattern, line) is not None) is_register = (re.search(stupid_pattern, line) is not None)

2
scripts/symbol.py
View File

@@ -580,7 +580,7 @@ class FormatSymbolWithoutParametersTests(unittest.TestCase):
def test_nested(self): def test_nested(self):
self.assertEqual(FormatSymbolWithoutParameters("foo(int i)::bar(int j)"), "foo::bar") self.assertEqual(FormatSymbolWithoutParameters("foo(int i)::bar(int j)"), "foo::bar")
def test_unballanced(self): def test_unbalanced(self):
self.assertEqual(FormatSymbolWithoutParameters("foo(bar(int i)"), "foo(bar(int i)") self.assertEqual(FormatSymbolWithoutParameters("foo(bar(int i)"), "foo(bar(int i)")
self.assertEqual(FormatSymbolWithoutParameters("foo)bar(int i)"), "foo)bar(int i)") self.assertEqual(FormatSymbolWithoutParameters("foo)bar(int i)"), "foo)bar(int i)")
self.assertEqual(FormatSymbolWithoutParameters("foo<bar(int i)"), "foo<bar(int i)") self.assertEqual(FormatSymbolWithoutParameters("foo<bar(int i)"), "foo<bar(int i)")