LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed valgrind handling issue.

Browse Source 
Turns out valgrind always exits with error code 0 even when a leak is
detected. Instead we are now looking for an empty output.
This commit is contained in:
Nicolas Catania
2009-06-04 09:42:03 -07:00
parent ab16d9f7d5
commit ab80b39f16
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
testrunner/run_command.py
View File

@@ -146,10 +146,16 @@ def RunHostCommand(binary, valgrind=False):
return subproc.returncode return subproc.returncode
else: else:
# Need the full path to valgrind to avoid other versions on the system. # Need the full path to valgrind to avoid other versions on the system.
subproc = subprocess.Popen(["/usr/bin/valgrind", "-q", full_path], subproc = subprocess.Popen(["/usr/bin/valgrind", "--tool=memcheck",
"--leak-check=yes", "-q", full_path],
stdout=subprocess.PIPE, stderr=subprocess.STDOUT) stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
subproc.wait() # Cannot rely on the retcode of valgrind. Instead look for an empty output.
return subproc.returncode valgrind_out = subproc.communicate()[0].strip()
if valgrind_out:
print valgrind_out
return 1
else:
return 0
def HasValgrind(): def HasValgrind():