From ab8605370476effda49404ca6f65ecc1bc3dfa7b Mon Sep 17 00:00:00 2001
From: Aurimas Liutikas <aurimas@google.com>
Date: Mon, 8 Feb 2016 12:57:52 -0800
Subject: [PATCH] Add new rules to Checkstyle config.

Add the following new checks:
- JavadocMethod
- MissingDeprecated
- MissingOverride
- OneTopLevelClass
- StringLiteralEquality
- ArrayTypeStyle
- RedundantModifier
- NewlineAtEndOfFile

Bug: 27051781
Change-Id: I4d34278f73ee821cd6cfea705cf949881eaebfc2
---
 tools/checkstyle/android-style.xml | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/tools/checkstyle/android-style.xml b/tools/checkstyle/android-style.xml
index 7e4ea52d3..2d11bf5ed 100644
--- a/tools/checkstyle/android-style.xml
+++ b/tools/checkstyle/android-style.xml
@@ -32,8 +32,9 @@
       <message key="javadoc.missing" value="Public classes and interfaces require JavaDoc comments."/>
     </module>
     <module name="JavadocMethod">
-      <property name="severity" value="info"/>
+      <property name="severity" value="error"/>
       <property name="scope" value="public"/>
+      <property name="tokens" value="METHOD_DEF"/>
       <property name="allowMissingParamTags" value="true"/>
       <property name="allowMissingPropertyJavadoc" value="true"/>
       <property name="allowMissingReturnTag" value="true"/>
@@ -197,11 +198,32 @@
       <property name="tokens" value="COMMA"/>
       <property name="option" value="EOL"/>
     </module>
+    <module name="MissingDeprecated">
+      <property name="severity" value="error"/>
+    </module>
+    <module name="MissingOverride">
+      <property name="severity" value="error"/>
+    </module>
+    <module name="OneTopLevelClass">
+      <property name="severity" value="error"/>
+    </module>
+    <module name="StringLiteralEquality">
+      <property name="severity" value="error"/>
+    </module>
+    <module name="ArrayTypeStyle">
+      <property name="severity" value="error"/>
+    </module>
+    <module name="RedundantModifier">
+      <property name="severity" value="error"/>
+    </module>
     <module name="FileContentsHolder"/>
   </module>
   <module name="FileTabCharacter">
     <property name="severity" value="error"/>
   </module>
+  <module name="NewlineAtEndOfFile">
+    <property name="severity" value="error"/>
+  </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error"/>
     <property name="format" value="[ \t]+$"/>