From 55ef33f3b1513ab271ec409c1d34e6f2a7430e8a Mon Sep 17 00:00:00 2001 From: Aleksei Vetrov Date: Fri, 24 Nov 2023 19:42:17 +0000 Subject: [PATCH] ndk: Set TARGET_RELEASE in NDK ABI dump script TARGET_RELEASE variable is required to have correct platform variables set up before NDK build. There are different possible values for this variable: * "next" - the platform will be built like current development version is now a release version. For ABI monitoring this means that previously codenamed version like "UpsideDownCake" is now a numbered version like "34". * "trunk_staging" - in-development version with some features being staged for subsequent releses. The main goal of NDK ABI monitoring is to catch ABI breakages as soon as possible, which means that "trunk_staging" is the best candidate for dumping and diffing NDK ABI. Test: development/tools/ndk/update_ndk_abi.sh Bug: 156513478 Change-Id: Ie07c865e6415084a0268a566842d0b46971c7a2d --- tools/ndk/ndkabidump/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/ndk/ndkabidump/__init__.py b/tools/ndk/ndkabidump/__init__.py index 4b863c242..8a00256ee 100644 --- a/tools/ndk/ndkabidump/__init__.py +++ b/tools/ndk/ndkabidump/__init__.py @@ -43,6 +43,7 @@ class Updater: ["dump-ndk-abi"], env={ "TARGET_PRODUCT": "ndk", + "TARGET_RELEASE": "trunk_staging", # TODO: remove ALLOW_MISSING_DEPENDENCIES=true when all the # riscv64 dependencies exist (currently blocked by # http://b/273792258).