From ad140286f3420fb90b31e9a5f2118db1dd6f150c Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Thu, 21 May 2020 14:09:24 -0700 Subject: [PATCH] Don't use `unzip -t` when `unzip -l` will do. It's a *lot* more expensive, and ziptool doesn't support it. I can easily add the functionality, but since our only user seems to be a mistake, that wouldn't be my first choice! Test: treehugger Change-Id: Iab1a326e4cec3520942adaf9f3c9bb424adf4c35 --- build/tools/mk_sdk_repo_xml.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/tools/mk_sdk_repo_xml.sh b/build/tools/mk_sdk_repo_xml.sh index 97f8abab9..b0f480ce8 100755 --- a/build/tools/mk_sdk_repo_xml.sh +++ b/build/tools/mk_sdk_repo_xml.sh @@ -383,13 +383,13 @@ while [[ -n "$1" ]]; do if [[ $FIRST ]]; then FIRST="" - if unzip -t "$SRC" | grep -qs "source.properties" ; then + if unzip -l "$SRC" | grep -qs "source.properties" ; then # Extract Source Properties # unzip: -j=flat (no dirs), -q=quiet, -o=overwrite, -d=dest dir unzip -j -q -o -d "$TMP_DIR" "$SRC" "*/source.properties" PROPS="$TMP_DIR/source.properties" - elif unzip -t "$SRC" | grep -qs "manifest.ini" ; then + elif unzip -l "$SRC" | grep -qs "manifest.ini" ; then unzip -j -q -o -d "$TMP_DIR" "$SRC" "*/manifest.ini" PROPS="$TMP_DIR/manifest.ini"