From c448acb573fd6d62dacfd8b7cfc1c9df36791391 Mon Sep 17 00:00:00 2001 From: Antonio Kantek Date: Wed, 10 Jun 2020 10:07:45 -0700 Subject: [PATCH] Disabling popped preview key since it is currently broken. Test script: Step 1: Patch this CL, ag/11800786 and ag/11802630 on rvc-dev repo Step 2: Build and flash Hawk Step 3: Build and install a sample multi-client IME make -j MultiClientInputMethod adb install -r $OUT/system/priv-app/MultiClientInputMethod/MultiClientInputMethod.apk Step 4: Enable multi-client IME for the side-loaded sample multi-client IME adb root adb shell setprop persist.debug.multi_client_ime com.example.android.multiclientinputmethod/.MultiClientInputMethod adb reboot Step 5: Open KitchenSync app, select carboard, enter text on Plain Text tab (sample multi-session keyboard doesn't support numeric keyboard yet) Bug: 158663354 Test: manual (see test script above) Change-Id: I11cf467acb1091b1d417e5039519e09fa7be2bf8 --- .../android/multiclientinputmethod/SoftInputWindow.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/samples/MultiClientInputMethod/src/com/example/android/multiclientinputmethod/SoftInputWindow.java b/samples/MultiClientInputMethod/src/com/example/android/multiclientinputmethod/SoftInputWindow.java index afc66a413..93e60a7a9 100644 --- a/samples/MultiClientInputMethod/src/com/example/android/multiclientinputmethod/SoftInputWindow.java +++ b/samples/MultiClientInputMethod/src/com/example/android/multiclientinputmethod/SoftInputWindow.java @@ -78,6 +78,10 @@ final class SoftInputWindow extends Dialog { mSymbolShiftKeyboard = new Keyboard(context, R.xml.symbols_shift); mKeyboardView.setKeyboard(mQwertygKeyboard); mKeyboardView.setOnKeyboardActionListener(sNoopListener); + + // TODO(b/158663354): Disabling keyboard popped preview key since it is currently broken. + mKeyboardView.setPreviewEnabled(false); + layout.addView(mKeyboardView); setContentView(layout, new ViewGroup.LayoutParams(