From 4c71de20a83b99d5e632b668b10bfb475634f1d2 Mon Sep 17 00:00:00 2001 From: Vishnu Nair Date: Fri, 19 Apr 2019 10:18:08 -0700 Subject: [PATCH] WinScope: Support missing layers The new sf layer transform changes breaks when missing layers are added since they do not contain transform data. Fix this is by adding a transform when creating missing layers. Also set the transform type when populating transform matrices so they are displayed as IDENTITY. Test: Open trace from bug Fixes: 130886882 Change-Id: I85f52bd3dc9174499c4a4840c6b5e80555f28fc7 --- tools/winscope/src/matrix_utils.js | 1 + tools/winscope/src/transform_sf.js | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/winscope/src/matrix_utils.js b/tools/winscope/src/matrix_utils.js index 057ffce22..6d7d44fdb 100644 --- a/tools/winscope/src/matrix_utils.js +++ b/tools/winscope/src/matrix_utils.js @@ -135,6 +135,7 @@ function fill_transform_data(transform) { transform.dtdx = 0.0; transform.dsdy = 0.0; transform.dtdy = 1.0; + transform.type = 0; return; } diff --git a/tools/winscope/src/transform_sf.js b/tools/winscope/src/transform_sf.js index 99489e352..809c54ffa 100644 --- a/tools/winscope/src/transform_sf.js +++ b/tools/winscope/src/transform_sf.js @@ -198,6 +198,7 @@ function missingLayer(childId) { name: "layer #" + childId, missing: true, zOrderRelativeOf: -1, + transform: {dsdx:1, dtdx:0, dsdy:0, dtdy:1}, } }