From d39c93143f952eabcd48f3a1bd3ffdba0a4adb10 Mon Sep 17 00:00:00 2001 From: Jayant Chowdhary Date: Thu, 30 Nov 2017 12:05:25 -0800 Subject: [PATCH] Fix exclusion of builtin types in linked dump. Builtin types do not need an 'IsPresentInExportedHeaders' check while linking. Bug: 63865902 Test: mm -j64 in external/libjpeg-turbo, resulting linked abi dump has builtin types (when used with built version on header-abi-linker) Change-Id: I7816c6522b8a4873ebcdf6c325a6e224eab48de7 --- .../header-abi-util/src/ir_representation_protobuf.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/vndk/tools/header-checker/header-abi-util/src/ir_representation_protobuf.cpp b/vndk/tools/header-checker/header-abi-util/src/ir_representation_protobuf.cpp index 3b3e9c91e..fbd1ceb17 100644 --- a/vndk/tools/header-checker/header-abi-util/src/ir_representation_protobuf.cpp +++ b/vndk/tools/header-checker/header-abi-util/src/ir_representation_protobuf.cpp @@ -218,9 +218,6 @@ void ProtobufTextFormatToIRReader::ReadBuiltinTypes( ReadTypeInfo(builtin_type_protobuf.type_info(), &builtin_type_ir); builtin_type_ir.SetSignedness(builtin_type_protobuf.is_unsigned()); builtin_type_ir.SetIntegralType(builtin_type_protobuf.is_integral()); - if (!IsPresentInExportedHeaders(builtin_type_ir, exported_headers_)) { - continue; - } builtin_types_.insert( {builtin_type_ir.GetLinkerSetKey(), std::move(builtin_type_ir)}); }