LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge change 1958 into donut

Browse Source 
* changes:
  Force --no-undefined at link time to generate an error when trying to generate a shared library that references undefined symbols. This can be overriden by defining LOCAL_ALLOW_UNDEFINED_SYMBOLS in your Android.mk to 'true'
This commit is contained in:
Android (Google) Code Review
2009-05-19 12:00:42 -07:00
parent 5faae6da0b 3caffcfaf8
commit e0b505d438
4 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ndk/build/core/build-binary.mk
View File

@@ -54,6 +54,14 @@ else
endif endif
endif endif
#
# If LOCAL_ALLOW_UNDEFINED_SYMBOLS, the linker will allow the generation
# of a binary that uses undefined symbols.
#
ifeq ($(strip $(LOCAL_ALLOW_UNDEFINED_SYMBOLS)),)
LOCAL_LDFLAGS := $(LOCAL_LDFLAGS) $($(my)NO_UNDEFINED_LDFLAGS)
endif
# #
# The original Android build system allows you to use the .arm prefix # The original Android build system allows you to use the .arm prefix
# to a source file name to indicate that it should be defined in either # to a source file name to indicate that it should be defined in either

1
ndk/build/core/clear-vars.mk
View File

@@ -27,6 +27,7 @@ NDK_LOCAL_VARS := \
LOCAL_STATIC_WHOLE_LIBRARIES \ LOCAL_STATIC_WHOLE_LIBRARIES \
LOCAL_SHARED_LIBRARIES \ LOCAL_SHARED_LIBRARIES \
LOCAL_MAKEFILE \ LOCAL_MAKEFILE \
LOCAL_NO_UNDEFINED_SYMBOLS \
$(call clear-vars, $(NDK_LOCAL_VARS)) $(call clear-vars, $(NDK_LOCAL_VARS))

4
ndk/build/toolchains/arm-eabi-4.2.1/setup.mk
View File

@@ -76,6 +76,10 @@ TARGET_ARFLAGS := crs
TARGET_LIBGCC := $(shell $(TARGET_CC) -mthumb-interwork -print-libgcc-file-name) TARGET_LIBGCC := $(shell $(TARGET_CC) -mthumb-interwork -print-libgcc-file-name)
TARGET_LDLIBS := -Wl,-rpath-link=$(SYSROOT)/usr/lib $(TARGET_LIBGCC) TARGET_LDLIBS := -Wl,-rpath-link=$(SYSROOT)/usr/lib $(TARGET_LIBGCC)
# These flags are used to ensure that a binary doesn't reference undefined
# flags.
TARGET_NO_UNDEFINED_LDFLAGS := -Wl,--no-undefined
# The ABI-specific sub-directory that the SDK tools recognize for # The ABI-specific sub-directory that the SDK tools recognize for
# this toolchain's generated binaries # this toolchain's generated binaries
TARGET_ABI_SUBDIR := armeabi TARGET_ABI_SUBDIR := armeabi

9
ndk/docs/ANDROID-MK.TXT
View File

@@ -352,3 +352,12 @@ LOCAL_SHARED_LIBRARIES
Note that this does not append the listed modules to the build graph, Note that this does not append the listed modules to the build graph,
i.e. you should still add them to your application's required modules i.e. you should still add them to your application's required modules
in your Application.mk in your Application.mk
LOCAL_ALLOW_UNDEFINED_SYMBOLS
By default, any undefined reference encountered when trying to build
a shared library will result in an "undefined symbol" error. This is a
great help to catch bugs in your source code.
However, if for some reason you need to disable this check, set this
variable to 'true'. Note that the corresponding shared library may fail
to load at runtime.