LineageOS/android_development
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only add files in GlobSymbolsDir.

Browse Source 
I previously skipped directories, but that can still lead to problems.
So instead, only add paths that are files.

Test: Ran over a stack that failed when trying to run llvm-readelf
Test: on a directory. After this fix, everything get line numbers.
Change-Id: Ide39c5a118d78a822057cc3977d0f532595f798b
This commit is contained in:
Christopher Ferris
2022-11-08 17:47:37 -08:00
parent d946117723
commit e6e02b0e22
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/stack_core.py
View File

@@ -319,8 +319,7 @@ class TraceConverter:
def GlobSymbolsDir(self, symbols_dir): def GlobSymbolsDir(self, symbols_dir):
files_by_basename = {} files_by_basename = {}
for path in sorted(pathlib.Path(symbols_dir).glob("**/*")): for path in sorted(pathlib.Path(symbols_dir).glob("**/*")):
if os.path.isdir(path): if os.path.isfile(path):
next
files_by_basename.setdefault(path.name, []).append(path) files_by_basename.setdefault(path.name, []).append(path)
return files_by_basename return files_by_basename