Commit Graph

3641 Commits

Author SHA1 Message Date
Pablo Gamito
13316bdbfe Add backwards compatibility for traces without bounds field
Test: Use old traces and new traces to make sure everything still works
Change-Id: Iaf74c75c4df6bc5d5e01a26f46e8fa0d4ea5e109
2020-06-16 17:31:58 +01:00
Pablo Gamito
30741659ca Prevent text highlighting of nodesfrom interfering with collapse toggling
Test: Manual
Change-Id: I70d9f364ba245490fbfd64bf5c6ec08cf6c977a1
2020-06-16 17:18:19 +01:00
Pablo Gamito
d12ce0b473 Add tooltip description to pin button
Test: N/A
Change-Id: I2a6a95dfa3c0e49b13b245d4f1f69f40c0a97e53
2020-06-16 16:39:40 +01:00
Pablo Gamito
2e6c00f37a Merge changes Ifce81aaa,I4fa80566
* changes:
  Position video overlay only when video is ready
  Reposition draggable div on parent resize
2020-06-16 13:23:14 +00:00
Pablo Gamito
94b816ea5c Position video overlay only when video is ready
Get rid of the hacky wait x seconds to see if dragabbleDiv's content changes in size to recalculate div's initial position. Instead only show draggableDiv and calculate initial position when video has been rendered (is ready to play).

Test: Manually
Change-Id: Ifce81aaa5a0a26475dee70e4b9ad4afdd004e116
2020-06-16 11:37:28 +01:00
Pablo Gamito
2c5c846c13 Reposition draggable div on parent resize
Test: Manually
Fixes: 158638640
Change-Id: I4fa805664a48da14e52ecd13aa383d0a6fa87de9
2020-06-16 11:35:00 +01:00
Pablo Gamito
58fc6cc504 Keep track of TreeView collapsed states accross time
Test: Manually
Change-Id: I681c436f6789979fefc7b4ac4fb9fa148c4cb0a5
2020-06-16 10:01:01 +01:00
Pablo Gamito
312498387c Add stableIds to WindowManager proto transformations
Test: N/A
Change-Id: Iea6f84e3e89c2350673aae2ab076bb6d543b45c9
2020-06-16 10:01:00 +01:00
Pablo Gamito
1fcea5ce61 Merge "Don't show TreeView element when empty" 2020-06-12 11:30:58 +00:00
Pablo Gamito
e6373d8864 Update all timelines' selected index to new timestamp on arrow advance
Fixes: 158791563
Test: Manual
Change-Id: I74e06f948c80be16968f2867e7807d96702d6306
2020-06-12 10:45:59 +01:00
Pablo Gamito
293a43fd76 Merge "Add icon to TeeView leaf nodes for clarity" 2020-06-11 17:22:09 +00:00
Pablo Gamito
4ffa6b8a7d Don't show TreeView element when empty
Prevents there from being an empty TreeView node which is visible when hovered over

Test: Manual
Change-Id: I9a9f6538075731b4cf92d64d18ca47da818c0cd5
2020-06-10 10:30:36 +01:00
Pablo Gamito
c081577406 Always execute first TreeView node click
Makes clicking items more responsive. Stops waiting to detect second click and instead always execute the action of the first click no matter what.

Test: Manual
Fixes: 158604325
Change-Id: Ib98d8ed1acdc4ab18577bc2c01febb17009f53de
2020-06-10 10:14:04 +01:00
Pablo Gamito
cf360a0dff Add icon to TeeView leaf nodes for clarity
Adding the icon tabs out leaf nodes to make it clear they are children of the parent and makes it clear that a multiline item is a single item

Test: N/A
Fixes: 158606224
Change-Id: I12cdf1978d322064b37cfa963c5bddbb7bdcacfe
2020-06-10 09:42:03 +01:00
Pablo Gamito
6c71e1fbcf Add new badge to new log entries
Test: Manual
Change-Id: I0425b15fcb8a88da29c27535bc38c894210a4d54
2020-06-08 17:00:49 +01:00
Pablo Gamito
677dbec117 Add options to pin and jump to latest log message
Test: Enable pin (clicking on pin icon) and move around in timeline – the last visible log message should always be the latest one. Disable pin and move around in the timline – the protolog should not change which messages are visible. Scroll in protolog and then click on jump to latest button – latest log message should be visible.
Change-Id: Ie9c0e5dd04356e2702097bbfd8c164243512da5f
2020-06-08 17:00:49 +01:00
Pablo Gamito
84bd8adce2 Add filtering and search functionality to logs
Test: Manually test the filters
Change-Id: I0f2b818f56fe2d737981e52a1a4934ee4945df29
2020-06-08 17:00:49 +01:00
Pablo Gamito
396ab56059 Implement global state for files with Vuex
With increasing interaction between components it makes sense to have a global state so any component can update and read the global state instead of passing updates up and down the Vue component tree. In particular this is useful so that the current timeline time can be updated from anywhere easily with the changes reflected in all components.

Test: N/A
Change-Id: Ie099973b8a36915c7e93e4d716b0f92e82ab28b4
2020-06-08 17:00:49 +01:00
Pablo Gamito
f2f36d3f95 Show all logs and scroll on timeline change
Always show all log message (those that havn't occured yet are grayed out). Automatically scroll to latest log message when moving in the timeline.

Test: Move around in the timeline and check if the latest log message it pinned to the bottom and log messages past this point are grayed out.
Change-Id: I0fa67c5934f4472ef2f827093e2d6c09582f07c0
2020-06-08 17:00:48 +01:00
Pablo Gamito
e9d17ec50d Remove ProtoLog from timeline
Test: N/A
Change-Id: I537765b3715bbe343117082d9100bc2d579e16fc
2020-06-08 17:00:48 +01:00
Pablo Gamito
14bde7217d Merge "Fix DataView focus not updating bug" 2020-06-08 12:06:08 +00:00
Pablo Gamito
479d7339ae Merge "Don't show video overlay when no video is present" 2020-06-08 08:07:54 +00:00
Pablo Gamito
f2c4aec62f Merge "Implement collapsible TreeView" 2020-06-05 15:54:16 +00:00
Pablo Gamito
b09b33ba2f Don't show video overlay when no video is present
Test: Manual
Change-Id: Ib88cd8a6d8d0d89b32e20dd7e151166287628d53
2020-06-05 15:50:57 +01:00
Pablo Gamito
d886d45e41 Fix DataView focus not updating bug
Test: Manually
Bug: 156885920
Change-Id: Icbadaa1addbffd843b324a10aef2112bf2440e45
2020-06-05 15:24:47 +01:00
Pablo Gamito
231e2c378a Implement collapsible TreeView
Test: Manually by trying to collapse trees
Change-Id: I2fecf357165357e03b347bb89631d9daac46c321
2020-06-05 15:24:45 +01:00
Pablo Gamito
06c222a746 Upgrade babel to be able to use new JS features
Test: N/A
Change-Id: Ie36c4e316695ca2f7aa0da0ac6b6a13e7ce62892
2020-06-05 12:00:57 +01:00
Pablo Gamito
1e8a5395e4 Remove no longer required dataViewPosition calculation logic
Test: N/A
Change-Id: I86f851a17207b0c26cb3a46a39559bd6a607e1aa
2020-06-04 16:14:33 +01:00
Pablo Gamito
e6054550d4 Add option to toggle video overlay
Test: N/A
Change-Id: Ibe8871486c5ba2d5d66f60243f15b6a1828bd549
2020-06-04 16:14:32 +01:00
Pablo Gamito
b46238c902 Implement draggable and resizable video overlay
Test: N/A
Change-Id: Ie856bac3b7209a61feb36d3f200925d7a52bdc16
2020-06-04 16:14:32 +01:00
Pablo Gamito
545e155a66 Make expanded sticky timeline resizable
Test: N/A
Change-Id: Ic6b62b4e7597cb319a06cd123ddcdcb26535099f
2020-06-04 16:14:32 +01:00
Pablo Gamito
95d8421269 Fit video to expanded timeline height
Test: N/A
Change-Id: I05454916937374a08168ef3e2f09e3f4e7efeb72
2020-06-04 16:14:32 +01:00
Pablo Gamito
06f4d0c097 Add video to sticky timeline
Test: N/A
Change-Id: Ibbd5148bdbdf4de09573de502a3014e9921d36aa
2020-06-04 16:14:32 +01:00
Pablo Gamito
a5c1c9d9e1 Merge timelines together when timeline is collapsed
Test: N/A
Change-Id: I48b5bbd45265681e0c515fa0138de4c6711f79f7
2020-06-04 16:14:32 +01:00
Pablo Gamito
09e93ebc07 Implement sticky timeline
Test: N/A
Change-Id: If5dbaabc5df4a9ffe6e8c5253d03bd90da279ffb
2020-06-04 16:14:32 +01:00
Pablo Gamito
3d7e0907f9 Merge changes from topic "winscope-ui-tweak"
* changes:
  Added a Favicon for better tab identification
  Make the timeline size relative to the parent
  Cleanup the UI for better visibility
  Move the Video to the top next to the timeline
  Migrate to new MaterialVue
2020-06-04 08:17:43 +00:00
Vadim Caen
767165d789 Added a Favicon for better tab identification
Test: N/A
Change-Id: I329f1f733c8d8a5725eca12aecba1a381fa7aacd
2020-06-03 18:31:47 +01:00
Vadim Caen
ca93393da9 Make the timeline size relative to the parent
Test: Manually check that the visuals look good
Change-Id: I6e91a29d0540f34f289a5566fb5b437c1c6a6d55
2020-06-03 18:31:47 +01:00
Vadim Caen
97b57ace37 Cleanup the UI for better visibility
Test: Checked that everything looked correct visually
Change-Id: Id60e8a4f6d0e6c21bcae01ae90730e727c459f42
2020-06-03 18:31:46 +01:00
Vadim Caen
ef82f68439 Move the Video to the top next to the timeline
Test: Checked visually
Change-Id: Ib1b827503c0f1ce58592295a4408b385a801786c
2020-06-03 18:31:46 +01:00
Vadim Caen
f9ac9aefd2 Migrate to new MaterialVue
MaterialVue 0.8XX are considred old and the MaterialVue website now
points to version 1.X by default

Test: Manually
Change-Id: I771b43eaaa7c7c05f92ca9e863687eb379568b4e
2020-06-03 18:31:43 +01:00
Chris Li
e40dc93d67 Read DisplayContent's children from rootDisplayArea field
Because we have DisplayContent extend DisplayArea, it no longer
populates the field window_container, but that can be found in
root_display_area.window_container.

The tool will still support old client.

Bug: 156425461
Test: Able to open winscope window traces
Change-Id: I32ed38e8c1e9d77ec813230d5e1f86aecf8e14c5
2020-06-01 12:30:11 -07:00
Treehugger Robot
da9bae5391 Merge "Remove unused imports from Main.java" am: 8fe2c34a0d am: 04a8893896 am: a14542330f am: b25b240236 am: cea013851f
Change-Id: I90496526ad226357b7c3f54e9a08ccc29a608556
2020-05-25 07:14:52 +00:00
Treehugger Robot
a14542330f Merge "Remove unused imports from Main.java" am: 8fe2c34a0d am: 04a8893896
Change-Id: I898d5a6d24b0f73e18c8c95cf5b32c30ea0bcad9
2020-05-25 06:32:05 +00:00
Treehugger Robot
8fe2c34a0d Merge "Remove unused imports from Main.java" 2020-05-25 06:02:20 +00:00
Treehugger Robot
effab9085b Merge "repo-review: Add a 'submit' command line option" am: 758cd9929c am: db109eabff am: feabcc35f7 am: 7f133ca54a am: c3b66022f0
Change-Id: If3c42e0e093a6fcecd544e2578cb08571268c064
2020-05-21 10:00:53 +00:00
Treehugger Robot
feabcc35f7 Merge "repo-review: Add a 'submit' command line option" am: 758cd9929c am: db109eabff
Change-Id: If189c7657295ac46f00faa0a62cd85bcfe803e4a
2020-05-21 09:01:19 +00:00
Po-Chien Hsueh
4e83237bb5 repo-review: Add a 'submit' command line option
This CL enables repo_review.py to submit CL(s).

Test: repo-review.py -g [url] [query] --submit
Change-Id: I9ecdc2b97bb0250597d76ef2d39596f66182530f
2020-05-21 07:13:24 +00:00
TreeHugger Robot
d8cd4937c8 Merge "Ignore transform if not set" into rvc-dev am: aab157a4c8 am: 5ae2b2ed09 am: 1fc47c73c3 am: c16292ff18
Change-Id: Ica86248c9bcca32e6299bf8280ec2b4f79fc366f
2020-05-20 18:50:53 +00:00
TreeHugger Robot
70ba994ec1 Merge "Load wayland proto definitions if available otherwise load stubs" into rvc-dev am: 2e4598b0c9 am: 54c3f9033c am: a97edef6ee am: af338aad83
Change-Id: I410ac0747188a84cb7118e09bb84c79310b3dc57
2020-05-20 18:48:32 +00:00