Commit Graph

3641 Commits

Author SHA1 Message Date
Pablo Gamito
cc299fc6f3 Display computed occlusion information more prominently
Test: Visual
Change-Id: I14bd265c288f0f9e2c286a5c5463556d68139575
2020-08-31 13:43:50 +02:00
Pablo Gamito
159c99e0a3 Add context menu to nodes with option to collapse all other nodes
Test: Try right clicking a node in a treeview and see if you can collapse all other nodes
Change-Id: Idc3a78c41abc146589ffd12b649c89a136038fdd
2020-08-31 13:32:30 +02:00
Pablo Gamito
78a5815ecb Visualize selection on timelines before cropping
Test: Visual
Change-Id: Ida3a4b4acf1ce303c22fba5ff733a69f11452028
2020-08-31 11:22:59 +02:00
Pablo Gamito
97accb0a2d Sync crop selection value and visualization between timelines and timeline selection area
Test: Visual
Change-Id: Iaa7c467a3cf049767115f7d401d76dd03c9e9a39
2020-08-31 11:22:56 +02:00
Pablo Gamito
8d0dddef86 Add timline crop section selection directly onto timeline
Test: Visual
Change-Id: I633bea78f842deede364431d23518332c05f9f75
2020-08-31 11:20:37 +02:00
Pablo Gamito
6d7b961865 Improve timeline performance
This is done by making sure timeline arrays are frozen and combining multiple timeline points into large timeline blocks to have a maximum of 50 blocks to render per timeline which drastically speeds up the Vue patching and rendering stages

Test: Use the timeline and run a performance trace and see the action times cut down by a factor of 10
Change-Id: Ic24aad100ea8f9f0aa35e81a3cc31d91708a8697
2020-08-31 11:19:01 +02:00
Pablo Gamito
afadf519b7 Keep selection, drag, and resize cursors on hover exit
When creating, resizing, or dragging a selection we want to make sure the cursor stay the same whatever the element under the cursor is

Test: create a selection and make sure the cursor stays the same no matter where the cursor is on the screen
Change-Id: I418ef450915e7e87ba0728b1268ce6ff5348460b
2020-08-31 11:19:01 +02:00
Pablo Gamito
d8266be5db Sync with video when trimming timeline
Test: visual
Change-Id: Ibfe2a5d6ce5bbfbb900b22344723b43c4d268d43
2020-08-31 11:18:58 +02:00
Pablo Gamito
6fb58491a8 Add option to crop timeline
Test: Try the feature out in the UI
Change-Id: Ic814cc01bf1f14d899259901319db2bf4646b62e
2020-08-31 11:17:04 +02:00
Pablo Gamito
140b49289e Merge changes Iba66536f,I9c74aab0
* changes:
  Refactor to support multiple files per trace in Winscope
  Add support for multiple files per trace in ADB Proxy
2020-08-28 15:18:04 +00:00
Xin Li
e3b57410da Merge Android R (rvc-dev-plus-aosp-without-vendor@6692709)
Bug: 166295507
Merged-In: I37a77cdaf905fe0bf58ad8eebcdff36873aec71a
Change-Id: Idac9218a0e169df9d02d9d8d376a6816315a4b28
2020-08-27 10:16:04 -07:00
Pablo Gamito
f25221cb62 Refactor to support multiple files per trace in Winscope
This is required because when tracing transasction merges each process where the merge occurs is responsible for recording this and dumping this information. So in addition to the current transaction file, the transactions trace may contains many additional files.

Test: Try and run through all usecases of the app and make sure everything still works
Change-Id: Iba66536fb413a1875847ec673616da20e94d5feb
2020-08-27 16:19:06 +02:00
Pablo Gamito
1138a00053 Add support for multiple files per trace in ADB Proxy
Required because transaction traces now output multiple files

Test: Make sure we can still get the traces from winscope using the proxy
Change-Id: I9c74aab0c659f09f7c30bda6fba06a646d36c637
2020-08-27 16:18:48 +02:00
Pablo Gamito
72e6b05b1f Disable JSDoc lint requirement
Test: Run linter one files missing JSDocs
Change-Id: I4666b23c261af7e4fe7624ecba4ea779ba8813ba
2020-08-26 11:01:35 +02:00
Pablo Gamito
33e226f8db Add ESLint and pre-commit hooks to enforce Google style
Test: Attempt to commit files that don't comply with Google style
Change-Id: I1722c55836a0b068a15bb8d94c339849d6cf8972
2020-08-26 11:01:32 +02:00
Pablo Gamito
25d74e71bd Merge "Update webpack config to compile Kotlin flickerlib to JS" 2020-08-25 10:40:54 +00:00
Pablo Gamito
ae5e89cc9d Update the protolog's proto file location and package name
Test: Run winscope and make sure we can record a trace
Fixes: 165535205
Change-Id: Idc15e0aee4c0ec289435d4a980dbf9f0482b74c4
2020-08-24 11:45:40 +02:00
TreeHugger Robot
41c5d6566b Merge "Support remote devices in winscope proxy" 2020-08-20 15:16:41 +00:00
Nataniel Borges
51ac130106 Support remote devices in winscope proxy
Currently Winscope proxy doesn't support devices with a model name
containing '.' or ':'. These are necessary for remotely connected
devices, where the device model is in the format IP:PORT

Bug: 165535205
Test: connect to remote device and capture a trace through winscope
Change-Id: Iacc1dcb9fe4f6f07a2b7677b4b70ad8c332551c0
2020-08-20 10:59:16 +02:00
TreeHugger Robot
8b2f34f9e5 Merge "Ignore relative Z order if layer doesn't exist" 2020-08-19 15:39:37 +00:00
Pablo Gamito
e7399aace3 Merge "Prevent treeview node text from overflowing" 2020-08-18 11:23:37 +00:00
Pablo Gamito
a39accad0d Merge "Add clear option to resize PiP" 2020-08-18 11:22:08 +00:00
Pablo Gamito
5d8590f874 Merge "Change treeview leaf icon to be less visible" 2020-08-18 11:21:30 +00:00
Nataniel Borges
bb4eda2a04 Ignore relative Z order if layer doesn't exist
We don't clean up the relatives in the hierarchy when a layer is
removed, thus, the value may be inconsistent.

Bug: 162500053
Test: build winscope and open a trace with split screen
Change-Id: Idb41ba29c478eb75659f5b186dbc70be6ca47de9
2020-08-18 09:48:40 +02:00
Pablo Gamito
2eabe15e85 Merge "Make sure bottom navbar is present before referencing it" 2020-08-07 09:37:17 +00:00
Yo Chiang
be10ca6068 Merge "Strip gerrit url trailing slash" am: 38280c6b55 am: 87b0546e4b am: d632660bac am: 0c0e7dcfcb am: d3b09a443c
Original change: https://android-review.googlesource.com/c/platform/development/+/1393363

Change-Id: I9389ea4ca8efd122584436638dad0417c4c704bb
2020-08-07 07:16:19 +00:00
Yo Chiang
d632660bac Merge "Strip gerrit url trailing slash" am: 38280c6b55 am: 87b0546e4b
Original change: https://android-review.googlesource.com/c/platform/development/+/1393363

Change-Id: I23a5d2234f87a69dc0ee54d1710b155c05922fa1
2020-08-07 06:44:53 +00:00
Yo Chiang
36d90eeea2 Strip gerrit url trailing slash
Test: ./development/tools/repo_pull/repo_review.py 'topic:"..."' --set-topic "..."
Change-Id: Ifaadfdd3ecd615bbe6948be46ac91a15373bdc3b
2020-08-07 12:42:50 +08:00
Pablo Gamito
593714cbd9 Make sure bottom navbar is present before referencing it
If there is no timeline to show, the bottom navbar will not be present but it will still try to access it

Test: Make sure the errors related to this problem are gone
Change-Id: I9edf9082d2eb15ad9cb72ef87117155cefef5b8b
2020-08-06 12:07:16 +01:00
Pablo Gamito
ada63ef3aa Prevent treeview node text from overflowing
Test: Visual
Change-Id: Ib7f0592727a0de511784a1b8f935d0b12849e4b5
2020-08-04 12:58:23 +01:00
Pablo Gamito
3f23913059 Update webpack config to compile Kotlin flickerlib to JS
The kotlin webpack plugin requires the latest webpack version so webpack was updated and refactored to modern standards

Test: Run 'yarn run dev' and 'yarn run build' and make sure everything still build and that a JavaScript compiled version of flickerlib is found in 'kotlin_build'
Change-Id: I02cc1e5bb16afeb5c407a18926ee485d715e41df
2020-08-04 12:16:40 +01:00
Pablo Gamito
923ba4d55f Add clear option to resize PiP
Test: Visual
Change-Id: Id6ab0167cc7e3bd1da73c2b26389e822e92a4c1f
2020-08-03 18:06:41 +01:00
Pablo Gamito
32c09ffc1b Fix missing chip style in treeview
Test: Visual
Change-Id: I356da9405b6f22b75d4ab05a8401b9ee0f450327
2020-08-03 16:39:45 +01:00
Pablo Gamito
98bb7f2ed2 Merge "Make color of layer id different to layer name in transaction view" 2020-07-29 19:16:25 +00:00
Pablo Gamito
86050be44c Merge "Add layer name to transaction change view" 2020-07-29 19:16:12 +00:00
Pablo Gamito
854f09d0c5 Merge "Add indication of last removed log entries" 2020-07-29 19:15:53 +00:00
Pablo Gamito
a56592652d Merge "Add colors for different properties in treeview" 2020-07-29 19:15:37 +00:00
Pablo Gamito
1207025a80 Merge "Add extra padding when bottom nav is expanded" 2020-07-29 19:15:07 +00:00
Pablo Gamito
b59cb5d90e Merge changes I1fbff572,Ie2f46bfc,Ie9acdbc8
* changes:
  Add filter for origin PID and UID
  Use layerName for surface name filter rather than obj name
  Display information about applied from main thread
2020-07-29 19:14:00 +00:00
Pablo Gamito
06102a2e59 Add colors for different properties in treeview
Test: Check how it looks
Change-Id: I4b7da4eeebaa39febf20907ad77ceb0f6f5d6f8a
2020-07-29 17:13:37 +01:00
Pablo Gamito
23858ba8d4 Change treeview leaf icon to be less visible
Test: Visual
Change-Id: I09ce3d043f1389d5eb87b4cb4e390b91cc442f68
2020-07-29 17:10:14 +01:00
Pablo Gamito
a11673db41 Make color of layer id different to layer name in transaction view
Test: visual
Change-Id: I7f7369643df8e66a1b8318bd1d358f4213140671
2020-07-29 16:31:19 +01:00
Pablo Gamito
19db1a5688 Add layer name to transaction change view
Test: Make sure layer names show up when looking at the changes view
Change-Id: I29efcc6522fb5701d86e44da2cb29655df15beb5
2020-07-29 14:10:48 +01:00
TreeHugger Robot
c1439e6bb2 Merge "winscope: add options to specify surfaceflinger trace flags" 2020-07-27 17:53:44 +00:00
Vishnu Nair
f2a344860f winscope: add options to specify surfaceflinger trace flags
Test: set flags in winscope and read back traces from adb proxy
Change-Id: I9a49747ad38234e4545e494287de0a7b290aae02
2020-07-27 09:53:57 -07:00
Pablo Gamito
8923f53233 Add extra padding when bottom nav is expanded
Test: Visual
Change-Id: I6d42e07ab945a37b21b6f9cc328d348ddef5507c
2020-07-24 17:41:00 +01:00
Pablo Gamito
5453465dee Merge "Highlight selected transaction in transactions log" 2020-07-24 10:39:50 +00:00
Pablo Gamito
0c14b12265 Add indication of last removed log entries
When navigating backwards make sure it is clear which protolog entries have been removed by changing the background color of the last removed entries

Test: Visual
Change-Id: I20bdce6eba84382a8489f282b0906dbe3f6123b4
2020-07-24 11:38:19 +01:00
Pablo Gamito
c4923eba86 Highlight selected transaction in transactions log
Test: Visual
Change-Id: I7b6043220c1875aaf90c25451a7a1d2e084a46ff
2020-07-23 19:26:24 +01:00
Pablo Gamito
73706dad35 Keep treeview lines highlighted on selected element
Test: Visual
Change-Id: Idb63c0e20920230727ff853d95e318403813c26a
2020-07-23 19:01:22 +01:00