Commit Graph

4327 Commits

Author SHA1 Message Date
Kean Mariotti
24965f613d Add 'npm run test:presubmit' script
Fix: b/285562786
Test: npm run test:presubmit
Change-Id: Ieddaf47c6737fe49d485bf4d81d2b711e4334cd2
2023-06-02 12:25:23 +00:00
Kean Mariotti
d1c80891d9 Change displayed trace descriptors
Descriptor before:
'Transitions (wm_transition_trace.winscope (bugreport.zip), shell_transition_trace.winscope (bugreport.zip))'

Descriptor after:
'wm_transition_trace.winscope (bugreport.zip), shell_transition_trace.winscope (bugreport.zip)'

Fix: b/285561971
Test: load trace and check the displayed descriptor
Change-Id: Ia96c58d563036c68e2d9ab428a94051a23a6a5b9
2023-06-02 12:25:09 +00:00
Kean Mariotti
bc966c455c Optimize bugreport loading
Fix: b/269342535
Test: npm run test:all
Change-Id: I89e03fff08fe1c7e7169a6eeb08efeda04d098d0
2023-06-02 12:08:00 +00:00
Kean Mariotti
35e2e69f95 Fix broken tests
Test: npm run test:all
Change-Id: I6f064dc8846b2e65dfb002d002aee80d8422c537
2023-05-31 09:37:16 +00:00
Pablo Gamito
daa40dbd3f Fix winscope test
Meant to be amended to ag/23466728 but was auto-merged before I could

Test: npm run test:all
Bug: 23466728
Change-Id: I2cfb1ba7214ec0b316b489ef84a138861d878321
2023-05-30 15:08:02 +00:00
Pablo Gamito
115ed2f243 Add tooltips to icons
And add icon next to the trace name in more places for better association of icon to trace

Fixes: 284100487
Test: npm run test:all
Change-Id: I2cfb1ba7214ec0b316b489ef84a138861d878345
2023-05-30 10:31:12 +00:00
Pablo Gamito
8ee2c132b6 Make sure upload traces responds to changes in tracePipeline
Otherwise clearing or removing loaded traces has no effect on the UI.

Test: load traces in winscope, delete some, clear all and make sure UI responds to those changes
Fixes: 283976269
Change-Id: I7eb981367191a47d3b50b31ee68492809275833a
2023-05-24 10:42:16 +00:00
Pablo Gamito
9b0562b4d7 Format transition viewer timestamps to the right type
Bug: 277181336
Test: npm run test:all
Change-Id: I7eb981367191a47d3b50b31ee68492848572833a
2023-05-23 16:41:25 +00:00
Pablo Gamito
c12b72ac70 Add status to transition rows
Bug: 277181336
Test: npm run test:all
Change-Id: I7eb981367191a47d3b50b31ee68492844936923a
2023-05-23 15:24:55 +00:00
Pablo Gamito
fa6d593ca2 Update Long parameters in WmTransitionData to Strings
For JS compatibility in Winscope

Test: load transition trace and make sure we have transaction ids
Bug: 277181336
Change-Id: I174222b90ecc9b6a82d48c0e469104bd857387e5
2023-05-23 13:27:35 +00:00
Pablo Gamito
1e01280f59 Rename getLoadedTraceFiles to getLoadedTraces
Bug: 277181336
Test: npm run test:all
Change-Id: I7eb981367191a47d3b50b31ee66f14774936923a
2023-05-23 12:57:30 +00:00
Pablo Gamito
deee75f952 Fix typo
Bug: 277181336
Test: npm run test:all
Change-Id: I7eb176367191a47d3b50b31ee66f147ff1d6923a
2023-05-23 12:56:37 +00:00
Pablo Gamito
8317c066aa Update e2e tests
Bug: 277181336
Test: npm run test:all
Change-Id: I7eb923367191a47d3b50b31ee66f147ff1d6923a
2023-05-22 16:40:57 +00:00
Pablo Gamito
4d49b499a9 Update protractor config
Test: npm run test:e2e
Change-Id: I7eb981367191c47d3b50b31ee66f147ff1d1223c
2023-05-22 14:30:23 +00:00
Pablo Gamito
ac6415277c Add transition trace viewer
Bug: 277181336
Test: npm run test:all
Change-Id: I7eb981367191a47d3b50b31ee66f147ff1d6923a
2023-05-22 14:30:23 +00:00
Pablo Gamito
a735b202f7 Add transition traces parser
Bug: 277181336
Test: npm run test:all
Change-Id: I7eb981367191c47d3b50b31ee66f147ff1d6923c
2023-05-22 14:29:56 +00:00
Pablo Gamito
99afc1013b Support multiple files for a single trace
Bug: 277181336
Test: npm run build:all && npm run test:all
Change-Id: I7eb981367191c47d3b50b31ee66f147ff1d69431
2023-05-22 14:20:39 +00:00
Pablo Gamito
28c77be00f Add WM & Shell side transitions parsers
Bug: 277181336
Test: npm run test:all

Change-Id: I7eb981367191c47d3b50b31ee66f147ff1d6943d
2023-05-22 08:29:03 +00:00
Pablo Gamito
b6eb4bb828 Strip bugreport
Test: npm run test:e2e

Bug: 277181336
Change-Id: I241450fca4b6950ca0e41ff7f62adb85cf37af5f
2023-05-16 08:58:36 +00:00
Pablo Gamito
edd0219c54 Update Winscope proxy to collect both transition trace files
Bug: 277181336
Test: npm run build:all && npm run test:all
Change-Id: I6697812fe929efe0927358fe14dc0ea155199631
2023-05-04 10:33:08 +00:00
Kean Mariotti
7d26ddf5ba Merge "Improve logging in winscope_proxy.py" into udc-dev 2023-04-26 10:22:49 +00:00
Kean Mariotti
1e9651a0b5 Improve logging in winscope_proxy.py
Bug: b/278881845
Test: python3 src/adb/winscope_proxy.py and check that go/winscope can capture traces
Change-Id: I45b9eaf49bd21e691666e5132fb50cfc62629618
2023-04-21 16:35:27 +00:00
Pablo Gamito
15460462e4 Show default transaction values
If we don't show the values it can be confusing to users what the value has changed to.

Test: NA
Change-Id: I8c19f2654dc5110fd35156545ff490998ae28b8b
2023-04-20 09:39:28 +00:00
Junghoon Jang
25dd9a2691 Merge "repo-pull: Introduce --ignore-unknown-changes arg" am: e4f118be6f am: 055ae89408 am: d1a1bdc184
Original change: https://android-review.googlesource.com/c/platform/development/+/2544230

Change-Id: I3fbdaaecb4d28eb4c5433614056e492ae5891315
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 13:03:52 +00:00
Junghoon Jang
d1a1bdc184 Merge "repo-pull: Introduce --ignore-unknown-changes arg" am: e4f118be6f am: 055ae89408
Original change: https://android-review.googlesource.com/c/platform/development/+/2544230

Change-Id: Ie3ed911284c55e5fa46af95a51015b3e9ab47e94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-19 12:18:55 +00:00
Junghoon Jang
ac6afae3d6 repo-pull: Introduce --ignore-unknown-changes arg
In the case of pulling changes of a topic which is shared by multiple
repos, if the target source tree doesn't contain all of those repos,
the script will fail to apply changes.

Introduce a new argument, --ignore-unknown-changes, which ignores
changes whose repo is not in the manifest.xml.

Test: Pulling changes of a topic which is shared by multiple repos to
  the source tree which contains part of those repos was done
  successfully with the newly introduce argument.
Change-Id: Ie999121415bc1888b714d023ca251ad89701df11
Signed-off-by: Junghoon Jang <junghoonjang@google.com>
2023-04-18 15:52:07 +00:00
Pablo Gamito
8830d53dab Merge "Implement Transition trace parser in Winscope" into udc-dev 2023-04-18 08:04:04 +00:00
Junghoon Jang
b00f5581b6 Merge changes Iff3cdebe,I9d1add4f am: 40e23904e3 am: 8e297e0ad6 am: e139706c90
Original change: https://android-review.googlesource.com/c/platform/development/+/2530760

Change-Id: I0656f355424b58339b0554f608ddb9b26e40bede
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17 06:43:41 +00:00
Junghoon Jang
e139706c90 Merge changes Iff3cdebe,I9d1add4f am: 40e23904e3 am: 8e297e0ad6
Original change: https://android-review.googlesource.com/c/platform/development/+/2530760

Change-Id: I015fc43fde135a8cdc680ad7ebfa82b36d3dc260
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-17 06:13:18 +00:00
Pablo Gamito
4cb72593d0 Implement Transition trace parser in Winscope
Bug: 265791162
Test: npm run build:all && npm run test:all
Change-Id: Ib37d722079ed75f7c1b75cba506757b6c41f41aa
2023-04-14 15:18:40 +00:00
Junghoon Jang
108c36c52b repo-pull: Introduce --current-branch argument
To make the script can be used from automatic scripts, introduce
`--current-branch` argument which allows pulling commits to the current
branch without creating a local branch. It will skip the prompt which
asking about the creation of a local branch.

Test: With --current-branch argument, the script doesn't ask setting
  local branch name.
Change-Id: Iff3cdebe6338bb2be738e60047d5c4dd81cde4f0
Signed-off-by: Junghoon Jang <junghoonjang@google.com>
2023-04-14 12:25:29 +00:00
Junghoon Jang
172ccfe52d repo-pull: Consider branch of repo
In the case of one source tree containing multiple repos with the same
project, but different branches, the script won't sync them properly.
To fix it, make it consider the branch along with the project.

Test: Tested syncing well in the directory which contains multiple repos
  with the same project, but different branches.
Change-Id: I9d1add4ffe85f80f8f9d6a3ae2c046473d7c4631
Signed-off-by: Junghoon Jang <junghoonjang@google.com>
2023-04-14 12:24:51 +00:00
Pablo Gamito
d27b1735e6 Implement Eventlog parser in Winscope
Test: atest npm run build:all && npm run test:all
Fixes: 258182396
Fixes: 262290862
Change-Id: I2081e462669f4d4b4e92674d397030974b7f34c4
2023-04-14 12:13:46 +00:00
Kean Mariotti
0bf3266fca Merge "Prepare for typescript upgrade" into udc-dev 2023-04-14 10:36:41 +00:00
Kean Mariotti
85a32a7457 Prepare for typescript upgrade
Bug: b/277218358
Test: npm run build:all && npm run test:all
Change-Id: Ifb8b08daf2597f0d6ee46ad0f0ae24af51f86cd4
2023-04-13 20:44:01 +00:00
Pablo Gamito
c3dfefeae4 Expect transition trace to be loaded from bugreport
Bug: 277181336
Test: npm run test:e2e
Change-Id: I72f9362db272c59f030f78a2e30cb9140d2d44d6
2023-04-13 09:53:37 +00:00
Pablo Gamito
005cf18525 Fix formatting
Test: N/A
Change-Id: I5c0fa8d3f7697d81e62029b20345df192fb08f63
2023-04-12 09:26:24 +00:00
Pablo Gamito
883da85ea4 Support transition trace capturing in Winscope
Test: npm run build:all && npm run test:all
Bug: 265791162
Change-Id: Ie1d8604bbb362ee1940dc46291446cdbbeeeecda
2023-04-11 09:34:02 +00:00
Pablo Gamito
4dfbda2b42 Support Event Log capturing in Winscope
Test: npm run build:unit && npm run test:unit
Fixes: 258182396
Fixes: 262290862
Change-Id: Ia3b3d004555711a6ee418a4d6a47cd3f3579e901
2023-04-11 09:34:01 +00:00
Kean Mariotti
9b8e3f85bf Adapt transactions viewer to new proto definition (renamed fields)
Fix: b/277024052
Test: npm run build:all && npm run test:all
Change-Id: I787ee0a8f4574e367f3b578ff3ed51a57f8d7358
2023-04-05 09:10:26 +00:00
Kean Mariotti
50bb7a1e0c Merge changes I43412fc8,I23fb7418,Ia60ceb47,I5d3a1bc0,Ic434abc3, ... into udc-dev
* changes:
  Display progress bar while computing frame mapping
  Integrate "UI Traces API" with timeline components
  Integrate "UI Traces API" with viewers
  Integrate "UI Traces API" with parsers
  Integrate "UI Traces API" with Winscope App/Core
  Rename TraceData -> TracePipeline
  Add new "UI Traces API"
  Extend ArrayUtils
2023-04-02 08:53:18 +00:00
Treehugger Robot
b667e6e274 Merge changes I3e156afa,Id7e4f2eb am: 116fa3048f am: 864082db3d am: cf2761f253
Original change: https://android-review.googlesource.com/c/platform/development/+/2513461

Change-Id: Ib244c1e6d9586e52eff2285f3b42317c2debf891
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 19:33:11 +00:00
Treehugger Robot
cf2761f253 Merge changes I3e156afa,Id7e4f2eb am: 116fa3048f am: 864082db3d
Original change: https://android-review.googlesource.com/c/platform/development/+/2513461

Change-Id: I2eb813107b7d5d0ce105e8b6909d32aa6062da39
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 18:26:11 +00:00
Frederick Mayle
5a6dbaae7a cargo_embargo: detect and ignore harness-less tests
These currently cause cargo_embargo to fail. We should support them
eventually, but for now we'll ignore them to unblock crosvm merges.

Test: external/crosvm/android-merge-2-cargo-embargo.sh
Bug: 275386231
Change-Id: I3e156afa5672ddd6257c7caabd05346e060448fb
2023-03-29 15:25:57 -07:00
Frederick Mayle
04a1650a5f cargo_embargo: use enum for crate type
No behavior change intended.

This will make a following CL easier.

Test: external/crosvm/android-merge-2-cargo-embargo.sh
Bug: 275386231
Change-Id: Id7e4f2eb3f25fa12d867852a0ec95ce443949257
2023-03-29 15:24:21 -07:00
Kean Mariotti
0b2bfff758 Display progress bar while computing frame mapping
- Move duplicated trace load logic from TraceUploadComponent/TraceCollectionComponent into mediator
- Open snackbar messages from Mediator
- Change TraceUploadComponent's interface (FileDownloadListener -> ProgressListener)
- Notify TraceUploadComponent about frame mapping progress

Bug: b/256564627
Test: npm run build:all && npm run test:all
Change-Id: I43412fc8eba2806feb2170ea50702333cf1dd963
2023-03-24 13:31:54 +00:00
Kean Mariotti
297b641a04 Integrate "UI Traces API" with timeline components
Bug: b/256564627
Test: npm run build:all && npm run test:all
Change-Id: I23fb7418389cfe29f98cfe9706191a9032a4be92
2023-03-24 13:31:54 +00:00
Kean Mariotti
f54172dadd Integrate "UI Traces API" with viewers
Bug: b/256564627
Test: npm run build:all && npm run test:all
Change-Id: Ia60ceb479ced5c547579dc67336314c1d22d13fe
2023-03-24 13:31:54 +00:00
Kean Mariotti
8777d32f37 Integrate "UI Traces API" with parsers
Bug: b/256564627
Test: npm run build:all && npm run test:all
Change-Id: I5d3a1bc0a954b486225ff54bf219f6643aab69e3
2023-03-24 13:31:54 +00:00
Kean Mariotti
3a01939e03 Integrate "UI Traces API" with Winscope App/Core
Bug: b/256564627
Test: npm run build:all && npm run test:all
Change-Id: Ic434abc3031b9d53ddb6289fed747971e90c430e
2023-03-24 13:31:54 +00:00