Commit Graph

5 Commits

Author SHA1 Message Date
Aurimas Liutikas
2d59cfb992 Add support for running Checkstyle on a given SHA-1.
Usage e.g.: ./checkstyle.py -s 3aca02ca91816a86febb5ed6e380ec2122adea47

Additionally this CL adds a pre-push script that can be used a git
hook to run Checkstyle on 'repo upload'

Bug: 25852971
Change-Id: Ia00d48df80b2b024de0899d9590868016c5b7bf0
2016-01-25 17:16:28 -08:00
Aurimas Liutikas
a0e889762d Checkstyle handling when all lines are deleted.
It is valid to have empty modified_lines list for files
that only contain deletions. In such case we should skip
all the errors except for forced rules.

Updated the test to match the expectation.

Change-Id: I6993968b882fb6fbe2ba1f63f3b6879c3308ff34
2016-01-21 14:43:12 -08:00
Aurimas Liutikas
6b82b75c69 Allow to run checkstyle with untracked files present.
Additionally, this CL adds basic tests.

Bug: 25852971

Change-Id: Ia8a62e0d49428e1d933d2cef832c977e62f9c614
(cherry picked from commit 55e7480eff)
2015-12-18 00:54:02 +00:00
Aurimas Liutikas
4e8bad8045 Fix a crash when a brand new file is added.
Checkstyle.py was not handling additions of new files resulting in
a crash. For new files git.modified_lines() returns None. Added code
handles that case.

Bug: 25852971
Change-Id: I91e2b8c92581ec9e89bcbbcd2d274f56c791f3a9
(cherry picked from commit 5b87dbad0c)
2015-12-18 00:53:20 +00:00
Aurimas Liutikas
1fc79c2192 Add a script that allows developers to run checkstyle.
Allow developers to run Java style check in two ways.

Specific file:
checkstyle.py -f path/to/file/View.java

Lines modified in the latest commit:
checkstyle.py

Review moved from https://googleplex-android-review.googlesource.com/#/c/818813/
due to move from packages/experimental to development/tools

Bug: 25852971
Change-Id: Ibcf9d80644f2938828b21e8f50ab0d6f39c286b0
(cherry picked from commit 96f27d0960)
2015-12-18 00:52:35 +00:00