Commit Graph

2932 Commits

Author SHA1 Message Date
Logan Chien
38b51a31c8 Merge "repo-pull: Handle project-not-found error" 2018-08-17 03:51:50 +00:00
Logan Chien
028c2c112b repo-pull: Handle project-not-found error
This commit add an error handler for project-not-found errors, so that
the failure of mapping one project does not stop us from pulling CLs for
other projects.

Test: repo_pull -g [gerrit] [query]
Change-Id: Ied9d400a09c032418cd345dc076948b06058aec4
2018-08-08 17:00:52 +08:00
Logan Chien
dd0c71edcd Merge "repo-review: Add abandon command line option"
am: f35b6297a1

Change-Id: I453bcb6e730cca58bcb9c62e24e37f6a3befc311
2018-07-02 21:40:04 -07:00
Logan Chien
b260a60264 repo-review: Add abandon command line option
This commit adds `--abandon` comand line option to abandon several
change lists.

Test: repo-review.py -g [url] [query] --abandon '[reason]'
Change-Id: I5360e95a284a2d3e77a66d52ea01cec7872b9334
2018-07-03 10:29:30 +08:00
Logan Chien
4988d05f98 Merge changes Ie7318b61,Ie0d350f2
am: c85814676d

Change-Id: Ibf495f39e93998a542a02bb74413f13f508d3811
2018-06-18 20:33:49 -07:00
Logan Chien
bfb414f033 repo-pull: Fix pylint errors
This commit adds several pylint fixes.

Test: for i in *.py; do pylint $i; done
Change-Id: Ie7318b616ef75c2944a4c03185f49b2a3f02db50
2018-06-15 16:06:56 +08:00
Logan Chien
ecd9846942 repo-pull: Fix undefined variable in except clause
This commit renames `process` to `proc` to eliminate an undefined
variable in the except clause.

Test: pylint repo_pull.py
Change-Id: Ie0d350f2c2e0b0e3eed037227dd15839e460d44e
2018-06-15 14:39:24 +08:00
Xin Li
73dc9d8c41 Merge pi-dev-plus-aosp-without-vendor into stage-aosp-master
Bug: 79597307
Change-Id: Ifaec2119ba82252c290f247f120150b7468886a3
2018-06-08 11:06:50 -07:00
Bowgo Tsai
33b91c1932 repo-review: Fix missing imports
Bug: None
Test: ./repo_review.py -g [gerrit] query -l Code-Review +2
Change-Id: Iafac171193299ec3894f9674df08cbdcc213af8b
2018-06-08 17:00:46 +08:00
Po-Chien Hsueh
96f7de1e43 Merge "Compare results across ABIs" am: 02e55c34d8
am: 746049fd39

Change-Id: I31623d7a7196cd3d00c62b0a885babc8aad2b128
2018-06-07 11:28:26 -07:00
Treehugger Robot
02e55c34d8 Merge "Compare results across ABIs" 2018-06-07 17:35:46 +00:00
Po-Chien Hsueh
21d011cc08 Compare results across ABIs
We need to compare results between x86 and arm. 32bit and 64bit.

Bug: 79442777
Test: run the script against x86_64 Emulator and Pixel 2
Change-Id: I47ced1cfed7539c1c8cc0c84eaaa8b4ac69b69be
2018-06-07 15:59:50 +08:00
Logan Chien
3715eae4db Merge "repo-patch: Download patch files from Gerrit" am: 7cc827ff88
am: 270f1eeeec

Change-Id: Ifc73b2c148ad2228610a3ec13a90d949d03a770d
2018-06-07 00:24:02 -07:00
Logan Chien
27ff684538 Merge changes Iad120cef,I1f819c51,Ia87e5a80,I95e92c08 am: 10dd0c05bc
am: 13b3742c58

Change-Id: I778c99c29db7550f704e7b0440e7b2085908a91c
2018-06-06 21:54:25 -07:00
Logan Chien
4721aa1eed repo-patch: Download patch files from Gerrit
This commit adds a utility to download multiple patch files from Gerrit
by a change list query.

Test: repo_patch.py -g [gerrit] [query]
Change-Id: I3685c48d2ea4e5a9fa1915c4e31bc6ebb2d4ed97
2018-06-07 11:02:01 +08:00
Logan Chien
e9b0d96cf0 repo-pull: Support more git fetch protocols
This commit adds sso and rpc to git fetch commands.

Test: repo_pull.py pull -g [gerrit] [query]
Change-Id: Iad120cef4460ccc67b723467be638cc9299925fe
2018-06-06 18:32:50 +08:00
Logan Chien
3f67c28b52 repo-pull: Check Gerrit Code Review domain name
This commit adds a search on Gerrit Code Review URL so that a better
error message can be shown to users and the setup instructions can be
presented.

Test: repo_pull.py json -g [gerrit] [query]
Test: repo_review.py -g [gerrit] [query] -l Code-Review 2
Change-Id: I1f819c51e34c573f526ca3e30e237cdaf8a27160
2018-06-06 18:16:31 +08:00
Po-Chien Hsueh
d79b1efebb Merge "Add a tool which compares failed tests" am: 08fb698944
am: 668ca492b3

Change-Id: I772962e2ba299d638e9d32ae49639b7912d60027
2018-05-21 15:30:31 -07:00
Po-Chien Hsueh
d08e072414 Add a tool which compares failed tests
Given two test_result.xml's (A and B), this script lists all failed
tests in A, and shows result of the same test in B. This is usually
used for regression detection or device stability analysis.

Bug: 79442777
Test: ./compare_failed_tests.py test_result_a.xml test_result_b.xml
Change-Id: I7778b5d748daccdeadabe6a539e1ce9622e535c5
2018-05-18 17:40:13 +08:00
Logan Chien
783a072de3 Merge changes Ib8bdaa14,I62380485,I6cbedbd2 am: b7f136bed4
am: 0a331739ac

Change-Id: I6234f9303e99704f7f782f4df4ba93ced584b712
2018-04-20 09:27:27 -07:00
Logan Chien
36d5edd405 repo-pull: Add --pick for non-merge commits
This commit adds the `--pick` command line option so that users can
choose the git command for the non-merge commits.

Test: repo_pull.py pull -g GERRIT QUERY -p merge-ff-only
Change-Id: Ib8bdaa1418dc2fb48d0f0e3c4eb995a23c007563
2018-04-20 18:29:48 +08:00
Logan Chien
1e026cfcc4 repo-pull: Allow to ignore local branch name
This commit allows users to omit `--branch` from command line options.
`repo_pull.py` will not call `repo start` if `--branch` is unspecified.

Test: repo_pull.py bash -g GERRIT QUERY
Change-Id: I62380485f057bd35ab8ae4d5e70372ff5d05fcc5
2018-04-20 18:29:48 +08:00
Logan Chien
9d19090823 repo-pull: Add checkout for merge commits
This commit adds `-m checkout` for merge commits.  If `-m checkout` is
specified, `repo_pull.py` will pull the merge commits with
`git checkout FETCH_HEAD`.

Test: repo_pull.py bash -g GERRIT QUERY -m checkout -b local_branch_name
Change-Id: I6cbedbd2941c63c8bb0591b6033a136829ffda47
2018-04-20 18:29:44 +08:00
Scott Lobdell
85a2507932 Merge "Update behavior of commits not upstreamed to include pure deletions" am: 97bd347fcf
am: 64a6611cd4

Change-Id: I95b4ed47ab4f671a05803e398bc234d1bf9d6b9e
2018-04-19 14:06:14 -07:00
Scott Lobdell
742553e5f7 Update behavior of commits not upstreamed to include pure deletions
Test: No existing test coverage, will test locally against case
Bug: 77971800

Change-Id: I71f13a07a3fbbcaaa4f8535f10f92f142a8a761a
2018-04-19 20:35:25 +00:00
Logan Chien
ce9b0b542b Merge "repo-review: Add command to post review votes" am: 9aaa383011
am: 965a28801b

Change-Id: I32d45596b60206880416fd33e67de38c6ab6e7b1
2018-04-16 19:11:34 -07:00
Logan Chien
bb914be0e9 repo-review: Add command to post review votes
This commit adds `repo_review.py` to post multiple review votes to
Gerrit.

Test: ./repo_review.py -g [gerrit] [query] -l Code-Review +2
Change-Id: I185d7fb72ac54310049e62c19118b69a8fd94158
2018-04-16 15:32:51 +08:00
Scott Lobdell
81e50f73c9 Merge "Add tool to simplify identification of failing tests" am: 5368d090d7
am: 56f307dbea

Change-Id: Ib8363ecaac2f4fb34af08422a252a0e7c7ec6614
2018-04-12 18:31:13 -07:00
Scott Lobdell
a246ad7241 Add tool to simplify identification of failing tests
Test: Tested against XML files from partner.android.com

Change-Id: I79be39e6be97892df66663dfa74a6e3b1c08c985
2018-04-12 14:36:05 -07:00
Guang Zhu
e6106af3c9 delete tests baked into emulator system image
am: 1c3364c022

Change-Id: Iff3f525633e56b90e1eaff7a859a4ff95edd1940
2018-04-10 10:15:13 -07:00
Guang Zhu
1c3364c022 delete tests baked into emulator system image
- tests are out of maintainence
- the checks were general functional tests on comms related
  areas and should be covered by the same tests across physical
  and virtual devices

Bug: 77496099
Test: build `make -j droid tests dist`
Change-Id: I899764846b4829add5ade8085a43bf88c958914f
2018-04-09 20:21:40 -07:00
Logan Chien
3224a3bf1a Merge "repo-pull: Add repo_pull.py to pull multiple CLs" am: 38db2cff89
am: 2ec91b7c24

Change-Id: I56afdd35cfc67c6af1e70f195d1b0633991b6bf4
2018-03-28 01:47:39 +00:00
Logan Chien
9fefa74796 repo-pull: Add repo_pull.py to pull multiple CLs
With `repo_pull.py`, users can specify a query string and pull all
matching change lists from Gerrit.

Test: repo_pull.py pull -g GERRIT QUERY
Change-Id: I1c64c9d630ab37f94276fde7a654f322ac3aa43c
2018-03-27 20:35:23 +08:00
Yi Jin
84f33f5dbe Remove am/wm.proto
Bug: 72474563
Test: cd development/tools/winscope/ && npm install && npm run dev
Change-Id: Ia16faf80ecbfdeea27ea82d839f4afeb81d904df
2018-03-20 17:37:38 -07:00
Yi Jin
4f9c968aba Rename, see ag/3642615
Bug: 72474563
Test: manual
Change-Id: I894a2075e4e5bc56703e1f4d181f9ff2a3fc70ef
2018-02-26 16:32:05 -08:00
TreeHugger Robot
5b4225dedc Merge "Filter window trace data by WindowContainerProto.visible" 2018-02-07 18:19:01 +00:00
Vishnu Nair
3163272774 Filter window trace data by WindowContainerProto.visible
Bug: 64831661
Test: npm run dev
Change-Id: Icf991804ea8c89b990c1056a27ce1a3c23851ecb
2018-02-07 07:54:55 -08:00
TreeHugger Robot
57bda6c8d1 Merge "Update winscope proto lookup path" 2018-02-07 03:16:16 +00:00
Vishnu Nair
62d93dd1b2 Update winscope proto lookup path
- fix build issue caused by recent privacy proto extensions

Test: npm rum dev
Bug: 64831661
Change-Id: Iae08d10a4de82a5cbe2d7561c4b8884f78d96399
2018-02-06 14:40:42 -08:00
Scott Lobdell
300c54efb4 Parallelize diffing of projects
Test: ./android/development/tools/repo_diff/repo_diff_android.py -u persistent-https://googleplex-android.git.corp.google.com/platform/manifest -b “master-security-release” -r persistent-https://googleplex-android.git.corp.google.com/platform/manifest -a “master”
Change-Id: I55b1cddf81cb8d1f5c6427ee2e131c7a766b36cf
2018-02-06 10:20:23 -08:00
Tor Norbye
d2bb51b97b Merge "Remove metalava: has been moved to separate git repository" 2018-02-01 08:02:42 +00:00
changho.shin
ddd40c718d Merge "Support 'uses-permission.*' case" am: 3f7d731fbd am: 52e32a5337
am: ae1d226c04

Change-Id: I46108d61c62f8d3832837421db3a48122882fb5e
2018-01-31 03:01:29 +00:00
Tor Norbye
afa122ead5 Remove metalava: has been moved to separate git repository
Ditto for the older "extract" tool which is replaced by metalava.

Change-Id: Ie1dbbe3632abe2cd56e86ee83e49731ead6e64fc
2018-01-30 11:28:31 +00:00
changho.shin
b7efebb0bb Support 'uses-permission.*' case
Some applications declare their privileged permission as 'uses-permission-sdk-23(m)',
not 'uses-permission'. Adding '.*' to current regex expression to cover all the cases.

Test: python development/tools/privapp_permissions/privapp_permissions.py

Change-Id: I1ea8c9361bb53035481418631b34607ffecb238c
Signed-off-by: changho.shin <changho.shin@lge.com>
2018-01-30 12:37:11 +09:00
markdr
9066da53f5 Made privapp_permissions.py more dynamic.
This was done largely so automation can make use of
privapp-permissions.xml generation.

Privapp_permissions.py no longer requires the build environment
to be setup. Instead, system files can be pulled from a connected
device, and aapt & adb can be set via the commandline. Otherwise,
they will default to the environment's default aapt/adb.

Priv-apps and the permission lists can be queried from the device
using command flags as well, removing the need for an Android
image to be built locally.

Bug: None
Test: Diff between previous privapp_permissions output and the
      output for these changes was empty for the following runs:

      ./old_privapp_permissions.py
      vs
      ./new_privapp_permissions.py [-d && -s SERIAL]
      ./new_privapp_permissions.py --aapt /path/to/aapt

      ./old_privapp_permissions.py /path/to.apk
      vs
      ./new_privapp_permissions.py /path/to.apk
      ./new_privapp_permissions.py device:/path/to/apk

Change-Id: Ifaf35607d38c1d74111fd2f05628c0192fc791cb
2018-01-26 14:31:33 -08:00
markdr
59cd83b6f2 Fixed a failure when retreiving an error message.
Bug: None
Test: privapp_permissions.py -s ... test.apk
Change-Id: I1b83b38a9af6dd5448f6d3b423d5168bb50db154
2018-01-26 13:13:17 -08:00
TreeHugger Robot
396f99cf38 Merge "Made privapp_permissions.py more dynamic." 2018-01-23 20:19:22 +00:00
markdr
4f676ff63f Made privapp_permissions.py more dynamic.
This was done largely so automation can make use of
privapp-permissions.xml generation.

Privapp_permissions.py no longer requires the build environment
to be setup. Instead, system files can be pulled from a connected
device, and aapt & adb can be set via the commandline. Otherwise,
they will default to the environment's default aapt/adb.

Priv-apps and the permission lists can be queried from the device
using command flags as well, removing the need for an Android
image to be built locally.

Bug: None
Test: Diff between previous privapp_permissions output and the
      output for these changes was empty for the following runs:

      ./old_privapp_permissions.py
      vs
      ./new_privapp_permissions.py [-d && -s SERIAL]
      ./new_privapp_permissions.py --aapt /path/to/aapt

      ./old_privapp_permissions.py /path/to.apk
      vs
      ./new_privapp_permissions.py /path/to.apk
      ./new_privapp_permissions.py device:/path/to/apk

Change-Id: Ifaf35607d38c1d74111fd2f05628c0192fc791cb
2018-01-22 13:12:18 -08:00
Tor Norbye
b19d4e9d48 Metalava: support names in APIs
This CL adds support for names in APIs: In Kotlin,
all parameter names are part of the API. In Java,
formal API parameter names can be specified with
@ParameterName("<name>"). Metalava now tracks this,
and in signature files, public parameter names
are included in signatures; in stubs, parameter
names (whether public or not) are always used but
the public name if specified will win.

This CL also adds enforcement of parameters in
signature file comparisons (you cannot remove or
change a parameter in an API), and when running
with --check-compatibility, all API change warnings
are turned into errors.

Some misc other bug fixes and cleanup.

Test: Unit tests included.
Change-Id: I0cfe0741f325812328cd643d51a2b1e9d644cc21
2018-01-17 21:23:51 -08:00
Tor Norbye
72c834e184 Update metalava library dependency version to 3.1.0-alpha08
Change-Id: I62c1706a7808aee42c774810ef078b37ae1c2ce6
2018-01-16 15:14:20 -08:00