Earlier, we marked two records as different if their access specifiers
were not the same.
Bug: http://b/79493296
Test: tests/test.py
Change-Id: I117a408c7a85624a1e3d7a7477ae789eddd4bccc
The key being added to respective maps which facilitate diffing of
unreferenced user defined types was earlier the linker set key. The
unique id should be used instead. This is because linker set keys for C
and C++ types can be the same, but their unique id's cannot. Thus,
having linker set keys as a key leaves open the possibility of false
type aliasing, whereas the unique id does not.
Test: python3 tests/test.py
Test: python3 tests/test.py \
MyTest.test_libc_and_cpp_with_unused_struct_and_libc_and_cpp_with_unused_cstruct;
before this change, this test fails; after this change, the test
passes.
Change-Id: I91816167a48308a8c812d01e0a09e9bb70c60b50
The record kind (struct, class or union) was not being set while
converting from protobuf to IR.
Test: tests/test.py, all tests pass. Without the change, the default
kind of a C record would have shown up as class_kind.
Change-Id: I507581211a6d30c2c51414c6fab6413eece6b458
Previously, the tests mainly exercised header-abi-diff.
After this change, checked-in reference dumps are compared with
generated dumps. This allows us to:
- get header-abi-dumper and header-abi-linker involved in testing
better.
- Know about any incompatbile message format changes made
inadvertently.
Test: tests/test.py; all tests pass.
Change-Id: I7c7ba0811e6c08c6194a0a11616680279e7a0e1d
1) We do not involve the build system to create test reference dumps. Symbols
in tests, are faked through version scripts to avoid checking in prebuilt .so
test files.
2) Also add a script to create reference abi dumps.
3) Fix a comment in ast_processing.cpp
Test: Run tests/test.py, all tests run and pass on generic arm64, mips64
and x86_64 builds.
Change-Id: Id3a420c1ae093a05a79da4c29e85071f28d714d1
