Commit Graph

3122 Commits

Author SHA1 Message Date
Yo Chiang
7ee04ece2e Merge "repo_diff: workspace mustn't be in existing tree" am: 36f1452bd4 am: 401bea0161
Change-Id: I85c671b6fd0e7907ccee4cd78508c583c887f7d8
2020-04-24 07:26:19 +00:00
Yo Chiang
9e4a1bad45 repo_diff: workspace mustn't be in existing tree
Check that |workspace| is not a sub-directory of an Android tree, so
that we don't `repo init` to a directory outside of |workspace|.

Test: mkdir /tmp/test && cd /tmp/test && repo init [AOSP]
Test: ./repo_diff_android.py  # Should fail to repo-init
Test: rm -rf .repo/ && ./repo_diff_android.py  # Should success
Change-Id: I3e1b94e8e3664cc50ab790aaa7e27b2a8d3feef0
2020-04-23 17:53:47 +08:00
Treehugger Robot
b153393313 Merge "Add a script for generating the NDK documentation." am: eedf0b0986 am: e5d9a4ede0
Change-Id: Ic19d6e1cda8c363fe2b647b1d7e068f7fc53b3f7
2020-04-23 00:37:31 +00:00
Dan Albert
987b0998c7 Add a script for generating the NDK documentation.
This is not going to exactly match the view on devsite since that goes
through a different layer of tooling and is themed differently, but
it's a decent approximation for checking most formatting issues.

Longer term, we need to get prebuilts for doxygen into the tree so we
can revive `m ndk-docs`.

Test: ./build_ndk_docs.py
Bug: http://b/115644359
Change-Id: Ib1533a8f45731a1ae2fbec79d463d17e9124beaa
2020-04-22 14:20:42 -07:00
Treehugger Robot
09836adb6e Merge changes Ibfc261d8,I2c9001ef am: 13954964bc am: 1536cb65fd
Change-Id: I3a803c1e1e4260729c018e1b9631475a0d30adf2
2020-04-21 04:13:58 +00:00
Yo Chiang
dc9a2b7ec9 repo_pull: Handle abnormal responses
urllib.error.HTTPError works as a http response object (same type that
urlopen() returns). Handle the exception by reading and parsing the
response body of the error.

Test: ./repo_review.py --add-reviewer [invalid username] [query]
Test: ./repo_review.py --add-reviewer [ambiguous username] [query]
Change-Id: Ibfc261d83f2f9efd7873835f74ce8d5e980821c9
2020-04-21 02:56:08 +00:00
Yo Chiang
c8827d1fd8 repo_review: Add --add-reviewer, --delete-reviewer
Test: ./repo_review.py --add-reviewer [lint bot] [query]
Test: ./repo_review.py --delete-reviewer [lint bot] [query]
Change-Id: I2c9001ef83e48656053db1dbfe7d373ce2b26eea
2020-04-20 17:00:30 +08:00
TreeHugger Robot
31388f7631 Merge "Fix reading SurfaceFlinger dump in winscope" into rvc-dev am: d9dc576a2a
Change-Id: I41059452e2689114ea1c4f77986fa97163012555
2020-04-14 22:13:40 +00:00
TreeHugger Robot
d9dc576a2a Merge "Fix reading SurfaceFlinger dump in winscope" into rvc-dev 2020-04-14 21:43:48 +00:00
Vishnu Nair
691c104193 Fix reading SurfaceFlinger dump in winscope
Test: open sf dump in bug
Fixes: 153760658
Change-Id: Ie2f83afaa5dc33b0c78bb6c2407588c8dd73e89d
2020-04-10 16:33:33 -07:00
Vishnu Nair
e3542eba83 Fix is_opaque calculations in winscope am: 4b8e9f9b1f
Change-Id: I736234ab96b630c5b0f612bccb0bcdca14f9d88f
2020-04-10 04:28:56 +00:00
Vishnu Nair
4b8e9f9b1f Fix is_opaque calculations in winscope
Test: open trace in bug and confirm app is visible behind screenshot
Fixes: 153694172
Change-Id: I60141afc3a28a5e51177d37fd20155c06dcf5882
2020-04-09 18:32:05 -07:00
TreeHugger Robot
2620649897 Merge "Add occlusion state for surface flinger trace" into rvc-dev am: 12623eba4c
Change-Id: I4e92e04c049148dd9c116729ba25418d94fc74ca
2020-04-07 16:35:03 +00:00
TreeHugger Robot
12623eba4c Merge "Add occlusion state for surface flinger trace" into rvc-dev 2020-04-07 16:23:49 +00:00
Vishnu Nair
126be5111f Add occlusion state for surface flinger trace
If composition state is not available, calculate the occlusion state otherwise
continue to use the visible region.

Bug: b/140854698
Test: open sf trace w/ & w/o composition state
Change-Id: I599fe9a4082af650e14fcd184d0204c1c3f29a95
2020-04-02 16:25:27 -07:00
TreeHugger Robot
a1dac71e5c Merge "Add layer filter to winscope" into rvc-dev am: e871962f81
Change-Id: I6653c2fe223ca3010b12b829e698e47f1cce22f7
2020-03-31 01:37:02 +00:00
Vishnu Nair
c778b9bdb7 Add layer filter to winscope
Uses the same semantics as property filter but is applied to the
hierarchy. If a filter is matches, the nodes children will be shown.

Example: filter by layer ids: 12,14,15
filter by layer name: Wallpaper

Test: open transaction trace and layer trace in winscope
Fixes: 152647597
Change-Id: I2bee5bbf5e4b14efb6aadee5775b46499e8f2ec9
2020-03-27 22:40:38 +00:00
TreeHugger Robot
f092d9ab93 Merge "Calculate max bounds correctly in winscope" into rvc-dev am: 69939a60d2
Change-Id: I6a3725d7dc18a2397096441e160498ecf76ba060
2020-03-20 18:12:10 +00:00
Vishnu Nair
cd7c4662e4 Calculate max bounds correctly in winscope
Fixes: 143083963
Test: open banana.pb from bug in winscope, notice its not cut off
Change-Id: I6443426d8e540d5757aad41ac60ceb361768bb68
2020-03-19 18:39:44 -07:00
TreeHugger Robot
504552b55e Merge "Move wayland support from default build" into rvc-dev am: 37ede275a6
Change-Id: Ic004f00ac26d6f1d65f0ec328b0cfb197584cc1e
2020-03-18 18:40:17 +00:00
Vishnu Nair
cbddf0ad6c Move wayland support from default build
Wayland trace files are not available in AOSP so building Winscope will
break. Instead, pick up stub files by default and provide an option via
env args to pick up Wayland support.

Also removes obsolete protolog stubs which are no longer needed.

Test: Remove wayland trace from path and check if winscope still builds
Test: Build winscope with WAYLAND=true and confirm it pick up waylandproto file

Fixes: 151239942
Change-Id: Ie5b237725cd656c478a2ea99d469963956399714
2020-03-16 23:35:12 +00:00
Automerger Merge Worker
45b6f94127 Show properties for DisplayAreas and DisplayContent am: 7264ef5848
Change-Id: I277b6a785dfbfc61401439287613ddcb91c7f2c7
2020-03-16 21:25:29 +00:00
Vishnu Nair
7264ef5848 Show properties for DisplayAreas and DisplayContent
Test: open wm trace in winscope, check if properties of DC and DA are
visible.
Fixes: 149672519
Change-Id: Ib5181c655a84fec94307846333fc0b1cc29d38fc

Change-Id: Ib442c75f031ceb72aa00493e46d502944827121c
2020-03-16 11:03:49 -07:00
Automerger Merge Worker
c6f3d3dfab Merge "[Winscope] Add pretty-printing for properties view" into rvc-dev am: abd830e3cb
Change-Id: I9d2d78a009b40a3f4f816b7e2e37c2e151e7391a
2020-03-12 03:31:08 +00:00
Alec Mouri
c3457a0454 [Winscope] Add pretty-printing for properties view
This allows hwc blobs to be formatted nicely.

Bug: 119443475
Test: visually inspect SF trace
Change-Id: Ib076e341382bf419cd59d384f2761b0140f04ea4
2020-03-11 18:29:55 -07:00
Automerger Merge Worker
2a1135a500 Support DisplayAreas in Winscope am: cdaead818b
Change-Id: Ie01edc912d3752c2a6ff784105bae95de16e74c1
2020-03-11 00:03:14 +00:00
Vishnu Nair
cdaead818b Support DisplayAreas in Winscope
Bug: 149672519
Test: open trace in winscope

Change-Id: I07eb3ccce0180eb21112417b3949f3953722a29d
2020-03-10 15:19:14 -07:00
Automerger Merge Worker
7aca3c6d44 Update winscope hierachy protolog parsing am: d654c9e302
Change-Id: I8a9d1c13ee9aa2fdb314dd323c5c57a238d39630
2020-03-10 22:09:31 +00:00
Vadim Caen
d654c9e302 Update winscope hierachy protolog parsing
ag/10181371 changed the formart of the protolog dump so mirroring the
changes in winscope

Bug:151140114

Change-Id: Ic9a53303e94d3924017c42b1c37a4a069b383118
(cherry picked from commit 758f832e36)
2020-03-10 14:30:00 +00:00
Automerger Merge Worker
9e2cd763d3 Add EffectLayer visibility to Winscope am: 3553bee9d7
Change-Id: Ib5e20c3ab4a43ca86256e2c6bc6c9eb89b994974
2020-03-09 23:34:46 +00:00
Vishnu Nair
3553bee9d7 Add EffectLayer visibility to Winscope
Bug: 151091744
Test: open pip and splitscreen trace in winscope check to see colors
and shadows are marked as visible

Change-Id: I1083df1c85c85beb9ad93e39a136a61a4359ca62
2020-03-09 18:32:27 +00:00
Automerger Merge Worker
adae421db1 Merge "[Winscope] Add chips for HWC vs GPU composited layers" into rvc-dev am: ae68ae235f
Change-Id: I3d5c239cdf645430dc67307c8ffcb17d50a75c10
2020-03-03 21:33:48 +00:00
Alec Mouri
65066517f1 [Winscope] Add chips for HWC vs GPU composited layers
Bug: 119443475
Test: SF trace
Change-Id: I13289b403d394c07b3ac8e2e7d21e5188bba56d8
2020-02-29 14:33:18 -08:00
Automerger Merge Worker
cb8d08f54f Merge "privapp_permissions: Check product privapp_permissions" am: 8349562e0d am: 9d9e53f9ef
Change-Id: If52911d2a5ea58e1a3d645fc288fa8eb32d9541a
2020-02-27 02:29:46 +00:00
Christian Oder
1ee526c938 privapp_permissions: Check product privapp_permissions
* permission whitelists need to get placed on the same partition as the apps themselves
* check product and system individually and generate XMLs accordingly

Test: Verify missing entries for system and product get generated on hotdog
Test: Verify missing entries for system and system/product get generated on taimen and maple
Change-Id: I37bd5c7b738caaab93019688c6a944dc6bbffa75
2020-02-25 22:48:25 +01:00
Vadim Caen
9f29164784 Fix sysui_trace.proto name
Change-Id: I663923c0101dfb2349022d7deda25000f4ced705
2020-02-12 15:45:39 +01:00
Winson Chung
e079c50b1f Merge "Initial changes to update winscope to read sysui/launcher protos" 2020-01-29 05:04:47 +00:00
Wale Ogunwale
3fa5728f28 Merge "Update Winscope with Windowmanagerservice.proto changes" 2020-01-29 04:40:56 +00:00
Winson Chung
9428955833 Initial changes to update winscope to read sysui/launcher protos
Bug: 144854916
Test: Open sysui/launcher trace in winscope
Change-Id: I2a00351bd688e104ca20a26b8f53a8477e232d8d
2020-01-28 10:18:17 -08:00
Vishnu Nair
c49c2698ec [DO NOT MERGE] Add aosp config for winscope
- config redirects searches to stub folder for unavailable traces

Bug: 148409169
Test: builds and opens traces in AOSP
Change-Id: I5775d732de64c2e66ed35a04bf868f2aee883add
2020-01-27 15:12:29 -08:00
Vishnu Nair
92dccb506d Create stub proto definitions for traces that are not available in AOSP
Also add a readme for winscope development.

Bug: 148409169
Test: builds and opens traces in AOSP

Change-Id: I2767301734bcd90410e0f97bc3da22a647bf195c
2020-01-27 15:12:27 -08:00
chaviw
0fa0953237 Added visibility check for missing relativeOf
When the layer has the flag isRelativeOf but the relativeOf is -1, that
means the relativeOf layer has been removed. This would prevent the
layer from showing up on screen, but still be in memory. Added this
reason to list of reasons why layer wouldn't be visible.

Also added fix for BufferLayer check to instead check for BufferQueueLayer
and BufferStateLayer.

Test: winscope shows "RelativeOf layer has been removed"
Change-Id: Id1d59bd71a5aac7a011204ba345d694f67c28a29
Merged-In: Id1d59bd71a5aac7a011204ba345d694f67c28a29
2020-01-27 10:20:14 -08:00
chaviw
0d8808df5e Added format for ColorTransform matrix
ColorTransform is a 4x4 matrix so formated the values to be more
readable.

Also changed code where determines if the buffer is null to check if the
layer type is BufferStateLayer or BufferQueueLayer

Test: go/winscope with color transform
Change-Id: Ief46f2f3260e0736ffced8c233ab375e162d4228
Merged-In: Ief46f2f3260e0736ffced8c233ab375e162d4228
2020-01-27 10:20:05 -08:00
Adam Pardyl
819c345c1e Update Winscope with ProtoLog changes
Winscope side changes for ag/9225809 and ag/9447040.

Bug:
Test: yarn run dev
Change-Id: I2e34edd244996124fa894ee5ee5a57f554fe771e
Merged-In: I29db4770065ffc5bcced5d4cb17a51d2b9924f06
2020-01-27 10:19:57 -08:00
Adam Pardyl
2a94ec6dba Download trace files from Winscope
Added a download file button to DataView.

Bug:
Test: yarn run dev
Change-Id: I203f3f19168c43a0dbefb3ec00237c021380f89f
Merged-In: I203f3f19168c43a0dbefb3ec00237c021380f89f
2020-01-27 10:19:43 -08:00
Adam Pardyl
c5708b2f83 Support ProtoLog in Winscope
Added a new view for displaying logs, ProtoLog decoding and tracing
with ADB Connect.
Fixed a vertical scrolling bug.

Bug:
Test: yarn run dev
Change-Id: I756b596c10242ff919c0d7053813fa0b9f1f88fd
Merged-In: I756b596c10242ff919c0d7053813fa0b9f1f88fd
2020-01-27 10:19:32 -08:00
Adam Pardyl
7c3b2d568f Support WM & SF dumps with ADB Connect, minor fixes
Added support for capturing WindowManager and SurfaceFlinger dumps
directly from the browser.

Fixed DataFilter errors on non-transaction data files.
Fixed Timeline behaviour on empty data list.

Bug: 140374376
Test: yarn run dev & python3 adb_proxy/winscope_proxy.py
Change-Id: I0d47ec36e1e769b856365d2a36c91bfb1f831b71
Merged-In: I0d47ec36e1e769b856365d2a36c91bfb1f831b71
2020-01-27 10:19:23 -08:00
Adam Pardyl
f9e219ce1d Add transaction tracing support, fix device id regex.
Added support for recording SF transactions with ADB Connect,
Fixed device regex not matching emulated devices.

Bug:
Test: yarn run dev & python3 adb_proxy/winscope_proxy.py
Change-Id: I43b45b978841309d3f011df919df69ae7ebc905a
Merged-In: I43b45b978841309d3f011df919df69ae7ebc905a
2020-01-27 10:19:13 -08:00
Vishnu Nair
a1262475d3 Introduced filters to winscope for transaction files.
Test: Launch winscope and upload a transaction file. Verify that the
filter checklist at the top left corner will filter each of the eight
increment types.

Change-Id: I3e2506bdbe32dbcda59b6f263e2bc13e8403ae38
Merged-In: I3e2506bdbe32dbcda59b6f263e2bc13e8403ae38
2020-01-27 10:19:02 -08:00
Adam Pardyl
ab03a005c0 Fix variable name in DataAdb
A typo in a variable name caused the exception handling to fail.

Bug:
Test: yarn run dev
Change-Id: Id02495fe323bbb7f6ccbb973fbe6091a3d518523
Merged-In: Id02495fe323bbb7f6ccbb973fbe6091a3d518523
2020-01-27 10:18:51 -08:00