Commit Graph

4 Commits

Author SHA1 Message Date
Jeongik Cha
b68408275b Refactor compare_images
1. Rename some variables to more detail
2. Fix a bug that occurs when system.img contains product, system_ext
3. Remove multithread code, it made performance worse :(
  before: 136.97s user 1070.22s system 290% cpu 6:55.84 total
  after:  56.29s user 76.95s system 105% cpu 2:06.84 total

Bug: 138329983
Test: compare some images, and check if result is same as before
Change-Id: I4cec27475283a34d063ad3251cfc5909c34071c1
2019-07-25 19:14:20 +09:00
Jeongik Cha
30c0f1ede6 Rename tool's name
system_product_image_diff -> compare_images

it has more general options, so change its name more general

Bug: 131273025
Test: m
Change-Id: I7579f01edb9f8b8f2fe727b405a592b9c6217eb4
2019-07-16 15:10:12 +09:00
Jeongik Cha
5864907380 Add --ignore_signing_key option in compare tool
Even though some apps has identical contents(code, resource), they looks
different from each other if signing keys are different.

So, for efficiency, add --ignore_signing_key option in compare tool.
If it is set, sha1sum logic is changed.
As-is: sha1sum apk_file
To-be: add every sha1sum of files that are in apk_file except META-INF,
and then get sha1sum from sha1sums

Bug: 135503972
Test: compare two apk of which code and resource is same but signing key
is diffent.

Change-Id: I2176fdfce5f0fc2181073a1a1183c51dfbfaee49
2019-07-12 22:40:03 +09:00
Jeongik Cha
062f2b09ca system and product image diff tool
This tool compares system and product image across models, and generate
common.csv and diff.csv

Here is example output
- common.csv:
filename, sha1sum, targets
/system/a, da39a3ee5e, a;b;c

- diff.csv:
filename, sha1sum, targets
/system/b, da39a3ee5e, a;b
/system/c, 3f786850e3, a
/system/c, 89e6c98d92, b;c

Bug: 131273025
Test: m system_product_image_diff
Test: system_product_image_diff -t model1 model2 -s system product

Change-Id: Ie9cc368e0a6d26e956f1e27ebe683bea5e80465c
2019-06-14 15:15:38 +09:00