Commit Graph

25865 Commits

Author SHA1 Message Date
Justin Yun
74b00cb5f7 build_mixed: removed product.img if system_dir does not have one.
When '-s' option is used but the system_dir does not have a
product.img, removed existing product.img from the device image.

Bug: 120578242
Test: build_mixed -s system_dir device_dir out_dir checkvintf
Change-Id: Ib669763847f3661596a74a6833b2030685d58ad5
2019-01-04 08:43:36 +00:00
Logan Chien
de1f49cfbd Merge changes If02db179,Ic24aa25e,Icf205d03,I9856b08f,I6fc9fcef, ... am: 70c887a441
am: dece956b1f

Change-Id: If45545962cd8ff8b2e66a77b9165de84c27b3819
2019-01-03 22:19:29 -08:00
Logan Chien
dece956b1f Merge changes If02db179,Ic24aa25e,Icf205d03,I9856b08f,I6fc9fcef, ...
am: 70c887a441

Change-Id: Ia08787f0750e6dce247c7ff6ff162308f6b4397e
2019-01-03 22:14:58 -08:00
Logan Chien
70c887a441 Merge changes If02db179,Ic24aa25e,Icf205d03,I9856b08f,I6fc9fcef, ...
* changes:
  vndk-def: Refine test_command_deps_insight
  vndk-def: Fix trivial pylint errors
  vndk-def: Unhide a test case
  vndk-def: Fix deprecated warning in unittest
  vndk-def: Cleanup import pylint errors
  vndk-def: Fix spacing errors found by pylint
  vndk-def: Separate methods with two empty lines
  vndk-def: Cleanup dep-graph
  vndk-def: Mark --output as a required argument
2019-01-04 06:05:18 +00:00
Logan Chien
fec31ff38f vndk-def: Refine test_command_deps_insight
Test: ./tests/run.sh
Change-Id: If02db179c58275af509a76e5f2cdebb1b39d1ea3
2019-01-03 21:49:12 +08:00
Logan Chien
2beb6cf22f vndk-def: Fix trivial pylint errors
This commit fixes several trivial pylint errors:
dangerous-default-value, inconsistent-return-statements,
redefined-builtin, too-few-public-methods, and unused-variable.

Test: ./tests/run.sh
Change-Id: Ic24aa25e7a7aacb836f76538c7c232072e86e02e
2019-01-03 20:37:59 +08:00
Logan Chien
a9c0e37935 vndk-def: Unhide a test case
This commit unhide a test case in `test_dex_file.py`.  The test case was
hidden because the same method name was redefined.

Test: ./tests/run.sh  # 124 test cases
Change-Id: Icf205d03e1b8db4a896aeb01615fa4993e73b4ce
2019-01-03 19:46:43 +08:00
Logan Chien
0b8758197f vndk-def: Fix deprecated warning in unittest
This commit adds a TestCase compatibility layer to support `assertRegex`
and `assertNotRegex` in both Python 2.7 and 3.5.  This removes a
deprecated warning while running test cases with Python 3.5.

Test: ./tests/run.sh
Change-Id: I9856b08f18ae92d110f37f75d444f09692f08acf
2019-01-03 19:44:39 +08:00
Logan Chien
eaacaac29d vndk-def: Cleanup import pylint errors
Test: ./tests/run.sh
Change-Id: I6fc9fcef8164fb1f795f5902d900f34e99b1228d
2019-01-03 18:43:26 +08:00
Logan Chien
c7bf9936da vndk-def: Fix spacing errors found by pylint
This commit fixes several spacing errors (e.g. indention,
and space-after-comma) that are found by pylint.

Test: ./tests/run.py
Change-Id: I830a9cddc91e21421b16c2a1d1a101c0beb7af62
2019-01-03 18:19:52 +08:00
Logan Chien
64c28f7422 vndk-def: Separate methods with two empty lines
This commit adds several empty lines to the file so that all method
definitions in `vndk_definition_tool.py` are separated by two empty
lines.

Test: n/a
Change-Id: I5976dec4ba73a80a29693bfa92fcaf5ecceace9d
2019-01-03 18:18:04 +08:00
Logan Chien
d7867edc4f vndk-def: Cleanup dep-graph
This commit cleans the code for `dep-graph` command.

Test: ./vndk_definition_tool.py dep-graph --system ... --vendor ...
Change-Id: Ib902d6d4015a5add89f4bed39088ba42310ccbc2
2019-01-03 17:36:11 +08:00
Logan Chien
8969d7398a vndk-def: Mark --output as a required argument
This command marks `--output` as a required argument for various
subcommands.

Test: ./vndk_definition_tool.py deps-insight  # see better error message
Change-Id: Ie60e186287beea7e701ab740fcf8c2959bfaec36
2019-01-03 17:00:50 +08:00
Logan Chien
2076aeb301 Merge changes Ia1b282bd,I3c53a5d1 am: 7d101a8593
am: 21a03e4292

Change-Id: I16c7675276aab404c21fc2c4b053bd172e056eb6
2019-01-01 20:31:13 -08:00
Logan Chien
21a03e4292 Merge changes Ia1b282bd,I3c53a5d1
am: 7d101a8593

Change-Id: Ifd4c1749a84db0858cd2f15473c4233666cd79d4
2019-01-01 20:27:18 -08:00
Logan Chien
7d101a8593 Merge changes Ia1b282bd,I3c53a5d1
* changes:
  vndk-def: Code cleanup
  vndk-def: Remove unused command
2019-01-02 04:19:13 +00:00
Logan Chien
b91f472de2 vndk-def: Code cleanup
This commit fixes several pylint errors, such as indention, chainned
comparison, unused variables, unnecessary semicolon, 80-column, etc.

Test: ./tests/run.py
Change-Id: Ia1b282bd3c174af5bfdc28172becff9d10ff0d31
2019-01-02 10:54:39 +08:00
Logan Chien
ad9c90518d vndk-def: Remove unused command
This commit removes unused `check-eligible-list` command from the VNDK
definition tool.

Test: n/a
Change-Id: I3c53a5d1d368715cba2ebe39383ea37de1008ca0
2018-12-28 11:14:49 +08:00
Logan Chien
a30c9a4730 Merge changes Ia9c95b10,I98f78f46,Ibf5e7ff7 am: 7ad38f39e0
am: 8c2f8c4d96

Change-Id: Idcc9b33b88a65b43c79fdb937105cd8b3b2f3a81
2018-12-27 02:02:04 -08:00
Logan Chien
8c2f8c4d96 Merge changes Ia9c95b10,I98f78f46,Ibf5e7ff7
am: 7ad38f39e0

Change-Id: I786c935761dde63e44207566747be85a65cf0ea3
2018-12-27 01:55:15 -08:00
Treehugger Robot
7ad38f39e0 Merge changes Ia9c95b10,I98f78f46,Ibf5e7ff7
* changes:
  Add workaround for _platform suffix
  Copy lsdump files from non-apex variant
  Remove remove_absolute_paths argument
2018-12-27 09:48:37 +00:00
Logan Chien
9c95439ee5 Add workaround for _platform suffix
This commit adds a workaround for `_platform` suffix when the module is
used by some apex modules.

Bug: 121986692
Test: create_reference_dumps.py
Change-Id: Ia9c95b10caca024ef3e0defbad894e8cf16a92b1
2018-12-27 14:50:28 +08:00
Logan Chien
cc68d180cc Copy lsdump files from non-apex variant
This commit refines the logic to pick the lsdump files for reference ABI
dumps.  Before this commit, `findlsdump()` simply use `str_a in str_b`
to check whether module variant name (e.g.
`android_arm_armv7-a-neon_core_shared`) is in the path.  However, this
check also matches the variant for apex modules (e.g.
`android_arm_armv7-a-neon_core_shared_apex.name`).

This commit fixes the problem by splitting each path into path
components and check whether a path component matches with the module
variant name.

Bug: 121986692
Test: development/vndk/tools/header-checker/utils/create_reference_dumps.py
Change-Id: I98f78f460ddeb076f4ca35b7a0d9dcac4a479ae8
2018-12-27 14:33:17 +08:00
Jimmy Chen
6311e6fe0b Merge changes I0f7e3578,Ie50dd642 am: 066974d7d2
am: a37e4bcb33

Change-Id: I8e3dd26579bde84d49b64d32885ada94e30fe7d6
2018-12-26 22:01:37 -08:00
Jimmy Chen
a37e4bcb33 Merge changes I0f7e3578,Ie50dd642
am: 066974d7d2

Change-Id: Iec4e68b81e0619c2120700bf96260ddb7f7079e4
2018-12-26 21:57:40 -08:00
Jimmy Chen
066974d7d2 Merge changes I0f7e3578,Ie50dd642
* changes:
  WiFiDirectDemo: fix no peer in list after m-release
  WiFiDirectDemo: fix broken sample code
2018-12-27 05:49:28 +00:00
Logan Chien
d796b6ba89 Remove remove_absolute_paths argument
This commit removes the `remove_absolute_paths` argument from
`run_header_abi_dumper` because all usages pass `True`.

Test: ./tests/test.py
Test: ./tests/gen_all.py
Change-Id: Ibf5e7ff72d0c2c76ed3db1d8d272de1d3886c2c4
2018-12-27 11:47:50 +08:00
Hsin-Yi Chen
95f3904cd2 Merge "Add --build-variant to create_reference_dumps.py" am: d3929f3b76
am: 698fab66b0

Change-Id: I9199c284dd1d90ff8a6e42853573208c62bd61b7
2018-12-26 19:42:32 -08:00
Hsin-Yi Chen
b3902c2425 Merge "Do not call build/envsetup.sh in create_reference_dumps" am: 8e167af345
am: 971a737326

Change-Id: Ia116a6dba994efa30602ff9fa1b71d9e2559dec8
2018-12-26 19:41:24 -08:00
Hsin-Yi Chen
698fab66b0 Merge "Add --build-variant to create_reference_dumps.py"
am: d3929f3b76

Change-Id: I6efa1b4b75a7f276fb23f91a700f62d4f7254a68
2018-12-26 19:38:23 -08:00
Hsin-Yi Chen
971a737326 Merge "Do not call build/envsetup.sh in create_reference_dumps"
am: 8e167af345

Change-Id: I91436533a884e4a292ddf09638860c21d4562301
2018-12-26 19:37:18 -08:00
Hsin-Yi Chen
d3929f3b76 Merge "Add --build-variant to create_reference_dumps.py" 2018-12-27 03:31:49 +00:00
Hsin-Yi Chen
8e167af345 Merge "Do not call build/envsetup.sh in create_reference_dumps" 2018-12-27 03:30:27 +00:00
Jimmy Chen
c2b17b167c Merge "WiFiDirectServiceDiscovery: Create a thread for sending message" am: 1906d9c9e3
am: 9f120478bf

Change-Id: I6e05059e7e1931c0f789d0d76a229f0f99b660db
2018-12-26 18:40:05 -08:00
Jimmy Chen
9f120478bf Merge "WiFiDirectServiceDiscovery: Create a thread for sending message"
am: 1906d9c9e3

Change-Id: I14386351d335428fb185cb387557d24cf378c53a
2018-12-26 18:22:48 -08:00
Jimmy Chen
1906d9c9e3 Merge "WiFiDirectServiceDiscovery: Create a thread for sending message" 2018-12-27 02:14:10 +00:00
Hsin-Yi Chen
e249e48f29 Add --build-variant to create_reference_dumps.py
create_reference_dumps.py supports --build-variant which defaults to
userdebug. When the script builds libraries, it sets
TARGET_BUILD_VARIANT instead of inheriting from current environment.

Bug: 121017205
Test: ./create_reference_dumps.py --build-variant eng --llndk -libs libbinder_ndk
Change-Id: Ibe5458c2bb62ebb44755e4bb90566d39a0bd52f2
2018-12-26 17:36:04 +08:00
Hsin-Yi Chen
b8ec3d49de Do not call build/envsetup.sh in create_reference_dumps
This commit makes get_build_vars_for_product get variables by
soong_ui.bash without envsetup.sh.

Bug: 120819347
Test: ./create_reference_dumps.py --llndk -libs libbinder_ndk
Change-Id: I66d1245d277d3c5459c6027ccdb88288aaf4d802
2018-12-25 17:52:58 +08:00
Hsin-Yi Chen
25b7d2dec6 Merge changes I6345a10d,Ieed81827 am: 907cc62b6d
am: 4f51efe30b

Change-Id: Ifaa7173ea4ea816749a9745515bb153adc52ed4b
2018-12-24 20:08:15 -08:00
Hsin-Yi Chen
4f51efe30b Merge changes I6345a10d,Ieed81827
am: 907cc62b6d

Change-Id: I0b82d369e32c266f47c78f6ae55e994b6b486a0b
2018-12-24 19:57:32 -08:00
Hsin-Yi Chen
907cc62b6d Merge changes I6345a10d,Ieed81827
* changes:
  Refactor header-checker tests
  Replace test data for test_libgolden_cpp_fabricated_function_ast_removed_diff
2018-12-25 03:48:18 +00:00
Hsin-Yi Chen
e89977ad7e Refactor header-checker tests
- Rename the unit test class to HeaderCheckerTest.
- Create/delete temporary directory in setUp/tearDown.
- Move make_and_copy_reference_dumps from gen_all.py to test.py.
- Remove duplicate constant paths.
- Add default arguments to LsdumpModule.
- Fix coding style.

Bug: 117582158
Test: ./gen_all.py
Test: ./test.py
Change-Id: I6345a10da5431e8057e4a9321ecce4168b7d5292
2018-12-21 16:02:30 +08:00
Hsin-Yi Chen
8741dcd7f2 Replace test data for test_libgolden_cpp_fabricated_function_ast_removed_diff
The difference between libgolden_cpp.so.lsdump and
libgolden_cpp_fabricated_function_ast_removed.so.lsdump is that the
latter one doesn't have the declaration of "SuperSpeaker::SpeakLouder",
but both of the lsdumps have the ELF symbol.

The source code of libgolden_cpp_fabricated_function_ast_removed is
missing. This commit replaces the test data with
libgolden_cpp_add_function and libgolden_cpp_add_function_sybmol_only.

Test: ./test.py
Bug: 117582158
Change-Id: Ieed8182731372f9ec7b3bdd209af23b0081cb778
2018-12-21 00:22:09 +08:00
Peter Collingbourne
63bf1087eb gdbclient.py: Add --env flag.
This flag allows users to set environment variables when running
a binary.

Change-Id: I01e2729c372da2e231bda86accc805495dcfdc06
2018-12-19 20:52:38 -08:00
dimitry
90f1223e79 Merge "Slightly improve error handling" am: a87126ad77
am: 3e7b0f55ee

Change-Id: Ibfcf7126ee48d288a453c5a06742734bb5157a45
2018-12-19 09:59:49 -08:00
dimitry
3e7b0f55ee Merge "Slightly improve error handling"
am: a87126ad77

Change-Id: I2a32c1035f28c7ccdc2767a2a499d96a790922a6
2018-12-19 09:51:32 -08:00
Treehugger Robot
a87126ad77 Merge "Slightly improve error handling" 2018-12-19 17:32:18 +00:00
dimitry
5f600aa39d Slightly improve error handling
Test: ./development/vndk/tools/header-checker/utils/create_reference_dumps.py -l libGLESv1_CM
Test: now fails with error message
Change-Id: Idd9aa84d8da6d4f6016f41438571ac1f0808be7e
2018-12-18 12:18:55 +01:00
Hsin-Yi Chen
d8cabd7834 Merge "Remove uncompressed prebuilt dumps before building new ones" am: 96b977a3d4
am: 4efc1eac79

Change-Id: I48b3f7683eea76a784830f0636071bec416002ae
2018-12-16 18:29:59 -08:00
Hsin-Yi Chen
4efc1eac79 Merge "Remove uncompressed prebuilt dumps before building new ones"
am: 96b977a3d4

Change-Id: Iae8e751c6ea1f9b527a110f186dd0cde4a38abe7
2018-12-16 18:24:55 -08:00