Commit Graph

3779 Commits

Author SHA1 Message Date
Priyanka
b415682b29 Add display support for tag fields and app pairs.
LayerId now present on windows, and window token will be added to tags
where possible, so display support added on frontend. Also, app pairs
transitions added to colour code.

Bug: b/199274556
Test: upload a trace to ensure everything still displays as normal.
Change-Id: I5d0c2e26ac5f18090d0fe6e8df5f4e1305822c41
2021-09-08 15:10:08 +00:00
TreeHugger Robot
e0e7565fbd Merge "Pass layerId from proto data through to WindowContainer constructor" 2021-09-06 16:56:41 +00:00
TreeHugger Robot
493fd1cd04 Merge "Change defaults to 0 for taskId and layerId." 2021-09-06 16:44:40 +00:00
Priyanka
6d70b2ed93 Change defaults to 0 for taskId and layerId.
Bug: b/198634721
Test: check upload of tags with only a taskId or a layerId.
Change-Id: I8fc44f6074a1e17264177d251f1bd7ba319701d2
2021-09-03 15:12:19 +00:00
Priyanka
70283c4740 Group tags by id and transition.
Tag Id increments for each additional transition of the same type but
resets to zero as each processor is called. This fix groups tags by both
id and transition to avoid confusion.

Bug: b/198757467

Test: upload a trace with multiple types of transition, where
transitions have the same tag id.

Change-Id: Idad9c04dc5ac01faf0234d131cbb03364b2ccc36
2021-09-03 13:04:32 +00:00
Pablo Gamito
592e789e97 Pass layerId from proto data through to WindowContainer constructor
Test: N/A
Change-Id: I8a8db9b496567c0777a1008bc3040fe3f25999e8
2021-09-03 12:43:32 +02:00
Priyanka
06873c96cf Fix logic for multiple tags with same id.
Bug: b/198622547

Test: upload the traces attached to the bug to ensure a rotation
displays on the timeline.

Change-Id: I6acd8bf0bdbd5d2ad15664dcd16096a711697440
2021-09-02 15:21:30 +00:00
Kelvin Zhang
4c253b5284 Merge changes Ic5fdefe2,I32cbd027,I464d846c,Ie9ef8e2b,Ib7b02d5c am: e6ae7c629b am: 8834603a01 am: a30572e3a4 am: 06bfa0009e am: 93ddcc59d9
Original change: https://android-review.googlesource.com/c/platform/development/+/1815621

Change-Id: Ib20dee3d3484d5f1ad785eacdbbec3e620533905
2021-09-01 15:34:03 +00:00
Kelvin Zhang
a230cdc9b6 Merge "Cancel polling task after component unmount" am: 3862d22d0e am: b1da09b852 am: 8a287efeea am: c2272f8e82 am: bd2f4b0e13
Original change: https://android-review.googlesource.com/c/platform/development/+/1815616

Change-Id: I939fa8046e9a0100e7704c62c9b2742ba7104a7c
2021-09-01 15:33:55 +00:00
Kelvin Zhang
623e83e227 Merge "Remove noop try catch statements" am: 401c6d5d23 am: 5e1f196247 am: 5a581bdeb3 am: ad98f50a84 am: 0f9c47934c
Original change: https://android-review.googlesource.com/c/platform/development/+/1815095

Change-Id: I16b4bafca9efd85da23f81012d82f272070c8844
2021-09-01 15:33:45 +00:00
Kelvin Zhang
93ddcc59d9 Merge changes Ic5fdefe2,I32cbd027,I464d846c,Ie9ef8e2b,Ib7b02d5c am: e6ae7c629b am: 8834603a01 am: a30572e3a4 am: 06bfa0009e
Original change: https://android-review.googlesource.com/c/platform/development/+/1815621

Change-Id: I47799c78c525f3334f7eb02c1610ee1dc284d8e1
2021-09-01 15:18:30 +00:00
Kelvin Zhang
bd2f4b0e13 Merge "Cancel polling task after component unmount" am: 3862d22d0e am: b1da09b852 am: 8a287efeea am: c2272f8e82
Original change: https://android-review.googlesource.com/c/platform/development/+/1815616

Change-Id: Id9cc96c9d39f22d2165ae14f764a47ef37799f2d
2021-09-01 15:18:19 +00:00
Kelvin Zhang
0f9c47934c Merge "Remove noop try catch statements" am: 401c6d5d23 am: 5e1f196247 am: 5a581bdeb3 am: ad98f50a84
Original change: https://android-review.googlesource.com/c/platform/development/+/1815095

Change-Id: I0f523f35cf0fd72e8c1d1a499c98d4e7caf66c1f
2021-09-01 15:18:04 +00:00
Kelvin Zhang
8834603a01 Merge changes Ic5fdefe2,I32cbd027,I464d846c,Ie9ef8e2b,Ib7b02d5c am: e6ae7c629b
Original change: https://android-review.googlesource.com/c/platform/development/+/1815621

Change-Id: I18cc97ec071980725514785aafdd7927821410b8
2021-09-01 14:34:23 +00:00
Kelvin Zhang
b1da09b852 Merge "Cancel polling task after component unmount" am: 3862d22d0e
Original change: https://android-review.googlesource.com/c/platform/development/+/1815616

Change-Id: If897bc469c04123262e67807e05f74fdc5a50ac0
2021-09-01 14:34:12 +00:00
Kelvin Zhang
5e1f196247 Merge "Remove noop try catch statements" am: 401c6d5d23
Original change: https://android-review.googlesource.com/c/platform/development/+/1815095

Change-Id: I6c5c988fb833d75cf03359267db6bbce049319fa
2021-09-01 14:34:06 +00:00
TreeHugger Robot
20beac3c08 Merge "Display tags/errors on all timelines." 2021-09-01 10:57:24 +00:00
Pablo Gamito
1bd76ac672 Merge "Make search bar buttons clearer" 2021-09-01 10:42:32 +00:00
Kelvin Zhang
6e0c8c6c37 API Service should return json data directly
Change-Id: Ic5fdefe23443733c3c7e0ae8f351c39117326794
2021-08-31 20:06:57 -07:00
Kelvin Zhang
63b4252142 Merge "Skip non-zip files when refreshing build library" am: 2d4909a1cb am: 985259187a am: 0a3522a60e am: adb23121fd am: 6186351117
Original change: https://android-review.googlesource.com/c/platform/development/+/1811897

Change-Id: I93fc1da7bd208f5662bd147692a62ab7204e7350
2021-09-01 01:43:39 +00:00
Kelvin Zhang
6186351117 Merge "Skip non-zip files when refreshing build library" am: 2d4909a1cb am: 985259187a am: 0a3522a60e am: adb23121fd
Original change: https://android-review.googlesource.com/c/platform/development/+/1811897

Change-Id: Ibc3b79aca659deed86b6d4db1645a84fbc5df324
2021-09-01 01:22:18 +00:00
Kelvin Zhang
985259187a Merge "Skip non-zip files when refreshing build library" am: 2d4909a1cb
Original change: https://android-review.googlesource.com/c/platform/development/+/1811897

Change-Id: I376dbf4d7cf672a7d64419b6cfae634b5b66c91e
2021-09-01 00:37:19 +00:00
Kelvin Zhang
fd50cb8be1 Rename path to db_path
Change-Id: I32cbd02722a81b54f55df092bc762463df939a9d
2021-08-31 17:28:43 -07:00
Kelvin Zhang
d7ebc10c0d Cancel polling task after component unmount
Test: th
Change-Id: I0d9058bd24236ea1e22bf91f98b2dbadc83cf8d3
2021-08-31 17:28:42 -07:00
Kelvin Zhang
694daa581f Remove noop try catch statements
Test: th
Change-Id: I5c6fcd5cdd602207e3befc3ff92137d39968c546
2021-08-31 17:28:42 -07:00
Kelvin Zhang
fd33874a47 Ignore vscode files in docker
Change-Id: I464d846c86a6c98c4be2e1993014a799ffc5d7b1
2021-08-31 17:28:42 -07:00
Kelvin Zhang
9b854aa4bf Return error in json
Test: th
Change-Id: Ie9ef8e2bac6447bdc1bf40dcb2b5731b57b47f77
2021-08-31 17:28:42 -07:00
Kelvin Zhang
2ea0bfceb0 Delegate choice of output file path to 1 place in code
Test: th
Change-Id: Ib7b02d5ce4335594b6ca625d850e7176dbdb4f8e
2021-08-31 17:28:42 -07:00
Priyanka
33e83224cc Display tags/errors on all timelines.
Remove tag filtering so that tags and errors display on global, focused
and targeted timelines regardless of the specific trace they are
associated with. Tooltip says `SF only` or `WM only` as appropriate.

Bug: b/198292279

Test: upload one of the sample traces and check that changing the nav
options does not affect the display of the tags/errors.

Change-Id: If73ce2a5529b91a5496d865c9260a8661e6241c3
2021-08-31 18:28:26 +00:00
Pablo Gamito
df07a104c1 Make search bar buttons clearer
Search button moved next to input box so it isn't confused with a title

Search modes bar moved to top and labeled so it isn't confused with a search action button

Change-Id: I1cfcbf1b982cc4b1b4ded1394964b388715c7a68
2021-08-31 15:51:21 +00:00
Treehugger Robot
dcda9e7c37 Merge "Stop hardcoding a keypath in OTA generator" am: f1a77506eb am: cb2bd4fb80 am: 2399efab64 am: 6ead11dd5a am: b5f586140c
Original change: https://android-review.googlesource.com/c/platform/development/+/1811896

Change-Id: I282b9dc62b137cef22326e9ce53b70467062c7c2
2021-08-30 20:06:19 +00:00
Treehugger Robot
b5f586140c Merge "Stop hardcoding a keypath in OTA generator" am: f1a77506eb am: cb2bd4fb80 am: 2399efab64 am: 6ead11dd5a
Original change: https://android-review.googlesource.com/c/platform/development/+/1811896

Change-Id: I01ca0ed04190051a156bad7e4e9ab5f3c0416dcb
2021-08-30 19:48:38 +00:00
Treehugger Robot
cb2bd4fb80 Merge "Stop hardcoding a keypath in OTA generator" am: f1a77506eb
Original change: https://android-review.googlesource.com/c/platform/development/+/1811896

Change-Id: I1fb1e796e10ed5b31a210375c1707721735fa856
2021-08-30 18:33:13 +00:00
TreeHugger Robot
9983b94ac0 Merge "Add tabs to hide/show data views." 2021-08-27 18:21:17 +00:00
Kelvin Zhang
4993e35acf Skip non-zip files when refreshing build library
Test: th
Change-Id: I16631183c40136c4603f20e2ea07664123338da4
2021-08-27 10:53:50 -07:00
Kelvin Zhang
157e46b183 Stop hardcoding a keypath in OTA generator
Test: th
Change-Id: I6f55a36e4559d635bd6cf24fa0b4891ccd2ab9f8
2021-08-27 10:53:23 -07:00
Priyanka
faa9a67afa Add tabs to hide/show data views.
All files with data views are shown by default. Click the chevron in the
top left of the view to expand/collapse the data view.

Bug: b/197626844

Test: upload or run a trace to the x20 staging version linked on the
bug.

Change-Id: I8fdd222e3299670285466fe97f958caa537a1f7e
2021-08-27 15:57:28 +00:00
Nataniel Borges
c0a4c72fa7 Add displays to layers trace
Displays were added to the SF trace. Display the display information on Winscope

Bug: 188792659
Test: check winscope works
Change-Id: Ice1f526c4f370ca5a489063e22206101bdbd48eb
2021-08-27 11:35:42 +02:00
Pablo Gamito
b38a01fb29 Merge "Add option to press enter to search for timestamp" 2021-08-25 09:09:53 +00:00
Pablo Gamito
fb863ba404 Add option to press enter to search for timestamp
Change-Id: Idaae216df04c34cdc73e796379c5358736661010
2021-08-24 20:01:27 +02:00
TreeHugger Robot
a71ccc7104 Merge "Fix broken trace views for accessibility/IM." 2021-08-24 15:53:46 +00:00
Priyanka
c132b4643c Fix broken trace views for accessibility/IM.
Due to new UI, Accessibility Trace and IM Trace views were broken. This
CL passes values in for presentTags and presentErrors to ensure the
views display as expected.

Bug: b/197628035

Test: run a trace with all checkboxes ticked and ensure the views
display as expected.

Change-Id: Iad98ab88b0250447ead72c5bcf467f8873d25182
2021-08-24 14:50:02 +00:00
Priyanka
41cf977e9b Fix spec tests
Fixed all failing spec tests so that object transformations, diff tree
generation and proto file decoding can all be tested via yarn.

Bug: b/196210353

Test: `yarn run test`
Change-Id: Iefd41dd93d6a591756d1a60ae6e42c3b08f9d5e0
2021-08-23 16:45:27 +00:00
Priyanka
aadd3418fd Add tags/errors to trace views.
At the start or end timestamp of a transition, or at an error timestamp, colour coded tags show up
next to the relevant layer/task in the WM and SF trace hierarchy views.
Tick the transition checkbox to only show entries that have tags/errors.
Compatible with flat checkbox.

Bug: b/196544612

Test: upload the zip onto the x20 (see bug) and test above.
Change-Id: Ied84adbedc38324629c8b50178b44041f8e8b66e
2021-08-23 10:58:29 +00:00
Priyanka
0e80ea1000 Add tags and errors to focused/targeted timelines.
Extend the tag timeline display from global to specific WM/SF trace
timelines. During focused or targeted navigation, the tags/errors should display for their associated trace
only. On global navigation, the minimum start and maximum end timestamp
for each transition is displayed. In the search bar, under transitions
and errors, note that the timestamps displayed as the global start and
end.

Bug: b/197066003

Test: upload SampleWinscope.zip from bug and test the different
navigation types.

Change-Id: Id273bf77425c504d943f1ee9716ce2f3ad0ec9c5
2021-08-20 14:45:04 +00:00
Priyanka
e93515ef89 Add functionality to search + navigate tags/errors.
Add a searchbar to bottom of Winscope that can be used to navigate through
all the tags/transitions/errors present in a trace (integrating existing timestamp search).
Choose the desired tab to set the type of search. Typing input into the relevant search will filter the elements.
Click on the start or end timestamp in the scrollable search table to navigate to that
timestamp in the timeline. Click on a transition in the search table to navigate to the start timestamp for that transition. Click on a transition in the timeline to toggle between start and end timestamps for that transition.

Bug: b/196197875

Test: upload the traces on the bug and test the above implementations on
the x20.

Change-Id: Ib3a0fff770cc65a38e50a8d99f130752b2f98eeb
2021-08-20 14:43:55 +00:00
TreeHugger Robot
6f3098ad9c Merge "Fix flat and visible checkboxes on trace views." 2021-08-20 10:35:09 +00:00
Treehugger Robot
21ee402904 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a am: 023d8bfa44 am: 461112ec85 am: d2d3c0d4d9
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: I517e83dd918c656d679d1064265726f8c3308ce1
2021-08-19 22:05:41 +00:00
Treehugger Robot
d2d3c0d4d9 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a am: 023d8bfa44 am: 461112ec85
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: I5170fb8ea6a2a5d223aff85212e13098f7bbc0d6
2021-08-19 21:51:15 +00:00
Treehugger Robot
4976675e9a Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: Idb3bc4cbff66d8bd9c410cf5225bb9c1f7dac04a
2021-08-19 21:01:12 +00:00