Commit Graph

2733 Commits

Author SHA1 Message Date
Eino-Ville Talvala
6a65b38d23 Idegen: Don't assume a backslash is preceded by a space
Only remove a backslash, nothing more. Otherwise a line with just
a backslash will cause a crash.

Bug: 28218145
Change-Id: I540a2508ba1fbd3f03cf8258d1fe4b99e0472c88
2016-04-15 14:06:53 -07:00
Elliott Hughes
39a86fa08f Remove dead translations.
This tool has moved to bootable/recovery.

Bug: http://b/27837319
Change-Id: Icc91e8a6fca4ccbc3f55afb3fd930c5996cd8ae9
2016-03-26 18:50:22 -07:00
Elliott Hughes
e66fdbfff7 Lose recovery_l10n to bootable/recovery, where it belongs.
Bug: http://b/27837319

(cherry picked from commit 00e91ab81b)

Change-Id: Ic483867ab37e949e9e1c9b58b2c9be049fdfc5e8
2016-03-26 08:46:25 -07:00
Geoff Mendal
b32511e86d Import translations. DO NOT MERGE
Change-Id: Ia5f1fa9731b8b6b71d6a2cdb0e23de8da7fbbca3
Auto-generated-cl: translation import
2016-03-19 03:38:30 +01:00
Maurice Lam
d513a1723f Add custom config XML support for checkstyle
Change-Id: If94dd073d7270d8fcdcf4f3041770712a193ce9e
2016-03-16 14:53:15 -07:00
Mitchell Wills
753fae1d8b Checkstyle: Allow star imports for certain classes
Bug: 27282855
Change-Id: Iab492c8b558e37af0dded33d99e309c4fd559b05
2016-02-21 12:11:32 -08:00
Aurimas Liutikas
e556d2d8cb Allow unknown JavaDoc tags to not warn about @hide.
Bug: 27208696
Change-Id: I4a23abbe2bde4aad817e5cc475d7ecc5f8af54e8
2016-02-17 14:37:06 -08:00
Neil Fuller
79c3a724b8 Switch RmTypeDefs over to asm v5
Required if it is to deal with v52 class files.

Bug: 27189914
Change-Id: I056072113d9ed0955fd248fad7ace2fc71be358a
2016-02-15 19:15:35 +00:00
Mitchell Wills
3e2dff238f Merge "Add OuterTypeFilename rule to Checkstyle" into nyc-dev 2016-02-12 01:08:22 +00:00
Mitchell Wills
e524e6070b Add OuterTypeFilename rule to Checkstyle
This also requires modifying the logic to create temporary files so that
the filename is the same as that in source tree.

Bug: 27109166
Change-Id: I73f2406d5c85d45b0b259f0fd7dd081e44df029c
2016-02-11 16:59:56 -08:00
Aurimas Liutikas
8820526415 Update the message for Checkstyle header warning.
Bug: 27137275
Change-Id: I22f2a83153726457b78a950cb524c128b506b266
2016-02-12 00:48:24 +00:00
Aurimas Liutikas
9b1ba578d7 Add new rules to Checkstyle config.
Add the following new checks:
- JavadocMethod
- MissingDeprecated
- MissingOverride
- OneTopLevelClass
- StringLiteralEquality
- ArrayTypeStyle
- RedundantModifier
- NewlineAtEndOfFile

Bug: 27051781
Change-Id: I4d34278f73ee821cd6cfea705cf949881eaebfc2
2016-02-08 22:29:03 +00:00
Aurimas Liutikas
b4214d900c Merge "Skip JavaDoc checks for Java tests classes" into mnc-ub-dev
am: c4e1082548

* commit 'c4e108254859118c985ddd05a15568170066d723':
  Skip JavaDoc checks for Java tests classes
2016-02-02 00:52:49 +00:00
Aurimas Liutikas
99451e5b13 Skip JavaDoc checks for Java tests classes
Bug: 26862656
Change-Id: I708ee552154796ece6655db8f9f3157a2e9f3ba5
2016-01-29 13:10:01 -08:00
Aurimas Liutikas
6698676cb6 Allow both (c) and (C) in the copyright header.
am: 49342a6760

* commit '49342a6760519ed9e4d08ff40ee95b80cb9e570c':
  Allow both (c) and (C) in the copyright header.
2016-01-27 18:38:02 +00:00
Aurimas Liutikas
49342a6760 Allow both (c) and (C) in the copyright header.
Bug: 26818467
Change-Id: Iec1a17ecad3e6853d318e907596ed3ae29208902
2016-01-27 10:25:18 -08:00
Aurimas Liutikas
09f18b9b01 Add support for running Checkstyle on a given SHA-1.
am: 2d59cfb992

* commit '2d59cfb99222f6099eb4bcc633fa13424cf86df9':
  Add support for running Checkstyle on a given SHA-1.
2016-01-26 01:23:30 +00:00
Aurimas Liutikas
2d59cfb992 Add support for running Checkstyle on a given SHA-1.
Usage e.g.: ./checkstyle.py -s 3aca02ca91816a86febb5ed6e380ec2122adea47

Additionally this CL adds a pre-push script that can be used a git
hook to run Checkstyle on 'repo upload'

Bug: 25852971
Change-Id: Ia00d48df80b2b024de0899d9590868016c5b7bf0
2016-01-25 17:16:28 -08:00
Aurimas Liutikas
25b5380919 Add new two new rules to Checkstyle.
am: 23e2d4b3eb

* commit '23e2d4b3ebb6995edc7363e8b9ea645f8cfbaf29':
  Add new two new rules to Checkstyle.
2016-01-25 19:34:00 +00:00
Aurimas Liutikas
23e2d4b3eb Add new two new rules to Checkstyle.
- Add Android copyright header check

- Add comment suppression filter rule to enable suppressing indentation check
Usage:
// CHECKSTYLE:OFF IndentationCheck
  Code.With();
    Bad = Indentation;
// CHECKSTYLE:ON IndentationCheck

Bug: 26747466
Change-Id: I837d7bde1fd85250678a3aba66309043bfc324b1
2016-01-25 11:25:29 -08:00
Aurimas Liutikas
4842a0b777 Checkstyle handling when all lines are deleted.
am: a0e889762d

* commit 'a0e889762d00591f51bed2bb44c7068d5abf3dfb':
  Checkstyle handling when all lines are deleted.
2016-01-22 00:04:06 +00:00
Aurimas Liutikas
a0e889762d Checkstyle handling when all lines are deleted.
It is valid to have empty modified_lines list for files
that only contain deletions. In such case we should skip
all the errors except for forced rules.

Updated the test to match the expectation.

Change-Id: I6993968b882fb6fbe2ba1f63f3b6879c3308ff34
2016-01-21 14:43:12 -08:00
Yohei Yukawa
0cc92c5011 Merge "Modify Idegen to open project with Android facet" am: b8159cc98c
am: 273207859c

* commit '273207859c732ca3233d0b90f587a4e2f7ebd54c':
  Modify Idegen to open project with Android facet
2016-01-21 05:31:21 +00:00
Yohei Yukawa
273207859c Merge "Modify Idegen to open project with Android facet"
am: b8159cc98c

* commit 'b8159cc98cc841bab655ed6361797498a6d24eab':
  Modify Idegen to open project with Android facet
2016-01-21 03:55:01 +00:00
dbgsprw
ec27ae9a22 Modify Idegen to open project with Android facet
Previously, After idegen command executed, Android Studio
and Intellij didn't start with Android facet.

Android Device Monitor, AVD, etc are necessary,
so edit template android.iml for opening project with them.

Change-Id: I7734e45afc268aa4eabdd96854c775452f8426a7
Signed-off-by: dbgsprw <dbgsprw@gmail.com>
2016-01-21 02:18:32 +00:00
Sharvil Nanavati
c682d4340e Remove C++ btsnooz parser in favor of Python script. am: de307331a2 am: cb2328e58b
am: e00b6a03ea

* commit 'e00b6a03ea63ea73d9d1a2f87d42a23b386ad2dd':
  Remove C++ btsnooz parser in favor of Python script.
2016-01-20 21:16:54 +00:00
Sharvil Nanavati
e00b6a03ea Remove C++ btsnooz parser in favor of Python script. am: de307331a2
am: cb2328e58b

* commit 'cb2328e58beb9be876e7b6557d049b972fdea2a4':
  Remove C++ btsnooz parser in favor of Python script.
2016-01-20 21:14:02 +00:00
Sharvil Nanavati
cb2328e58b Remove C++ btsnooz parser in favor of Python script.
am: de307331a2

* commit 'de307331a2c845784c200f4ed1924d8fc196ff66':
  Remove C++ btsnooz parser in favor of Python script.
2016-01-20 21:10:30 +00:00
Sharvil Nanavati
de307331a2 Remove C++ btsnooz parser in favor of Python script.
Change-Id: I5c88c8ad5f3389c54edc74295b409592fd8f85d0
2016-01-20 09:17:03 -08:00
Deepanshu Gupta
b916791be8 Update mkstubs to Java 8.
Also remove eclipse project, add intellij project and start using ASM5
API.

Change-Id: I761965fe641879a606d5ec4f0cec0781087e4c20
2016-01-08 08:48:36 -08:00
Deepanshu Gupta
3162d05475 Upgrade to ASM 5
Change-Id: I5c8bbc67017b7de49a9cb34514c087ed2f536495
2016-01-07 16:57:36 -08:00
Elliott Hughes
100586d4e4 Merge "Clean up etc1tool." am: 12b751f1f8
am: 845662e75f

* commit '845662e75fa61f633c43777e3cb5cd8e23b0260e':
  Clean up etc1tool.
2016-01-05 18:04:21 +00:00
Elliott Hughes
845662e75f Merge "Clean up etc1tool."
am: 12b751f1f8

* commit '12b751f1f8efdadf50731dd1ef6af6ac99d061cc':
  Clean up etc1tool.
2016-01-05 18:02:34 +00:00
Elliott Hughes
387b63df19 Clean up etc1tool.
Remove makefile cruft and fix all the compiler warnings.

Change-Id: I24e40143cac47a566c191f4f1ca27df7b4f55821
2016-01-05 09:34:58 -08:00
Aurimas Liutikas
c1cc994f85 Update Checkstyle rules to better match the style guide.
am: 9cd6eaacba

* commit '9cd6eaacba601ce443d9d1fc3573f876a778af35':
  Update Checkstyle rules to better match the style guide.
2015-12-19 01:27:39 +00:00
Aurimas Liutikas
9cd6eaacba Update Checkstyle rules to better match the style guide.
- Correct import order.

Bug: 25852971

Change-Id: I6addc06f7bb91df3d9d011807b5688b5aeba0a0d
2015-12-18 15:10:14 -08:00
Aurimas Liutikas
6b82b75c69 Allow to run checkstyle with untracked files present.
Additionally, this CL adds basic tests.

Bug: 25852971

Change-Id: Ia8a62e0d49428e1d933d2cef832c977e62f9c614
(cherry picked from commit 55e7480eff)
2015-12-18 00:54:02 +00:00
Aurimas Liutikas
4e8bad8045 Fix a crash when a brand new file is added.
Checkstyle.py was not handling additions of new files resulting in
a crash. For new files git.modified_lines() returns None. Added code
handles that case.

Bug: 25852971
Change-Id: I91e2b8c92581ec9e89bcbbcd2d274f56c791f3a9
(cherry picked from commit 5b87dbad0c)
2015-12-18 00:53:20 +00:00
Aurimas Liutikas
1fc79c2192 Add a script that allows developers to run checkstyle.
Allow developers to run Java style check in two ways.

Specific file:
checkstyle.py -f path/to/file/View.java

Lines modified in the latest commit:
checkstyle.py

Review moved from https://googleplex-android-review.googlesource.com/#/c/818813/
due to move from packages/experimental to development/tools

Bug: 25852971
Change-Id: Ibcf9d80644f2938828b21e8f50ab0d6f39c286b0
(cherry picked from commit 96f27d0960)
2015-12-18 00:52:35 +00:00
Aurimas Liutikas
55e7480eff Allow to run checkstyle with untracked files present.
Additionally, this CL adds basic tests.

Bug: 25852971

Change-Id: Ia8a62e0d49428e1d933d2cef832c977e62f9c614
2015-12-17 14:55:51 -08:00
Aurimas Liutikas
e9ad0609c7 Merge "Fix a crash when a brand new file is added." 2015-12-16 17:46:39 +00:00
Geoff Mendal
f76eca584c Import translations. DO NOT MERGE
Change-Id: Icaeb108fd7c922201f18a10083651048fe670d1e
Auto-generated-cl: translation import
2015-12-16 05:16:47 -08:00
Aurimas Liutikas
5b87dbad0c Fix a crash when a brand new file is added.
Checkstyle.py was not handling additions of new files resulting in
a crash. For new files git.modified_lines() returns None. Added code
handles that case.

Bug: 25852971
Change-Id: I91e2b8c92581ec9e89bcbbcd2d274f56c791f3a9
2015-12-15 18:02:50 -08:00
Yohei Yukawa
a6b714374d Merge "Updating Idegen project to use JDK 1.7" am: 72f24a0fa1
am: f499ad0961

* commit 'f499ad096171639c013c0ec21f730ed25da34998':
  Updating Idegen project to use JDK 1.7
2015-12-15 08:17:48 -08:00
Yohei Yukawa
f499ad0961 Merge "Updating Idegen project to use JDK 1.7"
am: 72f24a0fa1

* commit '72f24a0fa1579ba837bdc7b5c605eedd6990999a':
  Updating Idegen project to use JDK 1.7
2015-12-15 16:04:50 +00:00
Yohei Yukawa
72f24a0fa1 Merge "Updating Idegen project to use JDK 1.7" 2015-12-15 05:01:56 +00:00
Yohei Yukawa
65ce0716fc Merge "Fix exception in MakeFileParser"
am: 85fad37aa7

* commit '85fad37aa7ff73341006cbb890eb80a4c5144694':
  Fix exception in MakeFileParser
2015-12-09 11:17:21 -08:00
Xiaohui Chen
0b7e903d4c Fix exception in MakeFileParser
The code currently tries to parse all "$" as variables.  Now narrow it
down to only "$()" as it should.

Bug: 23155276
Change-Id: I1732ce757a9f7d611e90138b595a0aa1d3ce6009
2015-12-08 19:03:23 -08:00
Michael
6836ddf514 Updating Idegen project to use JDK 1.7
Updating Idegen intellij template to use JDK 1.7, which is required for
marshmallow.

Change-Id: I4ad02acb19fa850a62b6a25bbbaf4db2577a9fe0
2015-12-06 13:54:56 +01:00
Aurimas Liutikas
96f27d0960 Add a script that allows developers to run checkstyle.
Allow developers to run Java style check in two ways.

Specific file:
checkstyle.py -f path/to/file/View.java

Lines modified in the latest commit:
checkstyle.py

Review moved from https://googleplex-android-review.googlesource.com/#/c/818813/
due to move from packages/experimental to development/tools

Bug: 25852971
Change-Id: Ibcf9d80644f2938828b21e8f50ab0d6f39c286b0
2015-11-25 15:10:01 -08:00