Commit Graph

26919 Commits

Author SHA1 Message Date
Nataniel Borges
31e6237fdb Display only elements actually visible on the screen as "Visible"
Use the visibleRegion property to determine if a layer is visible on
the screen or not. Elements may have a size and a crop but be displayed
below another.

While the visible option cannot be used to render the elements due to
transforms, it only has a value if the element is displayed on the
screen.

Note that elements may still not appear on the screen as all their
visible regions are below the screen (right < 0 or bottom < 0)

Test: Open trace in winscope, check if only layers visible on the screen have a visible chip and are displayed.
Merged-In: I75137a5057a5bda96db887b110b053e64b49f885
Change-Id: I75137a5057a5bda96db887b110b053e64b49f885
2019-06-18 12:57:19 +00:00
Nataniel Borges
38a1bf9a7b Display SF layer based on size, crop & parent instead of buffer size
It is no longer possible to use only the size property because Color
layers do not set a buffer size.

Use the following rule to highlight the selected layers on the UI:
- If the layer has a size and a crop, use their intersection.
- Else, if the layer has no size, but has crop, use the crop as size
- Else, use the parent size

Bug: 121198524
Test: Open trace in winscope, select visible layer, check if highlighted
Merged-In: I55298f20efa31830097a41d45d8d8b1c6b4ed2e6
Change-Id: I55298f20efa31830097a41d45d8d8b1c6b4ed2e6
2019-06-18 12:57:11 +00:00
Vishnu Nair
f27cb3c0b4 WinScope: Support boundless surfaces in WinScope
SurfaceFlinger trace relies on Display Root#0 layer size to set the display bounds. This layer will
no longer have a size once b/114413815 is fixed. Instead, sf transform will set the bounds to undefined and the
bounds be calculated to be the union of the layer sizes.
see: http://x20web/teams/android-window-manager/winscope/winscope-staging-vishnun.html
Bug: 114413815
Test: build winscope and open trace

Merged-In: Ic04d524f0e095374321ef818f0d0ff420a2d3827
Change-Id: Ic04d524f0e095374321ef818f0d0ff420a2d3827
2019-06-18 12:57:04 +00:00
Vishnu Nair
38ed9eb5d7 Winscope: Use a unique stableId for all layers and wm entries
Top level of the hierarchy contains the entry with a timestamp. When
navigating the timeline with arrow keys, entry loses focus since
the timestamp changes.

See: https://android-window-manager.teams.x20web.corp.google.com/winscope/winscope-staging-vishnun.html

Test: Open trace in winscope, click on entry & navigate timeline with arrow keys
Merged-In: Ifbd88da717354c66d96a05d25a9d619fa5209e26
Change-Id: Ifbd88da717354c66d96a05d25a9d619fa5209e26
2019-06-18 12:56:57 +00:00
Adrian Roos
80ad0baa5b Winscope: keep backwards compatibility prior to windowFrames
We should still be able to properly render traces taken prior to the WindowFrames
refactor - if the property is not available, use the legacy property instead.

Test: yarn run dev
Merged-In: Ie10f7d14ac5673e8be844d2d5a4fa752d502b9df
Change-Id: Ie10f7d14ac5673e8be844d2d5a4fa752d502b9df
2019-06-18 12:56:49 +00:00
chaviw
c3ab197057 Use windowFrames.frame instead of frame to draw the area.
The code is changed so the frame protobuf is now under another class
called windowFrames. Update the js code so it can properly draw the
frame with the new code change.

Test: Ran on localhost with updated protobuf file
Bug: 111359087
Merged-In: I072daae54601120de5b6eaa0a64ee7c3096e4a43
Change-Id: I072daae54601120de5b6eaa0a64ee7c3096e4a43
2019-06-18 12:56:42 +00:00
Kevin DuBois
d8fcba313b Winscope: fix .pb location for sf traces
Trace location was incorrect. Changing to correct location.

Test: run capture_sf_trace.sh, upload to winscope, see trace

Merged-In: Ia84501014e6cf83d2fb1d167c1a7aac8b64a06d4
Change-Id: Ia84501014e6cf83d2fb1d167c1a7aac8b64a06d4
Fixes: b/110715663
2019-06-18 12:56:35 +00:00
Adrian Roos
a6e652ac81 Winscope: apply surface transforms in preview
Test: capture surface trace of screen rotation animation, verify it shows correctly.
Merged-In: Ia9528401a0d8542266a7898be6d032a6cf166946
Change-Id: Ia9528401a0d8542266a7898be6d032a6cf166946
2019-06-18 12:56:27 +00:00
Vishnu Nair
1a59a9b592 WinScope: Show IME windows
Test: Check trace with IME windows shown

Merged-In: If69e1bc340c0c79a5fb07385cc6921dd093e8fc2
Change-Id: If69e1bc340c0c79a5fb07385cc6921dd093e8fc2
2019-06-18 12:56:16 +00:00
Adrian Roos
2af3a86382 WinScope: Properly show child windows.
Merged-In: I188bb2c327bc61c309f7e3e3746f0af4241a94a9
Change-Id: I188bb2c327bc61c309f7e3e3746f0af4241a94a9
2019-06-18 12:51:23 +00:00
Paul Duffin
e49b5bd4a1 Merge "Switch from no_standard_libs:true to sdk_version:"none"" am: c581ff5e7d
am: c661f9e765

Change-Id: I9859327649e0a597d902e944e8749fbbada411d6
2019-06-17 03:19:23 -07:00
Paul Duffin
c661f9e765 Merge "Switch from no_standard_libs:true to sdk_version:"none""
am: c581ff5e7d

Change-Id: I9e5626a6ac2c9e4efc11e49e680b0995c881bf11
2019-06-17 03:12:29 -07:00
Paul Duffin
c581ff5e7d Merge "Switch from no_standard_libs:true to sdk_version:"none"" 2019-06-17 09:57:12 +00:00
Jeongik Cha
062f2b09ca system and product image diff tool
This tool compares system and product image across models, and generate
common.csv and diff.csv

Here is example output
- common.csv:
filename, sha1sum, targets
/system/a, da39a3ee5e, a;b;c

- diff.csv:
filename, sha1sum, targets
/system/b, da39a3ee5e, a;b
/system/c, 3f786850e3, a
/system/c, 89e6c98d92, b;c

Bug: 131273025
Test: m system_product_image_diff
Test: system_product_image_diff -t model1 model2 -s system product

Change-Id: Ie9cc368e0a6d26e956f1e27ebe683bea5e80465c
2019-06-14 15:15:38 +09:00
Weilun Du
83caa43303 Merge "[Advanced Features] Change the source location of advancedFeatures.ini" am: 08a2bdae08
am: e1b1481200

Change-Id: Ie9ea74febab0d5d547694ebc92a7b04d5b1b7906
2019-06-13 14:01:36 -07:00
Weilun Du
e1b1481200 Merge "[Advanced Features] Change the source location of advancedFeatures.ini"
am: 08a2bdae08

Change-Id: I10dde63b850f10d187459345b19ef860009aaa37
2019-06-13 13:53:13 -07:00
Treehugger Robot
08a2bdae08 Merge "[Advanced Features] Change the source location of advancedFeatures.ini" 2019-06-13 20:38:26 +00:00
Weilun Du
c1084c0534 [Advanced Features] Change the source location of advancedFeatures.ini
Copy advancedFeatures.ini file from
device/generic/goldfish/data/etc, which is the centralized place for
advancedFeatures.ini.

BUG: 135187406

Change-Id: Ib1d2ec2f91d66dde89bc4a884cd99dbb1a2c83cb
Signed-off-by: Weilun Du <wdu@google.com>
2019-06-13 09:57:42 -07:00
Paul Duffin
df0d7dfff1 Switch from no_standard_libs:true to sdk_version:"none"
The no_standard_libs property is deprecated in favor of
sdk_version:"none" as the latter is simpler and less error prone.

Bug: 134566750
Test: m droid
Change-Id: I410e4b98481cec1a5512cd138f735038a725287b
2019-06-13 10:22:17 +01:00
Ryan Prichard
1415cbdc4e Merge "gdbclient: support various PT_INTERP values" am: 87001e7ad7
am: 018cac60a1

Change-Id: I673ceecb5e52f513fecfa7643f03435ae6ef6ae1
2019-06-12 13:13:04 -07:00
Ryan Prichard
018cac60a1 Merge "gdbclient: support various PT_INTERP values"
am: 87001e7ad7

Change-Id: Ie458ea079fb161d98895b515a940b34d81473815
2019-06-12 13:05:56 -07:00
Ryan Prichard
87001e7ad7 Merge "gdbclient: support various PT_INTERP values" 2019-06-12 19:40:19 +00:00
Ryan Prichard
5d1c3cb157 gdbclient: support various PT_INTERP values
gdb looks for an executable's dynamic linker using the PT_INTERP setting
from the executable. That value can be various things:
 - /system/bin/linker[64]
 - /system/bin/linker_asan[64]
 - /system/bin/bootstrap/linker[64]

Currently, only the bootstrap linker is available in the sysroot/symbols
directory. The ordinary and ASAN linkers are symlinks on the target and
are missing from the sysroot (aka symbols) directory.

Use the executable's PT_INTERP value to find the symbolized linker binary
and add it to the solib search path. If necessary, copy or pull a linker
binary.

Test: gdbclient.py -r ls
  "info sharedlib" shows $OUT/symbols/apex/com.android.runtime.debug/bin/linker64

Test: gdbclient.py -r /data/nativetest64/bionic-unit-tests/bionic-unit-tests
  "info sharedlib" shows $OUT/symbols/system/bin/bootstrap/linker64

Test: m asan_test
  gdbclient.py -r /data/nativetest64/asan_test/asan_test
  "info sharedlib" shows /tmp/gdbclient-linker-HunVs9/linker_asan64

Bug: http://b/134183407
Change-Id: I7f79943dcd9ec762d1aaf21178bb6ab3eff40617
2019-06-11 16:07:37 -07:00
android-build-team Robot
1f00df31fe Snap for 5645017 from 069416d1f3 to qt-release
Change-Id: Ia0b6e23f69ee3885f9d0fd99525ad575ee889e02
2019-06-08 23:15:42 +00:00
Raju Kulkarni
f94d2ab9f5 Bumping version number for Beta 5 Bug: 134763660 Test: N/A
am: 069416d1f3

Change-Id: I46c8374a4c652db4ffcd6f19e4f864fdd42d3344
2019-06-07 18:48:18 -07:00
Josh Gao
c5030bc2aa Merge "Increment platform-tools version." am: 3a5fc22f69
am: 6eb2d6ef45

Change-Id: Ia3287fa66cddb84877318739da6c97a1eab9fc93
2019-06-07 15:56:11 -07:00
Josh Gao
6eb2d6ef45 Merge "Increment platform-tools version."
am: 3a5fc22f69

Change-Id: I4f8f4bcdd717d841e0c44308db379485dcff4286
2019-06-07 15:51:06 -07:00
Josh Gao
3a5fc22f69 Merge "Increment platform-tools version." 2019-06-07 22:37:46 +00:00
Raju Kulkarni
069416d1f3 Bumping version number for Beta 5
Bug: 134763660
Test: N/A

Change-Id: Ib2ccf36e7aa0e02132ccc1f8861115d8f58091ca
2019-06-07 14:51:56 -07:00
Josh Gao
a67ca6c28e Increment platform-tools version.
Change-Id: Id21f55d004d642d9efc53c2b5b43f03a5d4b86b0
Test: none
2019-06-07 12:42:47 -07:00
Bob Badour
fe5ea80069 Merge "Clarify license terms for Romain Guy's artwork." am: d7645b2b82
am: 3842f20b1c

Change-Id: I0ea0efa3a110440b00390d1a308312a2ed104593
2019-06-05 21:23:19 -07:00
Bob Badour
3842f20b1c Merge "Clarify license terms for Romain Guy's artwork."
am: d7645b2b82

Change-Id: I2495f6b5019d1c6112d8c4cf00498f1d1fa48f61
2019-06-05 20:39:16 -07:00
Treehugger Robot
d7645b2b82 Merge "Clarify license terms for Romain Guy's artwork." 2019-06-06 02:20:38 +00:00
Bob Badour
9a78b7eea4 Clarify license terms for Romain Guy's artwork.
As discussed with Romain Guy in the email thread, the Apache 2.0
license applies to the affected .jpg files now and retroactively from
the time of import.

Each of the images was altered using the exiftool:

exiftool -URL=http://www.apache.org/licenses/LICENSE-2.0 \
    -WebStatement=http://www.apache.org/licenses/LICENSE-2.0 \
    -UsageTerms='Apache License Version 2.0'

Change-Id: I9843a8f9b285799cc28e824167cbe0f14e4e651e
2019-06-05 22:19:33 +00:00
Bob Badour
3bdea97ab6 Merge "Clarify license terms for Romain Guy's artwork." am: 0e3bcf70c5
am: bcd745dddc

Change-Id: I330e55df545251008c1940ec9b22732799de7fc5
2019-06-05 14:59:37 -07:00
Bob Badour
bcd745dddc Merge "Clarify license terms for Romain Guy's artwork."
am: 0e3bcf70c5

Change-Id: I41aa58ddb9a21ff4c8278e251af34a89783f60ae
2019-06-05 14:47:56 -07:00
Treehugger Robot
0e3bcf70c5 Merge "Clarify license terms for Romain Guy's artwork." 2019-06-05 21:31:53 +00:00
Bob Badour
d41e5f7851 Clarify license terms for Romain Guy's artwork.
As discussed with Romain Guy in the email thread, the Apache 2.0
license applies to the affected .jpg files now and retroactively from
the time of import.

Each of the images was altered using the exiftool:

exiftool -WebStatement=http://www.apache.org/licenses/LICENSE-2.0

Change-Id: I557d0129617164209a3eec7ec2d228f266643ca0
2019-06-05 20:08:08 +00:00
Logan Chien
caa8e1952b Merge changes I6eb07d50,I15cc1568,I70b7132f am: 3bca85a1e3
am: 5260d9aa63

Change-Id: Ia639f137d600c42c245b0925b638b3e5499c4144
2019-06-03 11:59:30 -07:00
Logan Chien
5260d9aa63 Merge changes I6eb07d50,I15cc1568,I70b7132f
am: 3bca85a1e3

Change-Id: I2594675e73f681b74c560cdec3e01e266d871c0c
2019-06-03 11:52:44 -07:00
Logan Chien
3bca85a1e3 Merge changes I6eb07d50,I15cc1568,I70b7132f
* changes:
  def-tool: Do not emit errors on public.libraries.txt
  def-tool: Support product and product_services partition
  def-tool: Remove a dead argument (cont)
2019-06-03 18:33:45 +00:00
Logan Chien
bc1bfb3d61 def-tool: Do not emit errors on public.libraries.txt
This commit skips the errors that are caused by the access from apps (on
vendor or product partitions) to shared libraries described in
`/{system,vendor}/etc/public.libraries.txt`.

Bug: 110184925
Test: ./vndk_definition_tool.py check-dep \
      --system ${ANDROID_PRODUCT_OUT}/system \
      --vendor ${ANDROID_PRODUCT_OUT}/vendor \
      --product ${ANDROID_PRODUCT_OUT}/product \
      --tag-file datasets/eligible-list-XX.csv
Change-Id: I6eb07d500d0a625c74cde402ae06a351cad4400b
2019-06-03 09:39:40 -07:00
Logan Chien
07a6f6043a def-tool: Support product and product_services partition
This commit adds initial support to `product` and `product_services`
partitions.

Test: ./tests/run.sh
Change-Id: I15cc1568c880cc783eed6d22fec288246305b66c
2019-05-31 15:41:17 -07:00
Logan Chien
bb67f1be66 def-tool: Remove a dead argument (cont)
This commit removes a dead argument.  This fixes a regression caused
by a related CL earlier.

Test: ./vndk_definition_tool.py deps-insight \
      --system ${ANDROID_PRODUCT_OUT}/system \
      --vendor ${ANDROID_PRODUCT_OUT}/vendor \
      --product ${ANDROID_PRODUCT_OUT}/product
Change-Id: I70b7132f8c0679bd1cd934bae1066d1f127304f8
2019-05-31 15:41:13 -07:00
Logan Chien
41db049775 Merge changes Icf78c709,Ic7ec11ab,Ie5c9d31e,Ia935bac4 am: 2742062a6d
am: ecc920a9a4

Change-Id: I47dd69f960b63bcee133f23d9b61c6e028693739
2019-05-30 10:22:41 -07:00
Logan Chien
ecc920a9a4 Merge changes Icf78c709,Ic7ec11ab,Ie5c9d31e,Ia935bac4
am: 2742062a6d

Change-Id: I7313524cb51288925345628d2d69b62a83f7c449
2019-05-30 10:15:41 -07:00
Logan Chien
2742062a6d Merge changes Icf78c709,Ic7ec11ab,Ie5c9d31e,Ia935bac4
* changes:
  def-tool: Rename FWK to SYSTEM and VND to VENDOR
  def-tool: Skip dex test if smali cannot be found
  def-tool: Rename *-Indirect to *-Private
  def-tool: Remove dead arguments
2019-05-30 17:00:16 +00:00
Logan Chien
27a1e5f188 def-tool: Rename FWK to SYSTEM and VND to VENDOR
This commit replaces abbrevations to full names, e.g. FWK-ONLY to
SYSTEM-ONLY and VND-ONLY to VENDOR-ONLY.

Test: ./tests/run.sh
Change-Id: Icf78c7097535ddff40f71a986501858936574f25
2019-05-29 15:33:30 -07:00
Logan Chien
d1f580a014 def-tool: Skip dex test if smali cannot be found
This commit skips dex test cases if the `smali` command cannot be found
from the path.  Before this commit, the test was not skipped because the
`subprocess.checked_call()` throws `OSError` (instead of `IOError`) in
Python 2.

Test: ./tests/run.sh
Change-Id: Ic7ec11ab9d9de2294132d88a2b084ef11dd01c87
2019-05-29 11:22:35 -07:00
Logan Chien
6efcbbd370 def-tool: Rename *-Indirect to *-Private
Test: ./tests/run.sh
Change-Id: Ie5c9d31e1211eb36a9f4362518947ebbbc3dcdda
2019-05-29 11:22:31 -07:00