Commit Graph

2777 Commits

Author SHA1 Message Date
Aurimas Liutikas
ecef09bfa1 Remove checkstyle from development/checkstyle.
Checkstyle was moved to prebuilts/checkstyle as it is a better
place for a prebuilt jar. All the usages of checkstyle.py in
PREUPLOAD.cfg files has been updated to use the correct checkstyle
and this change should not affect anyone.

Bug: 33078621
Test: none
Change-Id: Ib2e4272a4bea7d16cccdebaeb407acbd7193f248
2017-01-12 18:34:00 -08:00
Yigit Boyar
e6aa64fdad Add androidTest to test folder names.
This conforms the docs here:
http://tools.android.com/tech-docs/new-build-system/user-guide

Change-Id: I6d91073924f578e813986f458b391c9b1dcf923c
2016-12-07 17:30:49 -08:00
Aurimas Liutikas
453a71d710 Merge "Support for ignore checkstyle files" 2016-12-07 23:49:34 +00:00
Yigit Boyar
99f3d7af24 Support for ignore checkstyle files
This CL extends checkstyle check to search for IGNORE_CHECKSTYLE
files in folders which marks them as excluded from checkstyle,
including their sub folders

Change-Id: Id2390bb2a92e03f49c0014888e21549279e4bab6
2016-12-07 10:27:35 -08:00
Alan Viverette
50fb0a915b Allow passing custom checks to checkstyle
Bug: 32998581
Change-Id: Icf349a8ff47ebc434958b872f5729b126e67bcbb
2016-12-05 12:44:23 -05:00
Aurimas Liutikas
fff72bd810 Merge "Removing pre-push.py git hook for checkstyle." 2016-11-30 22:02:31 +00:00
Paul Duffin
f171d02a9b Use junit-host instead of junit
Bug: 30188076
Test: make checkbuild
Change-Id: I81cbfc9d380576442d8877b61a25c4dc5ac62205
2016-11-29 11:04:58 +00:00
Aurimas Liutikas
1253b5accf Loosen up the checks for test class paths in Checkstyle.
This change allows us to skip javadoc checks for such test directories:
- cts/tests/tests/
- /test/src/

Test: none
Change-Id: I6a3bedaed816a3e764ca7e66ee364cd30e16c55b
2016-11-22 14:51:02 -08:00
Aurimas Liutikas
0f2de36ee9 Reland allowing MockitoAnnotations.* as static import.
It was originally added internally in ag/1085881, but then got
reverted via merge when android-styles.xml got split into multiple
files in r.android.com/305437

Bug: None
Test: None
Change-Id: I08bde16212c563a8d43995a97ffe47b2c43ed952
2016-11-18 17:12:12 -08:00
Aurimas Liutikas
44b6f1092b Removing pre-push.py git hook for checkstyle.
Checkstyle is now invoked using repo upload hooks and this script
is no longer needed.

Test: None
Change-Id: I2cdf38cc84c9f65efad76df1d58a5261b954fca8
2016-11-18 17:08:20 -08:00
Aurimas Liutikas
36824c93ee Split android-style.xml into modules for checkstyle.
This will allow teams to reuse parts of checkstyle without having
to worry about missing any checks when they change in the main configs.

Bug: None
Test: Tested locally and checkstyle still verifies the same rules using android-style.xml
Change-Id: I91ca11d3d7089db656bc640549bd7012284a8859
2016-11-18 15:55:15 -08:00
Aurimas Liutikas
2ae3a31c44 Skip all the ckecks for test data files.
Test: None
Change-Id: I492f1c7f97455fa08f135b375db7abb9d734c4b7
2016-11-10 13:36:31 -08:00
Aurimas Liutikas
e847694a3d Print the project name if available when running Checkstyle.
Add [project/foo/bar] to the beginning of each Checkstyle error line
if the REPO_PROJECT environmental variable is set (set by repo hooks).

Test: manually attempted to run checkstyle.
Change-Id: I8ccf76d9ce9306668109029267081924300cb6ce
2016-11-03 09:45:33 -07:00
Aurimas Liutikas
e9eaf62130 Correct the previous patch for test file subpaths in Checkstyle.
Instead of /tests/* allow /src/test/* subpath to be marked as test code.

Test: None
Change-Id: I6e9699a34de6d2bc167afa80539949be5a6a8907
2016-11-02 17:32:34 -07:00
Aurimas Liutikas
5a4c535344 Expand the allowed subpaths for test directories.
Include /test/* in addition to /tests/*.

Test: None
Change-Id: I3f09596cfe97c40bb3c30288de2e6696c4a5725b
2016-11-02 16:00:01 -07:00
Aurimas Liutikas
794494e88f Add tests/test-data/ to test file list for Checkstyle
This will skip javadoc checks for Java files in tests/test-data.

Bug: None
Test: None
Change-Id: I517f7d28d49e66c6c7029787e377fbbfe6df8154
2016-10-28 10:08:35 -07:00
Aurimas Liutikas
21b3a7463b Add file whitelisting capabilities to checkstyle.py
Certain projects might want to enable checkstyle gradually so
we need a way to whitelist which files should be checked.

Test: added test_FilterFiles
Change-Id: I501677ce824f882ccb5f2ad129af8f596d01c6e8
2016-10-11 13:52:46 -07:00
Aurimas Liutikas
b40478c7fa Disable Checkstyle checks on auto-generated files.
Add a check to ignore changes to automatically generated classes.

Bug: None
Test: Tried to run checkstyle locally on a file that containted the comment
      and checkstyle script showed no warnings even though that file had issues.
Change-Id: If9085948f1c224dbb53255b2ba1601511ef769dd
2016-09-20 16:46:12 -07:00
Aurimas Liutikas
fc518c714c Do not warn about uncommited files if sha is set explicitly.
Bug: 31603810
Test: Added test_GetModifiedFilesUncommittedExplicitCommit, all tests pass
Change-Id: I953f22df5be8030fc8a7145531026220c97a8dd8
2016-09-20 10:23:34 -07:00
Aurimas Liutikas
0b77686215 Allow missing method Javadocs for test classes in Checkstyle.
Bug: None
Test: Existing test_ShouldSkip will test this as it is using
      checkstyle.SKIPPED_RULES_FOR_TEST_FILES

Change-Id: I56c8c86a36f93b6b72a87fd97b75e5233fde9077
2016-09-20 10:19:48 -07:00
Alex Klyubin
0684d848fb Merge "Switch from SHA-1 to SHA-256 for new signing key certs." am: 574ad2ec86
am: b2e8ea51a9

* commit 'b2e8ea51a9200af1c7ff7aa75f2fc0e3cf6e6843':
  Switch from SHA-1 to SHA-256 for new signing key certs.

Change-Id: Ieb51183816a46c7697ccbcf9854ce485e885abb1
2016-05-06 19:41:32 +00:00
Alex Klyubin
574ad2ec86 Merge "Switch from SHA-1 to SHA-256 for new signing key certs." 2016-05-06 19:25:25 +00:00
Eino-Ville Talvala
6e854fb335 Idegen: Don\'t assume a backslash is preceded by a space
am: 6a65b38

* commit '6a65b38d23d41f59b03d91b2e0d23038b9a56439':
  Idegen: Don't assume a backslash is preceded by a space

Change-Id: Ib0fb4f5415e5002c84511653bc1dfcaafd5070d6
2016-04-15 22:44:11 +00:00
Eino-Ville Talvala
6a65b38d23 Idegen: Don't assume a backslash is preceded by a space
Only remove a backslash, nothing more. Otherwise a line with just
a backslash will cause a crash.

Bug: 28218145
Change-Id: I540a2508ba1fbd3f03cf8258d1fe4b99e0472c88
2016-04-15 14:06:53 -07:00
Elliott Hughes
4df2affeb1 Remove dead translations.
am: 39a86fa

* commit '39a86fa08f72e815c04db853ed88486656a95198':
  Remove dead translations.
2016-03-27 15:43:14 +00:00
Elliott Hughes
39a86fa08f Remove dead translations.
This tool has moved to bootable/recovery.

Bug: http://b/27837319
Change-Id: Icc91e8a6fca4ccbc3f55afb3fd930c5996cd8ae9
2016-03-26 18:50:22 -07:00
Elliott Hughes
fc9af66183 Merge "Remove yuv420sp2rgb."
am: 34874d7

* commit '34874d7a867a9f85d64d982ba86d707824d8003e':
  Remove yuv420sp2rgb.
2016-03-26 16:48:11 +00:00
Elliott Hughes
e2911592da resolve merge conflicts of 1aff55c to nyc-dev-plus-aosp
Change-Id: I21808f7a212b4be8bfb8d3ddf0a0612b18911867
2016-03-26 09:44:22 -07:00
Elliott Hughes
34874d7a86 Merge "Remove yuv420sp2rgb." 2016-03-26 16:09:23 +00:00
Elliott Hughes
e66fdbfff7 Lose recovery_l10n to bootable/recovery, where it belongs.
Bug: http://b/27837319

(cherry picked from commit 00e91ab81b)

Change-Id: Ic483867ab37e949e9e1c9b58b2c9be049fdfc5e8
2016-03-26 08:46:25 -07:00
Elliott Hughes
1aff55c947 Merge "Lose recovery_l10n to bootable/recovery, where it belongs." 2016-03-26 15:45:24 +00:00
Elliott Hughes
00e91ab81b Lose recovery_l10n to bootable/recovery, where it belongs.
Bug: http://b/27837319
Change-Id: I13de34390338ba4c420a7ff6cc8e6d3858038f28
2016-03-26 08:43:08 -07:00
Dan Willemsen
15348ea4aa Merge "Replace custom rules, remove ACP"
am: a279b12

* commit 'a279b12905f31231a8f3c36c52abcd1224449c1a':
  Replace custom rules, remove ACP
2016-03-23 22:02:06 +00:00
Dan Willemsen
f230a38299 Replace custom rules, remove ACP
A few LOCAL_ADDITIONAL_DEPENDENCIES were required, where
LOCAL_REQUIRED_MODULES would be nicer, but you can't require a module of
the same name. It would create a dependency loop with the current
require implementation, so it's filtered by the build system.

Also translate monkey from ALL_PREBUILTS to a prebuilt like the rest of
the tools. This doesn't change anything, since 'monkey' is already in
build/target/product/base.mk.

ACP is being removed, so use the standard build system macros to copy
files.

Change-Id: I4f73c6b35c0d7ae25467145b0a9d5c32ba4578d2
2016-03-23 13:22:38 -07:00
Elliott Hughes
89f8743783 Remove yuv420sp2rgb.
Hasn't been touched since cupcake, and only builds if you're targeting 32-bit
ARM, which no target still does anyway.

Change-Id: I6860a34c72c21ca7e04df288631a8950732b2e97
2016-03-22 21:13:28 -07:00
Geoff Mendal
b32511e86d Import translations. DO NOT MERGE
Change-Id: Ia5f1fa9731b8b6b71d6a2cdb0e23de8da7fbbca3
Auto-generated-cl: translation import
2016-03-19 03:38:30 +01:00
Maurice Lam
5baa0bf544 Merge "Add custom config XML support for checkstyle" into nyc-dev
am: f98b371

* commit 'f98b3710206d5fa58a8914bf05bf649cb85d1239':
  Add custom config XML support for checkstyle
2016-03-17 17:32:00 +00:00
Maurice Lam
d513a1723f Add custom config XML support for checkstyle
Change-Id: If94dd073d7270d8fcdcf4f3041770712a193ce9e
2016-03-16 14:53:15 -07:00
Dan Willemsen
655aeacf34 Merge "Remove unused libhost dependency" am: 360bff6959
am: 2f3ee5f0a5

* commit '2f3ee5f0a5cf5ca51d5233bb0ce1470ba859599b':
  Remove unused libhost dependency
2016-03-01 16:38:57 +00:00
Dan Willemsen
2f3ee5f0a5 Merge "Remove unused libhost dependency"
am: 360bff6959

* commit '360bff69598661c8aee6a236d87e2f68576eb7eb':
  Remove unused libhost dependency
2016-03-01 04:59:05 +00:00
Dan Willemsen
0877623830 Remove unused libhost dependency
Change-Id: I5999c1076ca0bce7a7ee91a0c533d99e639062c9
2016-02-29 19:56:40 -08:00
Baligh Uddin
39eb80b297 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 27293916
Change-Id: I7cc8fcb40692858d637e967ca524dea0efc06f4a
2016-02-23 08:38:49 -08:00
Mitchell Wills
753fae1d8b Checkstyle: Allow star imports for certain classes
Bug: 27282855
Change-Id: Iab492c8b558e37af0dded33d99e309c4fd559b05
2016-02-21 12:11:32 -08:00
Neil Fuller
602245b028 Merge "Switch RmTypeDefs over to asm v5"
am: 611120adfd

* commit '611120adfd390a98a1ffab89a6b20d1be589edf6':
  Switch RmTypeDefs over to asm v5
2016-02-18 18:22:43 +00:00
Neil Fuller
1388ea2a6c Switch RmTypeDefs over to asm v5
Required if it is to deal with v52 class files.

Bug: 27189914
(cherry-picked from commit 79c3a724b8)

Change-Id: I8647dd7807a153457e5af5ff13a414af853057ab
2016-02-18 11:53:07 +00:00
Aurimas Liutikas
e556d2d8cb Allow unknown JavaDoc tags to not warn about @hide.
Bug: 27208696
Change-Id: I4a23abbe2bde4aad817e5cc475d7ecc5f8af54e8
2016-02-17 14:37:06 -08:00
Alex Klyubin
702ed27285 Switch from SHA-1 to SHA-256 for new signing key certs.
This is to move OTA update package verification logic for new Android
devices from SHA-1 to SHA-256.

Prior to this change the script which generates new signing keys
used SHA-1 in certificates. This change switches the script from SHA-1
to SHA-256. The reason is that OTA updates are accepted only if they
are signed using the same digest algorithm as in the certificate.

Bug: 25643280
Bug: 20580998
Change-Id: I9babe85946a43697aeb4309837504aea25e26763
2016-02-17 13:19:41 -08:00
Bill Yi
d2804bb2f3 Merge commit 'fff86a9fe2069257ffc992af891ee48b2c0089ae' into HEAD 2016-02-17 09:50:16 -08:00
Neil Fuller
79c3a724b8 Switch RmTypeDefs over to asm v5
Required if it is to deal with v52 class files.

Bug: 27189914
Change-Id: I056072113d9ed0955fd248fad7ace2fc71be358a
2016-02-15 19:15:35 +00:00
Mitchell Wills
3e2dff238f Merge "Add OuterTypeFilename rule to Checkstyle" into nyc-dev 2016-02-12 01:08:22 +00:00