7cc00996e5
The key being added to respective maps which facilitate diffing of
unreferenced user defined types was earlier the linker set key. The
unique id should be used instead. This is because linker set keys for C
and C++ types can be the same, but their unique id's cannot. Thus,
having linker set keys as a key leaves open the possibility of false
type aliasing, whereas the unique id does not.
Test: python3 tests/test.py
Test: python3 tests/test.py \
MyTest.test_libc_and_cpp_with_unused_struct_and_libc_and_cpp_with_unused_cstruct;
before this change, this test fails; after this change, the test
passes.
Change-Id: I91816167a48308a8c812d01e0a09e9bb70c60b50
39 lines
754 B
Plaintext
39 lines
754 B
Plaintext
record_types {
|
|
type_info {
|
|
name: "ShouldRepro"
|
|
size: 4
|
|
alignment: 4
|
|
referenced_type: "type-1"
|
|
source_file: "/development/vndk/tools/header-checker/tests/integration/c_and_cpp/include/reproducability_c.h"
|
|
linker_set_key: "ShouldRepro"
|
|
self_type: "type-1"
|
|
}
|
|
fields {
|
|
referenced_type: "type-2"
|
|
field_offset: 0
|
|
field_name: "a"
|
|
access: public_access
|
|
}
|
|
access: public_access
|
|
record_kind: struct_kind
|
|
tag_info {
|
|
unique_id: "ShouldRepro"
|
|
}
|
|
}
|
|
builtin_types {
|
|
type_info {
|
|
name: "int"
|
|
size: 4
|
|
alignment: 4
|
|
referenced_type: "type-2"
|
|
source_file: ""
|
|
linker_set_key: "int"
|
|
self_type: "type-2"
|
|
}
|
|
is_unsigned: false
|
|
is_integral: true
|
|
}
|
|
elf_functions {
|
|
name: "repro"
|
|
}
|