97a65926d2
This change includes several refactoring:
1. Adds more function/class comments.
2. Renames the fields in namedtuples 'CheckListItem' and 'CheckResultItem'.
3. Fixes the vintf check issue. It should do two checks:
system -> vendor and vendor -> system, instead of one direction.
4. Fixes import statements, should only import module or package name.
5. Use python3-style print() function instead of print statement.
6. Fix the missing 'import errno' in image_mounter.
7. Checks *.py under 'checker' folder can pass 'pylint'.
Disables the check for a given line if it cannot pass.
e.g., pylint: disable=too-few-public-methods
8. Changes 'summary' result from a string 'pass' to '#pass/#total'.
Bug: 70253825
Test: m gsi_util
Test: gsi_util --debug check_compat --system $OUT/system.img --vendor adb
Test: gsi_util --debug check_compat --system $OUT/system.img --vendor $OUT/vendor.img
Test: gsi_util check_compat --only-summary --system $OUT/system --vendor $OUT/vendor
Test: gsi_util --debug check_compat --system adb --vendor adb vintf
Change-Id: Ia08d1fbeee62f62667876b54778489c89e4228a1
44 lines
1.3 KiB
Python
44 lines
1.3 KiB
Python
#!/usr/bin/env python
|
|
#
|
|
# Copyright 2017 - The Android Open Source Project
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
"""VINTF-related utilities."""
|
|
|
|
import logging
|
|
|
|
from gsi_util.utils import cmd_utils
|
|
|
|
|
|
def checkvintf(manifest, matrix):
|
|
"""Invokes host command 'checkvintf' to do VINTF check.
|
|
|
|
Usage of the command: checkvintf <manifest.xml> <matrix.xml>.
|
|
|
|
Args:
|
|
manifest: the manifest XML file.
|
|
matrix: the matrix XML file.
|
|
|
|
Returns:
|
|
A tuple of (result_ok, stderr).
|
|
"""
|
|
logging.debug('checkvintf %s %s...', manifest, matrix)
|
|
|
|
# Uses 'read_stdout' and 'read_stderr' to disable output.
|
|
returncode, _, stderrdata = cmd_utils.run_command(
|
|
['checkvintf', manifest, matrix],
|
|
raise_on_error=False,
|
|
read_stdout=True,
|
|
read_stderr=True)
|
|
return (returncode == 0, stderrdata)
|