This patch adds a group of testcases to check that dtc correctly rejects trees with various structural errors. To make things easier to test, we change dtc so that failing checks (as opposed to other errors) result in exit code 2. This patch also fixes an embarrasing bug uncovered by these new tests: check_phandles() worked out if the tree's phandles were valid, then throws that information away and returns success always. Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
241 lines
6.1 KiB
C
241 lines
6.1 KiB
C
/*
|
|
* (C) Copyright David Gibson <dwg@au1.ibm.com>, IBM Corporation. 2005.
|
|
*
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
|
|
* USA
|
|
*/
|
|
|
|
#include "dtc.h"
|
|
#include "srcpos.h"
|
|
|
|
#include "version_gen.h"
|
|
|
|
/*
|
|
* Command line options
|
|
*/
|
|
int quiet; /* Level of quietness */
|
|
int reservenum; /* Number of memory reservation slots */
|
|
int minsize; /* Minimum blob size */
|
|
|
|
char *join_path(char *path, char *name)
|
|
{
|
|
int lenp = strlen(path);
|
|
int lenn = strlen(name);
|
|
int len;
|
|
int needslash = 1;
|
|
char *str;
|
|
|
|
len = lenp + lenn + 2;
|
|
if ((lenp > 0) && (path[lenp-1] == '/')) {
|
|
needslash = 0;
|
|
len--;
|
|
}
|
|
|
|
str = xmalloc(len);
|
|
memcpy(str, path, lenp);
|
|
if (needslash) {
|
|
str[lenp] = '/';
|
|
lenp++;
|
|
}
|
|
memcpy(str+lenp, name, lenn+1);
|
|
return str;
|
|
}
|
|
|
|
void fill_fullpaths(struct node *tree, char *prefix)
|
|
{
|
|
struct node *child;
|
|
char *unit;
|
|
|
|
tree->fullpath = join_path(prefix, tree->name);
|
|
|
|
unit = strchr(tree->name, '@');
|
|
if (unit)
|
|
tree->basenamelen = unit - tree->name;
|
|
else
|
|
tree->basenamelen = strlen(tree->name);
|
|
|
|
for_each_child(tree, child)
|
|
fill_fullpaths(child, tree->fullpath);
|
|
}
|
|
|
|
static void __attribute__ ((noreturn)) usage(void)
|
|
{
|
|
fprintf(stderr, "Usage:\n");
|
|
fprintf(stderr, "\tdtc [options] <input file>\n");
|
|
fprintf(stderr, "\nOptions:\n");
|
|
fprintf(stderr, "\t-h\n");
|
|
fprintf(stderr, "\t\tThis help text\n");
|
|
fprintf(stderr, "\t-q\n");
|
|
fprintf(stderr, "\t\tQuiet: -q suppress warnings, -qq errors, -qqq all\n");
|
|
fprintf(stderr, "\t-I <input format>\n");
|
|
fprintf(stderr, "\t\tInput formats are:\n");
|
|
fprintf(stderr, "\t\t\tdts - device tree source text\n");
|
|
fprintf(stderr, "\t\t\tdtb - device tree blob\n");
|
|
fprintf(stderr, "\t\t\tfs - /proc/device-tree style directory\n");
|
|
fprintf(stderr, "\t-o <output file>\n");
|
|
fprintf(stderr, "\t-O <output format>\n");
|
|
fprintf(stderr, "\t\tOutput formats are:\n");
|
|
fprintf(stderr, "\t\t\tdts - device tree source text\n");
|
|
fprintf(stderr, "\t\t\tdtb - device tree blob\n");
|
|
fprintf(stderr, "\t\t\tasm - assembler source\n");
|
|
fprintf(stderr, "\t-V <output version>\n");
|
|
fprintf(stderr, "\t\tBlob version to produce, defaults to %d (relevant for dtb\n\t\tand asm output only)\n", DEFAULT_FDT_VERSION);
|
|
fprintf(stderr, "\t-R <number>\n");
|
|
fprintf(stderr, "\t\tMake space for <number> reserve map entries (relevant for \n\t\tdtb and asm output only)\n");
|
|
fprintf(stderr, "\t-S <bytes>\n");
|
|
fprintf(stderr, "\t\tMake the blob at least <bytes> long (extra space)\n");
|
|
fprintf(stderr, "\t-b <number>\n");
|
|
fprintf(stderr, "\t\tSet the physical boot cpu\n");
|
|
fprintf(stderr, "\t-f\n");
|
|
fprintf(stderr, "\t\tForce - try to produce output even if the input tree has errors\n");
|
|
fprintf(stderr, "\t-v\n");
|
|
fprintf(stderr, "\t\tPrint DTC version and exit\n");
|
|
exit(2);
|
|
}
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
struct boot_info *bi;
|
|
char *inform = "dts";
|
|
char *outform = "dts";
|
|
char *outname = "-";
|
|
int force = 0, check = 0;
|
|
char *arg;
|
|
int opt;
|
|
FILE *inf = NULL;
|
|
FILE *outf = NULL;
|
|
int outversion = DEFAULT_FDT_VERSION;
|
|
int boot_cpuid_phys = 0xfeedbeef;
|
|
int structure_ok;
|
|
|
|
quiet = 0;
|
|
reservenum = 0;
|
|
minsize = 0;
|
|
|
|
while ((opt = getopt(argc, argv, "hI:O:o:V:R:S:fcqb:v")) != EOF) {
|
|
switch (opt) {
|
|
case 'I':
|
|
inform = optarg;
|
|
break;
|
|
case 'O':
|
|
outform = optarg;
|
|
break;
|
|
case 'o':
|
|
outname = optarg;
|
|
break;
|
|
case 'V':
|
|
outversion = strtol(optarg, NULL, 0);
|
|
break;
|
|
case 'R':
|
|
reservenum = strtol(optarg, NULL, 0);
|
|
break;
|
|
case 'S':
|
|
minsize = strtol(optarg, NULL, 0);
|
|
break;
|
|
case 'f':
|
|
force = 1;
|
|
break;
|
|
case 'c':
|
|
check = 1;
|
|
break;
|
|
case 'q':
|
|
quiet++;
|
|
break;
|
|
case 'b':
|
|
boot_cpuid_phys = strtol(optarg, NULL, 0);
|
|
break;
|
|
case 'v':
|
|
printf("Version: %s\n", DTC_VERSION);
|
|
exit(0);
|
|
case 'h':
|
|
default:
|
|
usage();
|
|
}
|
|
}
|
|
|
|
if (argc > (optind+1))
|
|
usage();
|
|
else if (argc < (optind+1))
|
|
arg = "-";
|
|
else
|
|
arg = argv[optind];
|
|
|
|
fprintf(stderr, "DTC: %s->%s on file \"%s\"\n",
|
|
inform, outform, arg);
|
|
|
|
if (streq(inform, "dts")) {
|
|
bi = dt_from_source(arg);
|
|
} else if (streq(inform, "fs")) {
|
|
bi = dt_from_fs(arg);
|
|
} else if(streq(inform, "dtb")) {
|
|
inf = dtc_open_file(arg);
|
|
bi = dt_from_blob(inf);
|
|
} else {
|
|
die("Unknown input format \"%s\"\n", inform);
|
|
}
|
|
|
|
if (inf && (inf != stdin))
|
|
fclose(inf);
|
|
|
|
if (! bi || ! bi->dt)
|
|
die("Couldn't read input tree\n");
|
|
|
|
structure_ok = check_structure(bi->dt);
|
|
if (!structure_ok) {
|
|
if (!force) {
|
|
fprintf(stderr, "ERROR: Input tree has structural errors, aborting (use -f to force output)\n");
|
|
exit(2);
|
|
} else if (quiet < 3) {
|
|
fprintf(stderr, "Warning: Input tree has structural errors, output forced\n");
|
|
}
|
|
}
|
|
|
|
fixup_references(bi->dt);
|
|
|
|
if (check) {
|
|
if (!structure_ok) {
|
|
fprintf(stderr, "Warning: Skipping semantic checks due to structural errors\n");
|
|
} else {
|
|
if (!check_semantics(bi->dt, outversion,
|
|
boot_cpuid_phys))
|
|
fprintf(stderr, "Warning: Input tree has semantic errors\n");
|
|
}
|
|
}
|
|
|
|
if (streq(outname, "-")) {
|
|
outf = stdout;
|
|
} else {
|
|
outf = fopen(outname, "w");
|
|
if (! outf)
|
|
die("Couldn't open output file %s: %s\n",
|
|
outname, strerror(errno));
|
|
}
|
|
|
|
if (streq(outform, "dts")) {
|
|
dt_to_source(outf, bi);
|
|
} else if (streq(outform, "dtb")) {
|
|
dt_to_blob(outf, bi, outversion, boot_cpuid_phys);
|
|
} else if (streq(outform, "asm")) {
|
|
dt_to_asm(outf, bi, outversion, boot_cpuid_phys);
|
|
} else if (streq(outform, "null")) {
|
|
/* do nothing */
|
|
} else {
|
|
die("Unknown output format \"%s\"\n", outform);
|
|
}
|
|
|
|
exit(0);
|
|
}
|