LineageOS/android_external_gptfdisk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added a couple of new verification checks and minor tweaks.

Browse Source
This commit is contained in:
Rod Smith
2017-07-23 11:50:17 -04:00
parent 503e9ada12
commit 0dfa506ba6
5 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
gpt.cc
View File

@@ -276,7 +276,7 @@ int GPTData::Verify(void) {
<< "The 'e' option on the experts' menu may fix this problem.\n";
} // if
// Check the main and backup partition tables for overlap with things
// Check the main and backup partition tables for overlap with things and unusual gaps
if (mainHeader.partitionEntriesLBA + GetTableSizeInSectors() > mainHeader.firstUsableLBA) {
problems++;
cout << "\nProblem: Main partition table extends past the first usable LBA.\n"
@@ -292,6 +292,28 @@ int GPTData::Verify(void) {
cout << "\nProblem: The backup partition table overlaps the backup header.\n"
<< "Using 'e' on the experts' menu may fix this problem.\n";
} // if
if (mainHeader.partitionEntriesLBA != 2) {
cout << "\nWarning: There is a gap between the main metadata (sector 1) and the main\n"
<< "partition table (sector " << mainHeader.partitionEntriesLBA
<< "). This is helpful in some exotic configurations,\n"
<< "but is generally ill-advised. Using 'j' on the experts' menu can adjust this\n"
<< "gap.\n";
} // if
if (mainHeader.partitionEntriesLBA + GetTableSizeInSectors() != mainHeader.firstUsableLBA) {
cout << "\nWarning: There is a gap between the main partition table (ending sector "
<< mainHeader.partitionEntriesLBA + GetTableSizeInSectors() - 1 << ")\n"
<< "and the first usable sector (" << mainHeader.firstUsableLBA << "). This is helpful in some exotic configurations,\n"
<< "but is unusual. The util-linux fdisk program often creates disks like this.\n"
<< "Using 'j' on the experts' menu can adjust this gap.\n";
} // if
if (mainHeader.sizeOfPartitionEntries * mainHeader.numParts < 16384) {
cout << "\nWarning: The size of the partition table (" << mainHeader.sizeOfPartitionEntries * mainHeader.numParts
<< " bytes) is less than the minimum\n"
<< "required by the GPT specification. Most OSes and tools seem to work fine on\n"
<< "such disks, but this is a violation of the GPT specification and so may cause\n"
<< "problems.\n";
} // if
if ((mainHeader.lastUsableLBA >= diskSize) || (mainHeader.lastUsableLBA > mainHeader.backupLBA)) {
problems++;