From 3f433cdb8ea0a93d7dff4818f920ae74fe012d3f Mon Sep 17 00:00:00 2001 From: Marshall Clow Date: Mon, 7 Oct 2013 02:37:18 +0000 Subject: [PATCH] Apparently, I don't know the difference between 'left' and 'right'. Swap parameters named 'lhs' and 'rhs' so that they correctly refer to the 'left hand side' and 'right hand side' of comparisons. No functionality change. Thanks to Arthur O'Dwyer for pointing this out to me. git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@192080 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/utilities/optional/optional.comp_with_t/equal.pass.cpp | 4 ++-- .../optional/optional.comp_with_t/less_than.pass.cpp | 4 ++-- test/utilities/optional/optional.relops/equal.pass.cpp | 4 ++-- test/utilities/optional/optional.relops/less_than.pass.cpp | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/utilities/optional/optional.comp_with_t/equal.pass.cpp b/test/utilities/optional/optional.comp_with_t/equal.pass.cpp index 81150ad2c..e833b22a3 100644 --- a/test/utilities/optional/optional.comp_with_t/equal.pass.cpp +++ b/test/utilities/optional/optional.comp_with_t/equal.pass.cpp @@ -23,8 +23,8 @@ struct X constexpr X(int i) : i_(i) {} }; -constexpr bool operator == ( const X &rhs, const X &lhs ) - { return rhs.i_ == lhs.i_ ; } +constexpr bool operator == ( const X &lhs, const X &rhs ) + { return lhs.i_ == rhs.i_ ; } #endif diff --git a/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp b/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp index c71c8cc91..e8bb1dcda 100644 --- a/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp +++ b/test/utilities/optional/optional.comp_with_t/less_than.pass.cpp @@ -23,8 +23,8 @@ struct X constexpr X(int i) : i_(i) {} }; -constexpr bool operator < ( const X &rhs, const X &lhs ) - { return rhs.i_ < lhs.i_ ; } +constexpr bool operator < ( const X &lhs, const X &rhs ) + { return lhs.i_ < rhs.i_ ; } #endif diff --git a/test/utilities/optional/optional.relops/equal.pass.cpp b/test/utilities/optional/optional.relops/equal.pass.cpp index a600d07ec..3bbbb4e58 100644 --- a/test/utilities/optional/optional.relops/equal.pass.cpp +++ b/test/utilities/optional/optional.relops/equal.pass.cpp @@ -24,8 +24,8 @@ struct X constexpr X(int i) : i_(i) {} }; -constexpr bool operator == ( const X &rhs, const X &lhs ) - { return rhs.i_ == lhs.i_ ; } +constexpr bool operator == ( const X &lhs, const X &rhs ) + { return lhs.i_ == rhs.i_ ; } #endif diff --git a/test/utilities/optional/optional.relops/less_than.pass.cpp b/test/utilities/optional/optional.relops/less_than.pass.cpp index 6bcb30466..515ca9cae 100644 --- a/test/utilities/optional/optional.relops/less_than.pass.cpp +++ b/test/utilities/optional/optional.relops/less_than.pass.cpp @@ -22,8 +22,8 @@ struct X constexpr X(int i) : i_(i) {} }; -constexpr bool operator < ( const X &rhs, const X &lhs ) - { return rhs.i_ < lhs.i_ ; } +constexpr bool operator < ( const X &lhs, const X &rhs ) + { return lhs.i_ < rhs.i_ ; } #endif