LineageOS/android_external_libcxx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[libcxx] Fix memory leak in strstream tests.

Browse Source 
Summary: The strstream function `str()` sets `freeze(true)`. When `freeze` is true the destructor is not allowed to free any dynamically allocated memory. The memory leak causes ASAN to fail on these tests. To ensure memory is deallocated `strstream.freeze(false)` is called at the end of the tests.

Reviewers: danalbert, mclow.lists

Reviewed By: mclow.lists

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D6261

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@222025 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eric Fiselier
2014-11-14 19:10:43 +00:00
parent d759095887
commit 50ada3a8f7
8 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/depr/depr.str.strstreams/depr.ostrstream/depr.ostrstream.cons/default.pass.cpp
View File

@@ -24,4 +24,5 @@ int main()
std::string s("dog"); std::string s("dog");
out << i << ' ' << d << ' ' << s << std::ends; out << i << ' ' << d << ' ' << s << std::ends;
assert(out.str() == std::string("123 4.5 dog")); assert(out.str() == std::string("123 4.5 dog"));
out.freeze(false);
} }

1
test/depr/depr.str.strstreams/depr.ostrstream/depr.ostrstream.members/freeze.pass.cpp
View File

@@ -29,5 +29,6 @@ int main()
out << 'a'; out << 'a';
out << char(0); out << char(0);
assert(out.str() == std::string("a")); assert(out.str() == std::string("a"));
out.freeze(false);
} }
} }

1
test/depr/depr.str.strstreams/depr.ostrstream/depr.ostrstream.members/str.pass.cpp
View File

@@ -22,5 +22,6 @@ int main()
std::ostrstream out; std::ostrstream out;
out << 123 << ' ' << 4.5 << ' ' << "dog" << std::ends; out << 123 << ' ' << 4.5 << ' ' << "dog" << std::ends;
assert(out.str() == std::string("123 4.5 dog")); assert(out.str() == std::string("123 4.5 dog"));
out.freeze(false);
} }
} }

1
test/depr/depr.str.strstreams/depr.strstream/depr.strstream.cons/default.pass.cpp
View File

@@ -31,4 +31,5 @@ int main()
assert(i == 123); assert(i == 123);
assert(d == 4.5); assert(d == 4.5);
assert(strcmp(s.c_str(), "dog") == 0); assert(strcmp(s.c_str(), "dog") == 0);
inout.freeze(false);
} }

1
test/depr/depr.str.strstreams/depr.strstream/depr.strstream.oper/freeze.pass.cpp
View File

@@ -29,5 +29,6 @@ int main()
out << 'a'; out << 'a';
out << char(0); out << char(0);
assert(out.str() == std::string("a")); assert(out.str() == std::string("a"));
out.freeze(false);
} }
} }

1
test/depr/depr.str.strstreams/depr.strstream/depr.strstream.oper/str.pass.cpp
View File

@@ -22,5 +22,6 @@ int main()
std::strstream out; std::strstream out;
out << 123 << ' ' << 4.5 << ' ' << "dog" << std::ends; out << 123 << ' ' << 4.5 << ' ' << "dog" << std::ends;
assert(out.str() == std::string("123 4.5 dog")); assert(out.str() == std::string("123 4.5 dog"));
out.freeze(false);
} }
} }

1
test/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/pcount.pass.cpp
View File

@@ -27,5 +27,6 @@ int main()
assert(sb.pcount() == 2); assert(sb.pcount() == 2);
assert(sb.str() == std::string("a")); assert(sb.str() == std::string("a"));
assert(sb.pcount() == 2); assert(sb.pcount() == 2);
sb.freeze(false);
} }
} }

1
test/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/str.pass.cpp
View File

@@ -23,5 +23,6 @@ int main()
assert(sb.sputc('a') == 'a'); assert(sb.sputc('a') == 'a');
assert(sb.sputc(0) == 0); assert(sb.sputc(0) == 0);
assert(sb.str() == std::string("a")); assert(sb.str() == std::string("a"));
sb.freeze(false);
} }
} }