LineageOS/android_external_libcxx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end()

Browse Source 
The standard section [array.zero] requires the return value of begin()
and end() methods of a zero-sized array to be unique. Eric Fiselier
clarifies: "That unique value cannot be null, and must be properly aligned".
This patch adds checks for the first part of this clarification: unique
value returned by these methods cannot be null.

Reviewed as https://reviews.llvm.org/D55366.
Thanks to Andrey Maksimov for the patch.

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@348509 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Louis Dionne
2018-12-06 18:24:39 +00:00
parent 7ea279fbed
commit 5b19b0bb3f
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/std/containers/sequences/array/begin.pass.cpp
View File

@@ -14,6 +14,8 @@
#include <array> #include <array>
#include <cassert> #include <cassert>
#include "test_macros.h"
// std::array is explicitly allowed to be initialized with A a = { init-list };. // std::array is explicitly allowed to be initialized with A a = { init-list };.
// Disable the missing braces warning for this reason. // Disable the missing braces warning for this reason.
#include "disable_missing_braces_warning.h" #include "disable_missing_braces_warning.h"
@@ -40,6 +42,11 @@ int main()
typedef NoDefault T; typedef NoDefault T;
typedef std::array<T, 0> C; typedef std::array<T, 0> C;
C c = {}; C c = {};
assert(c.begin() == c.end()); C::iterator ib, ie;
ib = c.begin();
ie = c.end();
assert(ib == ie);
LIBCPP_ASSERT(ib != nullptr);
LIBCPP_ASSERT(ie != nullptr);
} }
} }