LineageOS/android_external_libcxx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

Browse Source 
Summary:
This patch fixes llvm.org/PR35491 and LWG2157  (https://cplusplus.github.io/LWG/issue2157)

The fix attempts to maintain ABI compatibility by replacing the array with a instance of `aligned_storage`.

Reviewers: mclow.lists, EricWF

Reviewed By: EricWF

Subscribers: lichray, cfe-commits

Differential Revision: https://reviews.llvm.org/D41223

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@324526 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eric Fiselier
2018-02-07 21:06:13 +00:00
parent f003d63c40
commit 6cb35ede81
19 changed files with 805 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/std/containers/sequences/array/front_back.pass.cpp
View File

@@ -64,7 +64,38 @@ int main()
C::const_reference r2 = c.back();
assert(r2 == 3.5);
}
{
typedef double T;
typedef std::array<T, 0> C;
C c = {};
C const& cc = c;
static_assert((std::is_same<decltype(c.front()), T &>::value), "");
static_assert((std::is_same<decltype(cc.front()), const T &>::value), "");
static_assert((std::is_same<decltype(c.back()), T &>::value), "");
static_assert((std::is_same<decltype(cc.back()), const T &>::value), "");
if (c.size() > (0)) { // always false
TEST_IGNORE_NODISCARD c.front();
TEST_IGNORE_NODISCARD c.back();
TEST_IGNORE_NODISCARD cc.front();
TEST_IGNORE_NODISCARD cc.back();
}
}
{
typedef double T;
typedef std::array<const T, 0> C;
C c = {{}};
C const& cc = c;
static_assert((std::is_same<decltype(c.front()), const T &>::value), "");
static_assert((std::is_same<decltype(cc.front()), const T &>::value), "");
static_assert((std::is_same<decltype(c.back()), const T &>::value), "");
static_assert((std::is_same<decltype(cc.back()), const T &>::value), "");
if (c.size() > (0)) {
TEST_IGNORE_NODISCARD c.front();
TEST_IGNORE_NODISCARD c.back();
TEST_IGNORE_NODISCARD cc.front();
TEST_IGNORE_NODISCARD cc.back();
}
}
#if TEST_STD_VER > 11
{
typedef double T;