From 92f1507ade33e207338edb0c61dc9ba4e7b24b19 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Thu, 28 Jun 2018 18:35:35 +0000 Subject: [PATCH] [CMake] Rename cxx_headers back to cxx-headers. r334477 renamed the cxx-headers target to cxx_headers, but various pieces sort-of expect the target names to match the component (e.g., LLVM_DISTRIBUTION_COMPONENTS in the various bootstrap caches, which, via some magic foreign to me, seems to expect cxx-headers, install-cxx-headers, and install-cxx-headers-stripped to exist.) Revert back to cxx-headers. Differential Revision: https://reviews.llvm.org/D48701 git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@335899 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/CMakeLists.txt | 8 ++++---- lib/CMakeLists.txt | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/CMakeLists.txt b/include/CMakeLists.txt index 91e256331..6bd75915d 100644 --- a/include/CMakeLists.txt +++ b/include/CMakeLists.txt @@ -228,11 +228,11 @@ if(NOT LIBCXX_USING_INSTALLED_LLVM AND LLVM_BINARY_DIR) list(APPEND out_files ${dst}) endif() - add_custom_target(cxx_headers ALL DEPENDS ${out_files} ${LIBCXX_CXX_ABI_HEADER_TARGET}) + add_custom_target(cxx-headers ALL DEPENDS ${out_files} ${LIBCXX_CXX_ABI_HEADER_TARGET}) else() - add_custom_target(cxx_headers) + add_custom_target(cxx-headers) endif() -set_target_properties(cxx_headers PROPERTIES FOLDER "Misc") +set_target_properties(cxx-headers PROPERTIES FOLDER "Misc") if (LIBCXX_INSTALL_HEADERS) foreach(file ${files}) @@ -255,7 +255,7 @@ if (LIBCXX_INSTALL_HEADERS) if (NOT CMAKE_CONFIGURATION_TYPES) add_custom_target(install-cxx-headers - DEPENDS cxx_headers ${generated_config_deps} + DEPENDS cxx-headers ${generated_config_deps} COMMAND "${CMAKE_COMMAND}" -DCMAKE_INSTALL_COMPONENT=cxx-headers -P "${CMAKE_BINARY_DIR}/cmake_install.cmake") diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt index cba5aa9e8..d32f8fb8e 100644 --- a/lib/CMakeLists.txt +++ b/lib/CMakeLists.txt @@ -286,7 +286,7 @@ if (LIBCXX_ENABLE_STATIC) endif() # Add a meta-target for both libraries. -add_custom_target(cxx DEPENDS cxx_headers ${LIBCXX_TARGETS}) +add_custom_target(cxx DEPENDS cxx-headers ${LIBCXX_TARGETS}) if (LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY) file(GLOB LIBCXX_EXPERIMENTAL_SOURCES ../src/experimental/*.cpp)