From 9f6e23c7c9ec505f2185f4dac3a2df372f94a9c1 Mon Sep 17 00:00:00 2001 From: Eric Fiselier Date: Fri, 21 Apr 2017 03:09:40 +0000 Subject: [PATCH] update XFAIL comments with more details git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@300944 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp | 5 ++--- .../conversions/conversions.string/ctor_move.pass.cpp | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp b/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp index b5cee3960..51a1f2307 100644 --- a/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp +++ b/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp @@ -7,9 +7,8 @@ // //===----------------------------------------------------------------------===// -// There appears to be a bug in VerifyDiagnosticReporter on Windows that -// causes -verify to not see the emitted warnings even though they are -// actually getting omitted. +// This test fails because diagnose_if doesn't emit all of the diagnostics +// when -fdelayed-template-parsing is enabled, like it is on Windows. // XFAIL: LIBCXX-WINDOWS-FIXME // REQUIRES: verify-support, diagnose-if-support diff --git a/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp b/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp index 3983d803a..18cc0ca97 100644 --- a/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp +++ b/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp @@ -7,8 +7,7 @@ // //===----------------------------------------------------------------------===// -// This test fails because the `from_bytes` call seems to result in a call -// to 'abort()' +// 'do_bytes' throws a std::range_error unexpectedly // XFAIL: LIBCXX-WINDOWS-FIXME // UNSUPPORTED: c++98, c++03