Fix PR33727: std::basic_stringbuf only works with DefaultConstructible allocators. Thanks to Jonathan Wakely for the report and suggested fix

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@309838 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Marshall Clow
2017-08-02 17:31:09 +00:00
parent 4876a73b0a
commit b3d6031a54
2 changed files with 21 additions and 1 deletions

View File

@@ -18,6 +18,16 @@
#include <sstream>
#include <cassert>
template<typename T>
struct NoDefaultAllocator : std::allocator<T>
{
template<typename U> struct rebind { using other = NoDefaultAllocator<U>; };
NoDefaultAllocator(int id) : id(id) { }
template<typename U> NoDefaultAllocator(const NoDefaultAllocator<U>& a) : id(a.id) { }
int id;
};
int main()
{
{
@@ -46,4 +56,13 @@ int main()
ss << i << ' ' << 123;
assert(ss.str() == L"456 1236 ");
}
{ // This is https://bugs.llvm.org/show_bug.cgi?id=33727
typedef std::basic_string <char, std::char_traits<char>, NoDefaultAllocator<char> > S;
typedef std::basic_stringbuf<char, std::char_traits<char>, NoDefaultAllocator<char> > SB;
S s(NoDefaultAllocator<char>(1));
SB sb(s);
// This test is not required by the standard, but *where else* could it get the allocator?
assert(sb.str().get_allocator() == s.get_allocator());
}
}