From e630058e904a849ceb5d6ec3066225cfe424aa01 Mon Sep 17 00:00:00 2001 From: Eric Fiselier Date: Fri, 14 Oct 2016 21:30:35 +0000 Subject: [PATCH] Clarify XFAIL comments git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@284282 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../new.delete.array/delete_align_val_t_replace.pass.cpp | 3 ++- .../new.delete.single/delete_align_val_t_replace.pass.cpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp b/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp index b8a5f7c44..62ffa3f6f 100644 --- a/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp +++ b/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp @@ -17,7 +17,7 @@ // None of the current GCC compilers support this. // XFAIL: gcc-4, gcc-5, gcc-6 -// UBSAN replaces certain new/delete functions which makes this test fail +// TODO Investigate why UBSAN prevents new from calling our replacement. // XFAIL: ubsan #include @@ -60,6 +60,7 @@ struct alignas(std::max_align_t) B {}; int main() { + reset(); { B *x = new B[2]; assert(0 == unsized_delete_called); diff --git a/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp b/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp index 02522d0b1..67a51911b 100644 --- a/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp +++ b/test/std/language.support/support.dynamic/new.delete/new.delete.single/delete_align_val_t_replace.pass.cpp @@ -17,7 +17,7 @@ // None of the current GCC compilers support this. // XFAIL: gcc-4, gcc-5, gcc-6 -// UBSAN replaces certain new/delete functions which makes this test fail +// TODO Investigate why UBSAN prevents new from calling our replacement. // XFAIL: ubsan #include @@ -60,6 +60,7 @@ struct alignas(std::max_align_t) B {}; int main() { + reset(); { B *x = new B; assert(0 == unsized_delete_called);