LineageOS/android_external_libcxx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make lcm/gcd work better in edge cases. Fixes a UBSAN failure.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@294779 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Marshall Clow
2017-02-10 20:49:08 +00:00
parent 00d9a944af
commit ebf66a385f
6 changed files with 52 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/std/experimental/numeric/numeric.ops/numeric.ops.gcd/gcd.pass.cpp
View File

@@ -129,4 +129,11 @@ int main()
assert((do_test<long, int>(non_cce)));
assert((do_test<int, long long>(non_cce)));
assert((do_test<long long, int>(non_cce)));
// LWG#2792
{
auto res = std::gcd((int64_t)1234, (int32_t)-2147483648);
static_assert( std::is_same<decltype(res), std::common_type<int64_t, int32_t>::type>::value, "");
assert(res == 2);
}
}

8
test/std/experimental/numeric/numeric.ops/numeric.ops.lcm/lcm.pass.cpp
View File

@@ -128,4 +128,12 @@ int main()
assert((do_test<long, int>(non_cce)));
assert((do_test<int, long long>(non_cce)));
assert((do_test<long long, int>(non_cce)));
// LWG#2792
{
auto res1 = std::lcm((int64_t)1234, (int32_t)-2147483648);
(void) std::lcm<int, unsigned long>(INT_MIN, 2); // this used to trigger UBSAN
static_assert( std::is_same<decltype(res1), std::common_type<int64_t, int32_t>::type>::value, "");
assert(res1 == 1324997410816LL);
}
}