4159a369fe
Summary: [libcxx] Fix basic_stringbuf constructor The C++ Standard [stringbuf.cons]p1 defines the effects of the basic_stringbuf constructor that takes ios_base::openmode as follows: Effects: Constructs an object of class basic_stringbuf, initializing the base class with basic_streambuf(), and initializing mode with which. Postconditions: str() == "". The default constructor of basic_streambuf shall initialize all its pointer member objects to null pointers [streambuf.cons]p1. Currently libc++ calls "str(string_type());" in the aforementioned constructor setting basic_streambuf's pointers to a non-null value. This patch removes the call (note that the postcondition str() == "" remains valid because __str_ is default-initialized) and adds a test checking that the basic_streambuf's pointers are null after construction. Thanks Mikhail Maltsev for the patch. Reviewers: EricWF, mclow.lists Reviewed By: mclow.lists Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D40707 git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@320604 91177308-0d34-0410-b5e6-96231b3b80d8
54 lines
1.2 KiB
C++
54 lines
1.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is dual licensed under the MIT and the University of Illinois Open
|
|
// Source Licenses. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// <sstream>
|
|
|
|
// template <class charT, class traits = char_traits<charT>, class Allocator = allocator<charT> >
|
|
// class basic_stringbuf
|
|
|
|
// explicit basic_stringbuf(ios_base::openmode which = ios_base::in | ios_base::out);
|
|
|
|
#include <sstream>
|
|
#include <cassert>
|
|
|
|
template<typename CharT>
|
|
struct testbuf
|
|
: std::basic_stringbuf<CharT>
|
|
{
|
|
void check()
|
|
{
|
|
assert(this->eback() == NULL);
|
|
assert(this->gptr() == NULL);
|
|
assert(this->egptr() == NULL);
|
|
assert(this->pbase() == NULL);
|
|
assert(this->pptr() == NULL);
|
|
assert(this->epptr() == NULL);
|
|
}
|
|
};
|
|
|
|
int main()
|
|
{
|
|
{
|
|
std::stringbuf buf;
|
|
assert(buf.str() == "");
|
|
}
|
|
{
|
|
std::wstringbuf buf;
|
|
assert(buf.str() == L"");
|
|
}
|
|
{
|
|
testbuf<char> buf;
|
|
buf.check();
|
|
}
|
|
{
|
|
testbuf<wchar_t> buf;
|
|
buf.check();
|
|
}
|
|
}
|