LineageOS/android_external_libvpx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compiler_attributes.h: add VPX_NO_UNSIGNED_SHIFT_CHECK

Browse Source 
and use it on MD5Transform(); this behavior is well defined and is only
a warning with -fsanitize=integer, not -fsanitize=undefined.

quiets warnings of the form:
md5_utils.c:163:3: runtime error: left shift of 143704723 by 7 places
cannot be represented in type 'unsigned int'

Bug: b/229626362
Change-Id: I60a384b2c2556f5ce71ad8ebce050329aba0b4e4
This commit is contained in:
James Zern
2022-08-17 19:20:25 -07:00
parent cf5ef2b985
commit 002b6b1ce0
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
md5_utils.c
View File

@@ -151,8 +151,8 @@ void MD5Final(md5byte digest[16], struct MD5Context *ctx) {
* reflect the addition of 16 longwords of new data. MD5Update blocks * reflect the addition of 16 longwords of new data. MD5Update blocks
* the data and converts bytes into longwords for this routine. * the data and converts bytes into longwords for this routine.
*/ */
VPX_NO_UNSIGNED_OVERFLOW_CHECK void MD5Transform(UWORD32 buf[4], VPX_NO_UNSIGNED_OVERFLOW_CHECK VPX_NO_UNSIGNED_SHIFT_CHECK void MD5Transform(
UWORD32 const in[16]) { UWORD32 buf[4], UWORD32 const in[16]) {
UWORD32 a, b, c, d; UWORD32 a, b, c, d;
a = buf[0]; a = buf[0];

12
vpx_ports/compiler_attributes.h
View File

@@ -29,13 +29,23 @@
#endif // __has_feature(address_sanitizer) || defined(__SANITIZE_ADDRESS__) #endif // __has_feature(address_sanitizer) || defined(__SANITIZE_ADDRESS__)
#if defined(__clang__) && __has_attribute(no_sanitize) #if defined(__clang__) && __has_attribute(no_sanitize)
// Both of these have defined behavior and are used in certain operations or
// optimizations thereof. There are cases where an overflow may be unintended,
// however, so use of these attributes should be done with care.
#define VPX_NO_UNSIGNED_OVERFLOW_CHECK \ #define VPX_NO_UNSIGNED_OVERFLOW_CHECK \
__attribute__((no_sanitize("unsigned-integer-overflow"))) __attribute__((no_sanitize("unsigned-integer-overflow")))
#endif #if __clang_major__ >= 12
#define VPX_NO_UNSIGNED_SHIFT_CHECK \
__attribute__((no_sanitize("unsigned-shift-base")))
#endif // __clang__ >= 12
#endif // __clang__
#ifndef VPX_NO_UNSIGNED_OVERFLOW_CHECK #ifndef VPX_NO_UNSIGNED_OVERFLOW_CHECK
#define VPX_NO_UNSIGNED_OVERFLOW_CHECK #define VPX_NO_UNSIGNED_OVERFLOW_CHECK
#endif #endif
#ifndef VPX_NO_UNSIGNED_SHIFT_CHECK
#define VPX_NO_UNSIGNED_SHIFT_CHECK
#endif
//------------------------------------------------------------------------------ //------------------------------------------------------------------------------
// Variable attributes. // Variable attributes.